Skip to content

Commit 30a5c70

Browse files
Merge pull request #7878 from netbox-community/7877-bootstrapmixin-cleanup
Closes #7877: BootstrapMixin cleanup
2 parents d2767f3 + beca978 commit 30a5c70

File tree

24 files changed

+193
-217
lines changed

24 files changed

+193
-217
lines changed

netbox/circuits/forms/bulk_edit.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
from circuits.models import *
55
from extras.forms import AddRemoveTagsForm, CustomFieldModelBulkEditForm
66
from tenancy.models import Tenant
7-
from utilities.forms import (
8-
add_blank_choice, BootstrapMixin, CommentField, DynamicModelChoiceField, SmallTextarea, StaticSelect,
9-
)
7+
from utilities.forms import add_blank_choice, CommentField, DynamicModelChoiceField, SmallTextarea, StaticSelect
108

119
__all__ = (
1210
'CircuitBulkEditForm',
@@ -16,7 +14,7 @@
1614
)
1715

1816

19-
class ProviderBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldModelBulkEditForm):
17+
class ProviderBulkEditForm(AddRemoveTagsForm, CustomFieldModelBulkEditForm):
2018
pk = forms.ModelMultipleChoiceField(
2119
queryset=Provider.objects.all(),
2220
widget=forms.MultipleHiddenInput
@@ -55,7 +53,7 @@ class Meta:
5553
]
5654

5755

58-
class ProviderNetworkBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldModelBulkEditForm):
56+
class ProviderNetworkBulkEditForm(AddRemoveTagsForm, CustomFieldModelBulkEditForm):
5957
pk = forms.ModelMultipleChoiceField(
6058
queryset=ProviderNetwork.objects.all(),
6159
widget=forms.MultipleHiddenInput
@@ -79,7 +77,7 @@ class Meta:
7977
]
8078

8179

82-
class CircuitTypeBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldModelBulkEditForm):
80+
class CircuitTypeBulkEditForm(AddRemoveTagsForm, CustomFieldModelBulkEditForm):
8381
pk = forms.ModelMultipleChoiceField(
8482
queryset=CircuitType.objects.all(),
8583
widget=forms.MultipleHiddenInput
@@ -93,7 +91,7 @@ class Meta:
9391
nullable_fields = ['description']
9492

9593

96-
class CircuitBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldModelBulkEditForm):
94+
class CircuitBulkEditForm(AddRemoveTagsForm, CustomFieldModelBulkEditForm):
9795
pk = forms.ModelMultipleChoiceField(
9896
queryset=Circuit.objects.all(),
9997
widget=forms.MultipleHiddenInput

netbox/circuits/forms/filtersets.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
from dcim.models import Region, Site, SiteGroup
77
from extras.forms import CustomFieldModelFilterForm
88
from tenancy.forms import TenancyFilterForm
9-
from utilities.forms import BootstrapMixin, DynamicModelMultipleChoiceField, StaticSelectMultiple, TagFilterField
9+
from utilities.forms import DynamicModelMultipleChoiceField, StaticSelectMultiple, TagFilterField
1010

1111
__all__ = (
1212
'CircuitFilterForm',
@@ -16,7 +16,7 @@
1616
)
1717

1818

19-
class ProviderFilterForm(BootstrapMixin, CustomFieldModelFilterForm):
19+
class ProviderFilterForm(CustomFieldModelFilterForm):
2020
model = Provider
2121
field_groups = [
2222
['q', 'tag'],
@@ -57,7 +57,7 @@ class ProviderFilterForm(BootstrapMixin, CustomFieldModelFilterForm):
5757
tag = TagFilterField(model)
5858

5959

60-
class ProviderNetworkFilterForm(BootstrapMixin, CustomFieldModelFilterForm):
60+
class ProviderNetworkFilterForm(CustomFieldModelFilterForm):
6161
model = ProviderNetwork
6262
field_groups = (
6363
('q', 'tag'),
@@ -77,7 +77,7 @@ class ProviderNetworkFilterForm(BootstrapMixin, CustomFieldModelFilterForm):
7777
tag = TagFilterField(model)
7878

7979

80-
class CircuitTypeFilterForm(BootstrapMixin, CustomFieldModelFilterForm):
80+
class CircuitTypeFilterForm(CustomFieldModelFilterForm):
8181
model = CircuitType
8282
q = forms.CharField(
8383
required=False,
@@ -87,7 +87,7 @@ class CircuitTypeFilterForm(BootstrapMixin, CustomFieldModelFilterForm):
8787
tag = TagFilterField(model)
8888

8989

90-
class CircuitFilterForm(BootstrapMixin, TenancyFilterForm, CustomFieldModelFilterForm):
90+
class CircuitFilterForm(TenancyFilterForm, CustomFieldModelFilterForm):
9191
model = Circuit
9292
field_groups = [
9393
['q', 'tag'],

netbox/circuits/forms/models.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
)
2020

2121

22-
class ProviderForm(BootstrapMixin, CustomFieldModelForm):
22+
class ProviderForm(CustomFieldModelForm):
2323
slug = SlugField()
2424
comments = CommentField()
2525
tags = DynamicModelMultipleChoiceField(
@@ -53,7 +53,7 @@ class Meta:
5353
}
5454

5555

56-
class ProviderNetworkForm(BootstrapMixin, CustomFieldModelForm):
56+
class ProviderNetworkForm(CustomFieldModelForm):
5757
provider = DynamicModelChoiceField(
5858
queryset=Provider.objects.all()
5959
)
@@ -73,7 +73,7 @@ class Meta:
7373
)
7474

7575

76-
class CircuitTypeForm(BootstrapMixin, CustomFieldModelForm):
76+
class CircuitTypeForm(CustomFieldModelForm):
7777
slug = SlugField()
7878
tags = DynamicModelMultipleChoiceField(
7979
queryset=Tag.objects.all(),
@@ -87,7 +87,7 @@ class Meta:
8787
]
8888

8989

90-
class CircuitForm(BootstrapMixin, TenancyForm, CustomFieldModelForm):
90+
class CircuitForm(TenancyForm, CustomFieldModelForm):
9191
provider = DynamicModelChoiceField(
9292
queryset=Provider.objects.all()
9393
)

netbox/dcim/forms/bulk_create.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from dcim.models import *
44
from extras.forms import CustomFieldsMixin
55
from extras.models import Tag
6-
from utilities.forms import BootstrapMixin, DynamicModelMultipleChoiceField, form_from_model
6+
from utilities.forms import DynamicModelMultipleChoiceField, form_from_model
77
from .object_create import ComponentForm
88

99
__all__ = (
@@ -23,7 +23,7 @@
2323
# Device components
2424
#
2525

26-
class DeviceBulkAddComponentForm(BootstrapMixin, CustomFieldsMixin, ComponentForm):
26+
class DeviceBulkAddComponentForm(CustomFieldsMixin, ComponentForm):
2727
pk = forms.ModelMultipleChoiceField(
2828
queryset=Device.objects.all(),
2929
widget=forms.MultipleHiddenInput()

0 commit comments

Comments
 (0)