Skip to content

Commit 9316f48

Browse files
committed
Fixes #15982: Restore the "assign IP" tab
1 parent acc2add commit 9316f48

File tree

4 files changed

+44
-51
lines changed

4 files changed

+44
-51
lines changed

netbox/ipam/views.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -781,6 +781,7 @@ def get_extra_context(self, request, instance):
781781
class IPAddressEditView(generic.ObjectEditView):
782782
queryset = IPAddress.objects.all()
783783
form = forms.IPAddressForm
784+
template_name = 'ipam/ipaddress_edit.html'
784785

785786
def alter_object(self, obj, request, url_args, url_kwargs):
786787

netbox/templates/ipam/inc/ipaddress_edit_header.html

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -3,30 +3,21 @@
33

44
<ul class="nav nav-tabs">
55
<li class="nav-item">
6-
<a
7-
class="nav-link {% if active_tab == 'add' %}active{% endif %}"
8-
href="{% url 'ipam:ipaddress_add' %}{% querystring request %}"
9-
>
10-
{% if obj.pk %}{% trans "Edit" %}{% else %}{% trans "Create" %}{% endif %}
11-
</a>
6+
<a href="{% url 'ipam:ipaddress_add' %}{% querystring request %}" class="nav-link {% if active_tab == 'add' %}active{% endif %}">
7+
{% if object.pk %}{% trans "Edit" %}{% else %}{% trans "Create" %}{% endif %}
8+
</a>
129
</li>
1310
{% if 'interface' in request.GET or 'vminterface' in request.GET %}
14-
<li class="nav-item">
15-
<a
16-
class="nav-link {% if active_tab == 'assign' %}active{% endif %}"
17-
href="{% url 'ipam:ipaddress_assign' %}{% querystring request %}"
18-
>
19-
{% trans "Assign IP" %}
11+
<li class="nav-item">
12+
<a href="{% url 'ipam:ipaddress_assign' %}{% querystring request %}" class="nav-link {% if active_tab == 'assign' %}active{% endif %}">
13+
{% trans "Assign IP" %}
2014
</a>
21-
</li>
22-
{% else %}
23-
<li class="nav-item">
24-
<a
25-
class="nav-link {% if active_tab == 'bulk_add' %}active{% endif %}"
26-
href="{% url 'ipam:ipaddress_bulk_add' %}{% querystring request %}"
27-
>
28-
{% trans "Bulk Create" %}
15+
</li>
16+
{% elif not object.pk %}
17+
<li class="nav-item">
18+
<a href="{% url 'ipam:ipaddress_bulk_add' %}{% querystring request %}" class="nav-link {% if active_tab == 'bulk_add' %}active{% endif %}">
19+
{% trans "Bulk Create" %}
2920
</a>
30-
</li>
21+
</li>
3122
{% endif %}
3223
</ul>

netbox/templates/ipam/ipaddress_assign.html

Lines changed: 26 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -12,37 +12,33 @@
1212
{% endblock %}
1313

1414
{% block form %}
15-
<form action="{% querystring request %}" method="post" class="form form-horizontal">
16-
{% csrf_token %}
17-
{% for field in form.hidden_fields %}
18-
{{ field }}
19-
{% endfor %}
20-
<div class="row mb-3">
21-
<div class="col col-md-8 offset-md-2">
22-
<div class="field-group">
23-
<h6>{% trans "Select IP Address" %}</h6>
24-
{% render_field form.vrf_id %}
25-
{% render_field form.q %}
26-
</div>
27-
</div>
15+
<form action="{% querystring request %}" method="post" class="form form-horizontal">
16+
{% csrf_token %}
17+
{% for field in form.hidden_fields %}
18+
{{ field }}
19+
{% endfor %}
20+
<div class="field-group my-5">
21+
<div class="row">
22+
<h5 class="col-9 offset-3">{% trans "Select IP Address" %}</h5>
23+
</div>
24+
{% render_field form.vrf_id %}
25+
{% render_field form.q %}
26+
</div>
27+
<div class="text-end my-3">
28+
<a href="{{ return_url }}" class="btn btn-outline-secondary">{% trans "Cancel" %}</a>
29+
<button type="submit" class="btn btn-primary">{% trans "Search" %}</button>
30+
</div>
31+
</form>
32+
{% if table %}
33+
<div class="row mb-3">
34+
<div class="col col-md-12">
35+
<h3>{% trans "Search Results" %}</h3>
36+
<div class="table-responsive">
37+
{% render_table table 'inc/table.html' %}
2838
</div>
29-
<div class="row mb-3">
30-
<div class="col col-md-8 offset-md-2 text-end">
31-
<a href="{{ return_url }}" class="btn btn-outline-secondary">{% trans "Cancel" %}</a>
32-
<button type="submit" class="btn btn-primary">{% trans "Search" %}</button>
33-
</div>
34-
</div>
35-
</form>
36-
{% if table %}
37-
<div class="row mb-3">
38-
<div class="col col-md-12">
39-
<h3>{% trans "Search Results" %}</h3>
40-
<div class="table-responsive">
41-
{% render_table table 'inc/table.html' %}
42-
</div>
43-
</div>
44-
</div>
45-
{% endif %}
39+
</div>
40+
</div>
41+
{% endif %}
4642
{% endblock form %}
4743

4844
{% block buttons %}
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{% extends 'generic/object_edit.html' %}
2+
3+
{% block tabs %}
4+
{% include 'ipam/inc/ipaddress_edit_header.html' with active_tab='add' %}
5+
{% endblock %}

0 commit comments

Comments
 (0)