Fixes #13859: Fix valid response when no matching choice values are found

jeremystretch · jeremystretch · commit b759d694ee9d · 2023-09-26T12:08:05.000-04:00
diff --git a/netbox/extras/api/views.py b/netbox/extras/api/views.py
@@ -82,7 +82,10 @@ def choices(self, request, pk):
             data = [
                 {'id': c[0], 'display': c[1]} for c in page
             ]
-            return self.get_paginated_response(data)
+        else:
+            data = []
+
+        return self.get_paginated_response(data)
 
 
 #

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,10 @@ def choices(self, request, pk):`
`82`	`82`	`data = [`
`83`	`83`	`{'id': c[0], 'display': c[1]} for c in page`
`84`	`84`	`]`
`85`		`- return self.get_paginated_response(data)`
	`85`	`+ else:`
	`86`	`+ data = []`
	`87`	`+`
	`88`	`+ return self.get_paginated_response(data)`
`86`	`89`
`87`	`90`
`88`	`91`	`#`