Skip to content

Commit c818d63

Browse files
committed
Fixes #7427: Don't select hidden rows when selecting all in a table
1 parent c9c537a commit c818d63

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

docs/release-notes/version-3.0.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
* [#6423](https://github.com/netbox-community/netbox/issues/6423) - Cache rendered REST API specifications
99
* [#6708](https://github.com/netbox-community/netbox/issues/6708) - Add image attachment support for circuits, power panels
1010
* [#7387](https://github.com/netbox-community/netbox/issues/7387) - Enable arbitrary ordering of custom scripts
11+
* [#7427](https://github.com/netbox-community/netbox/issues/7427) - Don't select hidden rows when selecting all in a table
1112

1213
### Bug Fixes
1314

netbox/project-static/dist/netbox.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

netbox/project-static/dist/netbox.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

netbox/project-static/src/buttons/selectAll.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ function handleSelectAllToggle(event: Event): void {
3636

3737
if (table !== null) {
3838
for (const element of table.querySelectorAll<HTMLInputElement>(
39-
'input[type="checkbox"][name="pk"]',
39+
'tr:not(.d-none) input[type="checkbox"][name="pk"]',
4040
)) {
4141
if (tableSelectAll.checked) {
4242
// Check all PK checkboxes if the select all checkbox is checked.

0 commit comments

Comments
 (0)