assistance: customvalidator - ipam.ipaddress - require device/interface assignment

[davama]

Hello,

Running:

  "netbox-version": "3.2.4",
  "python-version": "3.9.6",

Im trying to get a customvalidator for ipam.ipaddress objects:

CUSTOM_VALIDATORS = {
    'ipam.ipaddress': [
        {
            'dns_name': {
                'required': True,
            }
            'dcim.interfaces': {
                'required': True,
            }
        }
    ]
}

The above does not work.
it only works with the dns_name key but not with the interface one...
What am i doing wrong?

Any input is appreciated!

Thank you,
Dave

[AFreiholtz]

Hi,

I have a similar problem with custom validations. dcim.device is working below, but virtualization.virtualmachine is not.

CUSTOM_VALIDATORS = {
    "virtualization.virtualmachine": [
        {
            "platform": {
                "required": True,
            }
        }
    ],
    "dcim.device": [
        {
            "platform": {
                "required": True,
            }
        }
    ]
}

[AFreiholtz]

Hmm and suddenly the above code is working... I must have done something weird the first 10 times...

[davama]

@AFreiholtz

Appreciate the input…ill retry and zoom in (face on monitor)

hopefully something comes up

[ben-marquardt-tfs]

I suspect it might be because interfaces are not an attribute of the ip-address object but dns_name is. The following is what you get from a GET request to the ip address endpoint

'{
"id": 3,
"url": "http://localhost:8000/api/ipam/ip-addresses/3/",
"display": ,
"family": {
"value": 4,
"label": "IPv4"
},
"address": ,
"vrf": null,
"tenant": null,
"status": {
"value": "active",
"label": "Active"
},
"role": null,
"assigned_object_type": null,
"assigned_object_id": null,
"assigned_object": null,
"nat_inside": null,
"nat_outside": null,
"dns_name": "asdf",
"description": "",
"tags": [],
"custom_fields": {},
"created": "2022-06-07T20:20:32.509068Z",
"last_updated": "2022-06-08T16:11:50.283136Z"
},'

I could totally be wrong but that is my hunch. I am not sure what workarounds there are if what I suspect is correct.

[davama]

@ben-marquardt-tfs
looks like you might be right

I get this error:

2022-06-09 12:39:23,895 netbox.config DEBUG: No previous configuration found in database; proceeding with default values
2022-06-09 12:39:23,895 netbox.config DEBUG: Initialized configuration
2022-06-09 12:39:23,897 django.request ERROR: Internal Server Error: /ipam/ip-addresses/add/
Traceback (most recent call last):
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/views/generic/base.py", line 84, in view
    return self.dispatch(request, *args, **kwargs)
  File "/opt/netbox/netbox/netbox/views/generic/object_views.py", line 298, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/opt/netbox/netbox/utilities/views.py", line 90, in dispatch
    return super().dispatch(request, *args, **kwargs)
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/views/generic/base.py", line 119, in dispatch
    return handler(request, *args, **kwargs)
  File "/opt/netbox/netbox/netbox/views/generic/object_views.py", line 371, in post
    if form.is_valid():
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/forms/forms.py", line 205, in is_valid
    return self.is_bound and not self.errors
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/forms/forms.py", line 200, in errors
    self.full_clean()
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/forms/forms.py", line 435, in full_clean
    self._post_clean()
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/forms/models.py", line 492, in _post_clean
    self.instance.full_clean(exclude=exclude, validate_unique=False)
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/db/models/base.py", line 1390, in full_clean
    self.clean()
  File "/opt/netbox/netbox/ipam/models/ip.py", line 861, in clean
    super().clean()
  File "/opt/netbox/netbox/netbox/models/features.py", line 121, in clean
    super().clean()
  File "/opt/netbox/netbox/netbox/models/features.py", line 162, in clean
    post_clean.send(sender=self.__class__, instance=self)
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/dispatch/dispatcher.py", line 176, in send
    return [
  File "/opt/netbox/venv/lib64/python3.9/site-packages/django/dispatch/dispatcher.py", line 177, in <listcomp>
    (receiver, receiver(signal=self, sender=sender, **named))
  File "/opt/netbox/netbox/extras/signals.py", line 184, in run_custom_validators
    validator(instance)
  File "/opt/netbox/netbox/extras/validators.py", line 69, in __call__
    assert hasattr(instance, attr_name), f"Invalid attribute '{attr_name}' for {instance.__class__.__name__}"
AssertionError: Invalid attribute 'dcim.interfaces' for IPAddress
2022-06-09 12:39:23,901 netbox.config DEBUG: Cleared configuration

@AFreiholtz

Just realized that your validator is actually two validators for two separate objects. So you are not doing what I am doing. Im trying to establish two conditions for one object.

Looks like I may have to look into this approach: https://docs.netbox.dev/en/stable/customization/custom-validation/#custom-validation-logic