Skip to content

Commit f6b1676

Browse files
leoparenteleoparente
authored
chore: cleanup pktvisor pipeline (#729)
1 parent e166ab7 commit f6b1676

File tree

4 files changed

+38
-46
lines changed

4 files changed

+38
-46
lines changed

‎.github/workflows/build-develop.yml‎

Lines changed: 20 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040

4141
- name: Get Conan
4242
id: conan
43-
uses: turtlebrowser/get-conan@main
43+
uses: turtlebrowser/get-conan@c171f295f3f507360ee018736a6608731aa2109d #v1.2
4444
with:
4545
version: 1.66.0
4646

@@ -96,10 +96,8 @@ jobs:
9696
run: cmake -E make_directory ${{github.workspace}}/build
9797

9898
- name: Get Conan
99-
# You may pin to the exact commit or the version.
100-
# uses: turtlebrowser/get-conan@4dc7e6dd45c8b1e02e909979d7cfc5ebba6ddbe2
10199
id: conan
102-
uses: turtlebrowser/get-conan@main
100+
uses: turtlebrowser/get-conan@c171f295f3f507360ee018736a6608731aa2109d #v1.2
103101
with:
104102
version: 1.66.0
105103

@@ -163,10 +161,8 @@ jobs:
163161
run: cmake -E make_directory ${{github.workspace}}\build
164162

165163
- name: Get Conan
166-
# You may pin to the exact commit or the version.
167-
# uses: turtlebrowser/get-conan@4dc7e6dd45c8b1e02e909979d7cfc5ebba6ddbe2
168164
id: conan
169-
uses: turtlebrowser/get-conan@main
165+
uses: turtlebrowser/get-conan@c171f295f3f507360ee018736a6608731aa2109d #v1.2
170166
with:
171167
version: 1.66.0
172168

@@ -326,14 +322,14 @@ jobs:
326322
run: echo ${{ env.REF_TAG }}
327323

328324
- name: Login to GitHub Container Registry
329-
uses: docker/login-action@v3
325+
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 #v3.3.0
330326
with:
331327
registry: ghcr.io
332328
username: ${{ github.repository_owner }}
333329
password: ${{ secrets.GITHUB_TOKEN }}
334330

335331
- name: Login to Docker Hub
336-
uses: docker/login-action@v3
332+
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 #v3.3.0
337333
with:
338334
username: ${{ secrets.ORB_DOCKERHUB_USERNAME }}
339335
password: ${{ secrets.ORB_DOCKERHUB_TOKEN }}
@@ -349,17 +345,17 @@ jobs:
349345
sed -i -e "s/CP_URL/$ESCAPED_REPLACE/g" docker/run.sh
350346
351347
- name: Set up QEMU
352-
uses: docker/setup-qemu-action@v2
348+
uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf #v3.2.0
353349

354350
- name: Set up Docker Buildx
355351
id: buildx
356-
uses: docker/setup-buildx-action@v2
352+
uses: docker/setup-buildx-action@6524bf65af31da8d45b59e8c27de4bd072b392f5 #v3.8.0
357353

358354
- name: Build + push - pktvisor (multi-arch)
359355
env:
360356
IMAGE_NAME1: orbcommunity/pktvisor
361357
IMAGE_NAME2: ghcr.io/orb-community/pktvisor
362-
uses: docker/build-push-action@v3
358+
uses: docker/build-push-action@48aba3b46d1b1fec4febb7c5d0c644b249a11355 #v6.10.0
363359
with:
364360
builder: ${{ steps.buildx.outputs.name }}
365361
context: .
@@ -391,7 +387,7 @@ jobs:
391387

392388
- name: Get Conan
393389
id: conan
394-
uses: turtlebrowser/get-conan@main
390+
uses: turtlebrowser/get-conan@c171f295f3f507360ee018736a6608731aa2109d #v1.2
395391
with:
396392
version: 1.66.0
397393

@@ -441,7 +437,7 @@ jobs:
441437
path: ${{github.workspace}}/${{ env.BINARY_NAME }}
442438

443439
- name: Login to Docker Hub
444-
uses: docker/login-action@v3
440+
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 #v3.3.0
445441
with:
446442
username: ${{ secrets.ORB_DOCKERHUB_USERNAME }}
447443
password: ${{ secrets.ORB_DOCKERHUB_TOKEN }}
@@ -470,7 +466,7 @@ jobs:
470466

471467
package-arm64:
472468
needs: [ unit-tests-linux ]
473-
runs-on: [ linux, ARM64]
469+
runs-on: ubuntu-latest
474470
if: github.event_name != 'pull_request'
475471
steps:
476472
- name: cleanup #https://github.com/actions/checkout/issues/211
@@ -519,18 +515,18 @@ jobs:
519515
echo "DRAFT=true" >> $GITHUB_ENV
520516
521517
- name: Login to GitHub Container Registry
522-
uses: docker/login-action@v3
518+
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 #v3.3.0
523519
with:
524520
registry: ghcr.io
525521
username: ${{ github.repository_owner }}
526522
password: ${{ secrets.GITHUB_TOKEN }}
527523

528524
- name: Set up QEMU
529-
uses: docker/setup-qemu-action@v2
525+
uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf #v3.2.0
530526

531527
- name: Set up Docker Buildx
532528
id: buildx
533-
uses: docker/setup-buildx-action@v2
529+
uses: docker/setup-buildx-action@6524bf65af31da8d45b59e8c27de4bd072b392f5 #v3.8.0
534530

535531
- name: Replace token
536532
run: |
@@ -546,7 +542,7 @@ jobs:
546542
id: docker_build
547543
env:
548544
IMAGE_NAME: ghcr.io/orb-community/pktvisor
549-
uses: docker/build-push-action@v3
545+
uses: docker/build-push-action@48aba3b46d1b1fec4febb7c5d0c644b249a11355 #v6.10.0
550546
with:
551547
builder: ${{ steps.buildx.outputs.name }}
552548
context: .
@@ -564,12 +560,12 @@ jobs:
564560
docker push ${{ env.IMAGE_NAME }}:arm64-${{needs.unit-tests-linux.outputs.commit_hash}}
565561
566562
pushing-manifests:
567-
needs: [ unit-tests-linux ]
563+
needs: [ unit-tests-linux, package-amd64, package-arm64 ]
568564
runs-on: ubuntu-latest
569565
if: github.event_name != 'pull_request'
570566
steps:
571567
- name: Login to GitHub Container Registry
572-
uses: docker/login-action@v3
568+
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 #v3.3.0
573569
with:
574570
registry: ghcr.io
575571
username: ${{ github.repository_owner }}
@@ -615,23 +611,23 @@ jobs:
615611
616612
617613
- name: Delete arm64 images from ghcr.io
618-
uses: bots-house/ghcr-delete-image-action@v1.0.0
614+
uses: bots-house/ghcr-delete-image-action@3827559c68cb4dcdf54d813ea9853be6d468d3a4 #v1.1.0
619615
with:
620616
owner: orb-community
621617
name: pktvisor
622618
token: ${{ secrets.GITHUB_TOKEN }}
623619
tag: arm64-${{needs.unit-tests-linux.outputs.commit_hash}}
624620

625621
- name: Delete amd64 images from ghcr.io
626-
uses: bots-house/ghcr-delete-image-action@v1.0.0
622+
uses: bots-house/ghcr-delete-image-action@3827559c68cb4dcdf54d813ea9853be6d468d3a4 #v1.1.0
627623
with:
628624
owner: orb-community
629625
name: pktvisor
630626
token: ${{ secrets.GITHUB_TOKEN }}
631627
tag: amd64-${{needs.unit-tests-linux.outputs.commit_hash}}
632628

633629
- name: Delete latest-develop images from ghcr.io
634-
uses: bots-house/ghcr-delete-image-action@v1.0.0
630+
uses: bots-house/ghcr-delete-image-action@3827559c68cb4dcdf54d813ea9853be6d468d3a4 #v1.1.0
635631
with:
636632
owner: orb-community
637633
name: pktvisor

‎.github/workflows/build-release.yml‎

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jobs:
3030

3131
- name: Get Conan
3232
id: conan
33-
uses: turtlebrowser/get-conan@main
33+
uses: turtlebrowser/get-conan@c171f295f3f507360ee018736a6608731aa2109d #v1.2
3434
with:
3535
version: 1.66.0
3636

@@ -82,7 +82,7 @@ jobs:
8282

8383
- name: Get Conan
8484
id: conan
85-
uses: turtlebrowser/get-conan@main
85+
uses: turtlebrowser/get-conan@c171f295f3f507360ee018736a6608731aa2109d #v1.2
8686
with:
8787
version: 1.66.0
8888

@@ -132,7 +132,7 @@ jobs:
132132

133133
- name: Get Conan
134134
id: conan
135-
uses: turtlebrowser/get-conan@main
135+
uses: turtlebrowser/get-conan@c171f295f3f507360ee018736a6608731aa2109d #v1.2
136136
with:
137137
version: 1.66.0
138138

@@ -188,10 +188,8 @@ jobs:
188188
run: cmake -E make_directory ${{github.workspace}}\build
189189

190190
- name: Get Conan
191-
# You may pin to the exact commit or the version.
192-
# uses: turtlebrowser/get-conan@4dc7e6dd45c8b1e02e909979d7cfc5ebba6ddbe2
193191
id: conan
194-
uses: turtlebrowser/get-conan@main
192+
uses: turtlebrowser/get-conan@c171f295f3f507360ee018736a6608731aa2109d #v1.2
195193
with:
196194
version: 1.66.0
197195

@@ -299,7 +297,7 @@ jobs:
299297
300298
package-arm64:
301299
needs: [ prebuild-package ]
302-
runs-on: ${{ needs.spinup-arm64-runner.outputs.runner_label }}
300+
runs-on: ubuntu-latest
303301
if: github.event_name != 'pull_request'
304302
steps:
305303
- name: Attach to workspace
@@ -372,18 +370,18 @@ jobs:
372370
run: echo ${{ env.REF_TAG }}
373371

374372
- name: Login to GitHub Container Registry
375-
uses: docker/login-action@v3
373+
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 #v3.3.0
376374
with:
377375
registry: ghcr.io
378376
username: ${{ github.repository_owner }}
379377
password: ${{ secrets.GITHUB_TOKEN }}
380378

381379
- name: Set up QEMU
382-
uses: docker/setup-qemu-action@v2
380+
uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf #v3.2.0
383381

384382
- name: Set up Docker Buildx
385383
id: buildx
386-
uses: docker/setup-buildx-action@v2
384+
uses: docker/setup-buildx-action@6524bf65af31da8d45b59e8c27de4bd072b392f5 #v3.8.0
387385

388386
- name: Replace token
389387
run: |
@@ -399,7 +397,7 @@ jobs:
399397
id: docker_build
400398
env:
401399
IMAGE_NAME: ghcr.io/orb-community/pktvisor
402-
uses: docker/build-push-action@v3
400+
uses: docker/build-push-action@48aba3b46d1b1fec4febb7c5d0c644b249a11355 #v6.10.0
403401
with:
404402
builder: ${{ steps.buildx.outputs.name }}
405403
context: .
@@ -493,18 +491,18 @@ jobs:
493491
run: echo ${{ env.REF_TAG }}
494492

495493
- name: Login to GitHub Container Registry
496-
uses: docker/login-action@v3
494+
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 #v3.3.0
497495
with:
498496
registry: ghcr.io
499497
username: ${{ github.repository_owner }}
500498
password: ${{ secrets.GITHUB_TOKEN }}
501499

502500
- name: Set up Docker Buildx
503501
id: buildx
504-
uses: docker/setup-buildx-action@v2
502+
uses: docker/setup-buildx-action@6524bf65af31da8d45b59e8c27de4bd072b392f5 #v3.8.0
505503

506504
- name: Set up QEMU
507-
uses: docker/setup-qemu-action@v2
505+
uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf #v3.2.0
508506

509507
- name: Replace token
510508
run: |
@@ -519,7 +517,7 @@ jobs:
519517
- name: Build + push - pktvisor (multi-arch)
520518
env:
521519
IMAGE_NAME: ghcr.io/orb-community/pktvisor
522-
uses: docker/build-push-action@v3
520+
uses: docker/build-push-action@48aba3b46d1b1fec4febb7c5d0c644b249a11355 #v6.10.0
523521
with:
524522
builder: ${{ steps.buildx.outputs.name }}
525523
context: .
@@ -543,7 +541,7 @@ jobs:
543541
if: github.event_name != 'pull_request'
544542
steps:
545543
- name: Login to GitHub Container Registry
546-
uses: docker/login-action@v3
544+
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 #v3.3.0
547545
with:
548546
registry: ghcr.io
549547
username: ${{ github.repository_owner }}

‎.github/workflows/build_debug.yml‎

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,8 @@ jobs:
2828
run: cmake -E make_directory ${{github.workspace}}/build
2929

3030
- name: Get Conan
31-
# You may pin to the exact commit or the version.
32-
# uses: turtlebrowser/get-conan@4dc7e6dd45c8b1e02e909979d7cfc5ebba6ddbe2
3331
id: conan
34-
uses: turtlebrowser/get-conan@main
32+
uses: turtlebrowser/get-conan@c171f295f3f507360ee018736a6608731aa2109d #v1.2
3533
with:
3634
version: 1.66.0
3735

@@ -79,7 +77,7 @@ jobs:
7977
- name: Build Coverage
8078
working-directory: ${{github.workspace}}/build
8179
shell: bash
82-
run: cmake --build . --target coverage -- -j 2
80+
run: sudo cmake --build . --target coverage -- -j 2
8381

8482
- name: Codecov
8583
uses: codecov/codecov-action@v3
@@ -183,7 +181,7 @@ jobs:
183181
sed -i -e "s/CP_URL/$ESCAPED_REPLACE/g" docker/run.sh
184182
185183
- name: Login to Docker Hub
186-
uses: docker/login-action@v3
184+
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 #v3.3.0
187185
with:
188186
username: ${{ secrets.DOCKERHUB_USERNAME }}
189187
password: ${{ secrets.DOCKERHUB_TOKEN }}

‎.github/workflows/code-ql.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ jobs:
102102
# configure and handle dependencies
103103
cmake -DCMAKE_BUILD_TYPE=Release ..
104104
# build and run tests
105-
make all test
105+
sudo make all test
106106
#remove conan files
107107
rm -rf conan_home/
108108

0 commit comments

Comments
 (0)