Skip to content
This repository was archived by the owner on Apr 19, 2024. It is now read-only.

Commit f46bf39

Browse files
authored
Merge pull request #341 from netdata/fix-heading-and-description-styles
Fix heading and description styles
2 parents ba1512b + 91b43c2 commit f46bf39

File tree

5 files changed

+63
-54
lines changed

5 files changed

+63
-54
lines changed

package-lock.json

Lines changed: 48 additions & 41 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@netdata/dashboard",
3-
"version": "2.20.12",
3+
"version": "2.20.14",
44
"homepage": ".",
55
"main": "./lib/src/index-npm.js",
66
"files": [
@@ -18,7 +18,7 @@
1818
"@material/list": "^4.0.0",
1919
"@material/menu": "^2.3.0",
2020
"@material/menu-surface": "^1.0.0",
21-
"@netdata/netdata-ui": "^1.6.33",
21+
"@netdata/netdata-ui": "^1.7.18",
2222
"@rmwc/icon": "^5.7.2",
2323
"@rmwc/list": "^5.7.2",
2424
"@rmwc/menu": "^5.7.2",
@@ -119,6 +119,8 @@
119119
"clean": "./node_modules/rimraf/bin.js ./lib",
120120
"remove-unnecessary-dts": "rimraf ./lib/dashboard-react.d.ts",
121121
"ts-bundle": "npm run clean && tsc --noEmit false && node copy-assets && npm run remove-unnecessary-dts && npm run resolveAlias",
122+
"cp-cloud": "cp -R ./lib ../cloud-frontend/node_modules/@netdata/dashboard/",
123+
"to-cloud": "npm run ts-bundle && npm run cp-cloud",
122124
"eject": "react-scripts eject",
123125
"prepare": "install-peers && npm run ts-bundle",
124126
"resolveAlias": "tscpaths -p tsconfig.json -s ./src -o ./lib/src"

src/domains/charts/chartMenuGroup/title.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import React from "react"
2-
import { H0, Flex } from "@netdata/netdata-ui"
2+
import { H0 } from "@netdata/netdata-ui"
33
import { withMenuGroup } from "domains/charts/menuGroup"
44

55
export const ChartMenuGroupIcon = ({ icon, ...rest }) => (
66
<span dangerouslySetInnerHTML={{ __html: icon }} {...rest} />
77
)
88

9-
export const ChartMenuGroupTitle = ({ icon, title, ...rest }) => (
10-
<Flex as={H0} color="key" gap={2} {...rest}>
11-
<ChartMenuGroupIcon icon={icon} />
12-
<span>{title}</span>
13-
</Flex>
14-
)
9+
export const ChartMenuGroupTitle = ({ title, ...rest }) =>
10+
title ? (
11+
<H0 color="text" {...rest}>
12+
{title}
13+
</H0>
14+
) : null
1515

1616
export const ChartMenuGroupTitleContainer = withMenuGroup(
1717
ChartMenuGroupTitle,
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import React from "react"
2-
import { H1 } from "@netdata/netdata-ui"
2+
import { H3 } from "@netdata/netdata-ui"
33
import { withSubMenu } from "domains/charts/subMenu"
44

55
export const ChartSubMenuTitle = ({ title, ...rest }) =>
66
title ? (
7-
<H1 color="key" {...rest}>
7+
<H3 color="text" {...rest}>
88
{title}
9-
</H1>
9+
</H3>
1010
) : null
1111

1212
export const ChartSubMenuTitleContainer = withSubMenu(ChartSubMenuTitle, ({ title }) => ({ title }))

src/domains/charts/description/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const Description = ({ children, onClick, ...rest }) => {
2020
)
2121

2222
return children ? (
23-
<Text color="border" dangerouslySetInnerHTML={{ __html: children }} onClick={click} {...rest} />
23+
<Text color="textDescription" dangerouslySetInnerHTML={{ __html: children }} onClick={click} {...rest} />
2424
) : null
2525
}
2626

0 commit comments

Comments
 (0)