Ensure consistent hostname setting

During the initial node discovery, we retrieve the hostname for a device
and use that. However, on initializing the SSH for the first time, we
also reinit the hostname, and sometimes from a different command than
whats present in the initial node discovery phase. The hostname needs to
be whatever is advertised in LLDP because that is how we find peers of
an interface and is essential for many tasks that we do.

This diff in hostname computed during node discovery from the one in
polling can cause us to recreate incorrect hostnames. This patch ensures
that we only ever use the hostname computed during ssh setup after node
discovery.

Signed-off-by: Dinesh Dutt <[email protected]>

Author: ddutt

suzieq/poller/worker/nodes/node.py

@@ -409,7 +409,11 @@ async def _parse_device_type_hostname(self, output, _) -> None:
                 f'Detected {devtype} for {self.address}:{self.port},'
                 f' {hostname}')
             self._set_devtype(devtype, version_str)
-            self._set_hostname(hostname)
+            # We don't set the hostname here because the real hostname
+            # is retrieved via a different command on some platforms
+            # and can contain the FQDN. The hostname stored with a
+            # record needs to be one that is also used in LLDP so that we
+            # can find interface peers
             self.current_exception = None
 
     async def _detect_node_type(self):