Whole bunch of pylint/flake8 fixes due to updated pylint

Signed-off-by: Dinesh Dutt <[email protected]>

Author: ddutt

suzieq/engines/pandas/engineobj.py

@@ -587,7 +587,7 @@ def _post_summarize(self, check_empty_col: str = 'deviceCnt') -> None:
             if self.ns[ns][check_empty_col] == 0:
                 delete_keys.append(ns)
         for ns in delete_keys:
-            del(self.ns[ns])
+            del (self.ns[ns])
 
         ns_df = pd.DataFrame(self.ns)
         if len(self.summary_row_order) > 0:

suzieq/engines/rest/engineobj.py

@@ -104,7 +104,8 @@ def _get_response(self, verb: str, **kwargs) -> pd.DataFrame:
             f'{verb}?'
             f'{query_params}')
 
-        response = requests.get(url, verify=False, )
+        # pylint: disable=missing-timeout
+        response = requests.get(url, verify=None)
         if response.status_code != 200:
             if response.text:
                 msg = response.json().get("detail", str(response.status_code))

suzieq/gui/stlit/guiutils.py

@@ -128,7 +128,7 @@ def get_session_id():
     '''Return Streamlit's session ID'''
     ctx = get_script_run_ctx()
     if ctx is None:
-        raise Exception("Failed to get the thread context")
+        raise AttributeError("Failed to get the thread context")
     return ctx.session_id
 
 
@@ -166,8 +166,8 @@ def set_def_aggrid_options(grid_options: dict):
 
 def get_image_dir():
     '''Get directory where images are stored'''
-    return(os.path.dirname(find_spec('suzieq.gui')
-                           .loader.path) + '/images')
+    return (os.path.dirname(find_spec('suzieq.gui')
+                            .loader.path) + '/images')
 
 
 def color_row(row, **kwargs):

suzieq/gui/stlit/path.py

@@ -452,7 +452,7 @@ def _get_node_tooltip_color(self, hostname: str) -> str:
             color = 'red'
         else:
             color = 'black'
-        return('\n'.join(tdf.T.to_string().split('\n')[1:]), color)
+        return ('\n'.join(tdf.T.to_string().split('\n')[1:]), color)
 
     def _aggrid_style(self):
         '''Style the cells based on value'''

suzieq/poller/worker/services/service.py

@@ -519,7 +519,7 @@ def merge_results(self, result_list, _):
 
         final_res = list(int_res.values())
 
-        return(final_res)
+        return (final_res)
 
     def _get_devtype_from_input(self, input_data):
         if isinstance(input_data, list):

suzieq/poller/worker/services/svcparser.py

@@ -196,8 +196,8 @@ def cons_recs_from_json_template(tmplt_str, in_data):
                         # Some outputs contain just the main key with a null
                         # body such as ospfNbr from EOS: {'vrfs': {}}.
                         logging.info(
-                            f"Unnatural return from svcparser. xstr is {xstr}. \
-                            Result is {result}")
+                            f"Unnatural return from svcparser. xstr is {xstr}.\
+                             Result is {result}")
                         return cleanup_and_return(result)
                     result = [{"rest": data[xstr]}]
                 else:

suzieq/restServer/query.py

@@ -284,7 +284,7 @@ class TruthasStrings(str, Enum):
 
 @app.get("/api/v1/{rest_of_path:path}", deprecated=True)
 def deprecated_function(request: Request, rest_of_path: str):
-    return([{'error': 'v1 is deprecated, use API version v2'}])
+    return ([{'error': 'v1 is deprecated, use API version v2'}])
 
 
 @app.get("/api/v2/address/{verb}")

suzieq/shared/schema.py

@@ -29,7 +29,7 @@ def _init_schemas(self, schema_dir: str):
         if not (schema_dir and os.path.exists(schema_dir)):
             logger.error(
                 "Schema directory %s does not exist", schema_dir)
-            raise Exception(f"Schema directory {schema_dir} does not exist")
+            raise ValueError(f"Schema directory {schema_dir} does not exist")
 
         for root, _, files in os.walk(schema_dir):
             for topic in files:

suzieq/shared/utils.py

@@ -879,9 +879,9 @@ def init_logger(logname: str,
 
 def known_devtypes() -> list:
     """Returns the list of known dev types"""
-    return(['cumulus', 'eos', 'iosxe', 'iosxr', 'ios', 'junos-mx', 'junos-qfx',
-            'junos-qfx10k', 'junos-ex', 'junos-es', 'junos-evo', 'linux',
-            'nxos', 'sonic', 'panos'])
+    return (['cumulus', 'eos', 'iosxe', 'iosxr', 'ios', 'junos-mx',
+             'junos-qfx', 'junos-qfx10k', 'junos-ex', 'junos-es', 'junos-evo',
+             'linux', 'nxos', 'sonic', 'panos'])
 
 
 def humanize_timestamp(field: pd.Series, tz=None) -> pd.Series:
@@ -1108,6 +1108,7 @@ def deprecated_command_warning(dep_command: str, dep_sub_command: str,
         sub_command (str, optional): subcommand to use instead.
         Defaults to None.
 
+
     Returns:
         str: deprecated command warning message
     """
@@ -1122,7 +1123,7 @@ def get_default_per_vals() -> Dict:
     Returns:
         Dict: mapping between type and default value
     """
-    return({
+    return ({
         pa.string(): "",
         pa.int32(): 0,
         pa.int64(): 0,