Interface parser fixes (#839)

* Interfaces Parser: IOS parser fixes

Signed-off-by: Dinesh Dutt <[email protected]>

* NXOS interface parser: link flap was not recorded

Signed-off-by: Dinesh Dutt <[email protected]>

Signed-off-by: Dinesh Dutt <[email protected]>

Author: ddutt

suzieq/config/interfaces.yml

@@ -210,7 +210,7 @@ apply:
           "linklocal-addr: _linklocal"
           ]'
 
-        - command: show interface | egrep '^\w|Hardware|MTU|reset|Description'
+        - command: show interface | egrep '^\w|Hardware|MTU|reset|Description|flapped'
           textfsm: textfsm_templates/nxos_show_int_grep.tfsm
           _entryType: mtumac
 

suzieq/poller/worker/services/interfaces.py

@@ -877,8 +877,12 @@ def _clean_iosxr_data(self, processed_data, raw_data):
                                            'type': 'bond_slave'}
 
             if entry['adminState'] == 'administratively down':
-                entry['state'] = 'down'
                 entry['adminState'] = 'down'
+            else:
+                # IOS reports the admin state as down when the oper state
+                # (line protocol) is down. administratively down is what
+                # is administratively down.
+                entry['adminState'] = 'up'
 
             entry['macaddr'] = convert_macaddr_format_to_colon(
                 entry.get('macaddr', '0000.0000.0000'))