pylint-0.14 fixes

Signed-off-by: Dinesh Dutt <[email protected]>

Author: ddutt

suzieq/cli/nubia_patch.py

@@ -18,7 +18,7 @@
 Command = namedtuple("Command", "name help aliases exclusive_arguments")
 
 FunctionInspection = namedtuple(
-    "FunctionInspection", "arguments " "command subcommands"
+    "FunctionInspection", "arguments command subcommands"
 )
 _ArgDecoratorSpec = namedtuple(
     "_ArgDecoratorSpec", "arg name aliases description positional choices"
@@ -87,7 +87,7 @@ def decorator(function):
         # reject positional=True if we are applied over a class
         if isclass(function) and positional:
             raise ValueError(
-                "Cannot set positional arguments for super " "commands"
+                "Cannot set positional arguments for super commands"
             )
 
         # We use __annotations__ to allow the usage of python 3 typing

suzieq/engines/pandas/path.py

@@ -741,7 +741,7 @@ def get(self, **kwargs) -> pd.DataFrame:
 
         if not self.ctxt.engine:
             raise AttributeError(
-                "Specify an analysis engine using set engine " "command"
+                "Specify an analysis engine using 'set engine' command"
             )
 
         namespaces = kwargs.get("namespace", self.ctxt.namespace)

suzieq/poller/worker/services/bgp.py

@@ -88,7 +88,7 @@ def _clean_eos_data(self, processed_data, raw_data):
                     new_entry['pfxBestRx'] = entry['pfxBestRx'][i]
 
                 new_entry['defOriginate'] = False
-                if 'safi' == 'evpn':
+                if entry['safi'][i] == 'evpn':
                     if ('Sending extended community not configured' in
                             entry.get('errorMsg', '')):
                         new_entry['communityTypes'] = []

suzieq/poller/worker/services/service.py

@@ -790,7 +790,7 @@ async def run(self):
                                              for x in ostatus])
                 status = ostatus[0]
                 if (status in [0, 200]):
-                    rxBytes = len(output.__str__())
+                    rxBytes = len(str(output))
 
                 # We don't expect the output from two different hostnames
                 nodename = output[0]["hostname"]

suzieq/restServer/query.py

@@ -1,3 +1,6 @@
+# pylint: disable=unused-argument,missing-function-docstring
+# pylint: disable=redefined-outer-name, unused-variable
+# pylint: disable=redefined-builtin, missing-class-docstring,
 import argparse
 import inspect
 import logging
@@ -40,6 +43,8 @@ def check_config_file():
 
 def app_init(cfg_file):
     '''This is the actual API initilaizer'''
+    # pylint: disable=global-variable-not-assigned
+
     global app
 
     app.cfg_file = cfg_file
@@ -161,7 +166,7 @@ def rest_main(*args) -> None:
         _ = cfg['rest']['API_KEY']
     except KeyError:
         print('missing API_KEY in config file')
-        exit(1)
+        sys.exit(1)
 
     logcfg, loglevel = get_log_config_level(cfg)
 
@@ -180,14 +185,6 @@ def rest_main(*args) -> None:
                     ssl_certfile=ssl_certfile)
 
 
-"""
-each of these read functions behaves the same, it gets the arguments
-puts them into dicts and passes them to sqobjects
-
-assume that all API functions are named read_*
-"""
-
-
 class CommonVerbs(str, Enum):
     show = "show"
     summarize = "summarize"
@@ -894,7 +891,7 @@ def get_svc(command):
 
 
 def run_command_verb(command, verb, command_args, verb_args,
-                     columns=['default'], format=None):
+                     columns=None, format=None):
     """
     Runs the command and verb with the command_args and verb_args
 
@@ -904,6 +901,10 @@ def run_command_verb(command, verb, command_args, verb_args,
         422 -- FastAPI validation errors
         500 -- Exceptions
     """
+
+    if columns is None:
+        columns = ['default']
+
     svc = get_svc(command)
     try:
         svc_inst = svc(**command_args,

suzieq/shared/utils.py

@@ -712,7 +712,7 @@ def init_logger(logname: str,
         sh = logging.StreamHandler(sys.stdout)
 
     formatter = logging.Formatter(
-        "%(asctime)s - %(name)s - %(levelname)s " "- %(message)s"
+        "%(asctime)s - %(name)s - %(levelname)s - %(message)s"
     )
     if fh:
         fh.setFormatter(formatter)