Manual fixes by shellcheck

Author: cscarpitta

nets/8r-1c-srv6-pm/nodeconf/common/ebpf_helper.sh

@@ -138,17 +138,17 @@ function prepare_netdev()
 	#
 	# NOTE: goto does not exist... so we need to get something similar with
 	# if (true) {  if(..) break; }
-	if [ 1 ]; then
+	if true; then
 		ip link add name "${ifname_br}" type bridge \
-			|| { res=$?; break; }
+			|| { res=$?; return; }
 		ip link set dev "${ifname_egr}" master "${ifname_br}" \
-			|| { res=$?; break; }
+			|| { res=$?; return; }
 		ip link set dev "${ifname}" master "${ifname_br}" \
-			|| { res=$?; break; }
+			|| { res=$?; return; }
 
-		ip link set dev "${ifname_br}" up || { res=$?; break; }
-		ip link set dev "${ifname_igr}" up || { res=$?; break; }
-		ip link set dev "${ifname_egr}" up || { res=$?; break; }
+		ip link set dev "${ifname_br}" up || { res=$?; return; }
+		ip link set dev "${ifname_igr}" up || { res=$?; return; }
+		ip link set dev "${ifname_egr}" up || { res=$?; return; }
 	fi
 
 	if [ $res -ne 0 ]; then

nets/8routers/nodeconf/r1-example-ospfv3/start.sh

@@ -12,7 +12,7 @@ FRR_PATH=/usr/lib/frr
 #sysctl -w net.ipv4.conf.default.rp_filter=0
 #the following for loop also disables all and default
 #for i in /proc/sys/net/ipv4/conf/*/rp_filter ; do
-  echo 0 > "$i" 
+#  echo 0 > "$i" 
 #done