Skip to content
This repository was archived by the owner on May 4, 2019. It is now read-only.

Commit 22be42b

Browse files
committed
Fix metadata length calculation
1 parent 0d638fa commit 22be42b

File tree

5 files changed

+9
-11
lines changed

5 files changed

+9
-11
lines changed

core/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@ dependencies {
22
compile project (':frames')
33
compile 'io.rsocket:rsocket-core:0.10.1'
44
compile 'io.rsocket:rsocket-transport-netty:0.10.1'
5-
compile 'io.micrometer:micrometer-core:1.0.0-rc.5'
5+
compile 'io.micrometer:micrometer-core:1.0.0-rc.6'
66
}

frames/build.gradle

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
sourceCompatibility = 1.6
2-
targetCompatibility = 1.6
3-
41
dependencies {
52
compile 'io.netty:netty-buffer:4.1.17.Final'
63
}

frames/src/main/java/io/netifi/proteus/frames/ProteusMetadata.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,13 @@ public class ProteusMetadata {
99
private static final int METHOD_ID_SIZE = 4;
1010
private static final int METADATA_LENGTH_SIZE = 4;
1111

12-
public static int computeLength() {
12+
public static int computeLength(ByteBuf metadata) {
1313
return VERSION_SIZE
1414
+ NAMESPACE_ID_SIZE
1515
+ SERVICE_ID_SIZE
1616
+ METHOD_ID_SIZE
17-
+ METADATA_LENGTH_SIZE;
17+
+ METADATA_LENGTH_SIZE
18+
+ metadata.readableBytes();
1819
}
1920

2021
public static int encode(
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
package io.netifi.sdk.frames;
1+
package io.netifi.proteus.frames;
22

33
public class RoutingFlyweightTest {}

protobuf-rpc/src/java_plugin/cpp/java_generator.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ static void PrintClient(const ServiceDescriptor* service,
589589
p->Indent();
590590
p->Print(
591591
*vars,
592-
"final int length = $ProteusMetadata$.computeLength();\n"
592+
"final int length = $ProteusMetadata$.computeLength(metadata);\n"
593593
"final $ByteBuf$ metadataBuf = $ByteBufAllocator$.DEFAULT.directBuffer(length);\n"
594594
"$ProteusMetadata$.encode(metadataBuf, $service_name$.$namespace_id_name$, $service_name$.$service_id_name$, $service_name$.$method_id_name$, metadata);\n"
595595
"return $ByteBufPayload$.create(data, metadataBuf);\n");
@@ -635,7 +635,7 @@ static void PrintClient(const ServiceDescriptor* service,
635635
p->Indent();
636636
p->Print(
637637
*vars,
638-
"final int length = $ProteusMetadata$.computeLength();\n"
638+
"final int length = $ProteusMetadata$.computeLength(metadata);\n"
639639
"$ByteBuf$ metadataBuf = $ByteBufAllocator$.DEFAULT.directBuffer(length);\n"
640640
"$ProteusMetadata$.encode(metadataBuf, $service_name$.$namespace_id_name$, $service_name$.$service_id_name$, $service_name$.$method_id_name$, metadata);\n"
641641
"$ByteBuf$ data = serialize(message);\n"
@@ -660,7 +660,7 @@ static void PrintClient(const ServiceDescriptor* service,
660660
p->Indent();
661661
p->Print(
662662
*vars,
663-
"final int length = $ProteusMetadata$.computeLength();\n"
663+
"final int length = $ProteusMetadata$.computeLength(metadata);\n"
664664
"$ByteBuf$ metadataBuf = $ByteBufAllocator$.DEFAULT.directBuffer(length);\n"
665665
"$ProteusMetadata$.encode(metadataBuf, $service_name$.$namespace_id_name$, $service_name$.$service_id_name$, $service_name$.$method_id_name$, metadata);\n"
666666
"$ByteBuf$ data = serialize(message);\n"
@@ -683,7 +683,7 @@ static void PrintClient(const ServiceDescriptor* service,
683683
p->Indent();
684684
p->Print(
685685
*vars,
686-
"final int length = $ProteusMetadata$.computeLength();\n"
686+
"final int length = $ProteusMetadata$.computeLength(metadata);\n"
687687
"$ByteBuf$ metadataBuf = $ByteBufAllocator$.DEFAULT.directBuffer(length);\n"
688688
"$ProteusMetadata$.encode(metadataBuf, $service_name$.$namespace_id_name$, $service_name$.$service_id_name$, $service_name$.$method_id_name$, metadata);\n"
689689
"$ByteBuf$ data = serialize(message);\n"

0 commit comments

Comments
 (0)