Skip to content

Commit 3c1b54b

Browse files
committed
Unify two largely duplicate test workflows into one and add macos into the matrix of OSes
- Duplication is evil - I do not see a reason to not support specific per OS versions of Python but if needed, could always be done via "exclude" - requirements.txt file seems to be always there so unclear why to check - If works on Mac, Closes #30
1 parent 7061909 commit 3c1b54b

File tree

2 files changed

+6
-47
lines changed

2 files changed

+6
-47
lines changed
Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
name: linux-tests
1+
name: tests
2+
23

34
on: [push, pull_request]
45

@@ -8,12 +9,9 @@ jobs:
89
runs-on: ${{ matrix.os }}
910
strategy:
1011
matrix:
11-
os: [ubuntu-latest]
12-
# Python 3.3 and 3.4 have been removed since github won't provide these anymore
13-
# As of 2023/01/09, we have removed python 3.5 and 3.6 as they don't work anymore with linux on github
14-
# As of 2023/08/30, we have removed python 2.7 since github actions won't provide it anymore
15-
# As of 2025/01/20, we have removed python 3.7 since github actions won't povide it anymore
16-
python-version: [3.8, 3.9, "3.10", "3.11", "3.12", "3.13", 'pypy-3.6', 'pypy-3.7', 'pypy-3.8', 'pypy-3.10']
12+
# Remember kids, the default shell on Windows is Powershell
13+
os: [linux-latest, macos-latest, windows-latest]
14+
python-version: [3.8, 3.9, "3.10", "3.11", "3.12", "3.13", "pypy-3.6", "pypy-3.7", "pypy-3.8", "pypy-3.10"]
1715

1816
steps:
1917
- uses: actions/checkout@v3
@@ -25,7 +23,7 @@ jobs:
2523
run: |
2624
python -m pip install --upgrade pip
2725
python -m pip install --upgrade setuptools
28-
if [ -f command_runner/requirements.txt ]; then pip install -r command_runner/requirements.txt; fi
26+
pip install -r command_runner/requirements.txt
2927
- name: Generate Report
3028
env:
3129
RUNNING_ON_GITHUB_ACTIONS: true

.github/workflows/windows.yaml

Lines changed: 0 additions & 39 deletions
This file was deleted.

0 commit comments

Comments
 (0)