perf(config): use minimal accounts query when resolving configuration (#6184)

Author: ndhoule

packages/config/src/api/site_info.ts

@@ -74,14 +74,12 @@ export const getSiteInfo = async function ({
     return { siteInfo, accounts: [], addons: [], integrations }
   }
 
-  const promises = [
+  const [siteInfo, accounts, addons, integrations] = await Promise.all([
     getSite(api, siteId, siteFeatureFlagPrefix),
     getAccounts(api),
     getAddons(api, siteId),
     getIntegrations({ siteId, testOpts, offline, accountId, token, featureFlags, extensionApiBaseUrl, mode }),
-  ]
-
-  const [siteInfo, accounts, addons, integrations] = await Promise.all(promises)
+  ])
 
   if (siteInfo.use_envelope) {
     const envelope = await getEnvelope({ api, accountId: siteInfo.account_slug, siteId, context })
@@ -105,12 +103,28 @@ const getSite = async function (api: NetlifyAPI, siteId: string, siteFeatureFlag
   }
 }
 
-const getAccounts = async function (api: NetlifyAPI) {
+export type MinimalAccount = {
+  id: string
+  name: string
+  slug: string
+  default: boolean
+  team_logo_url: string | null
+  on_pro_trial: boolean
+  organization_id: string | null
+  type_name: string
+  type_slug: string
+  members_count: number
+}
+
+const getAccounts = async function (api: NetlifyAPI): Promise<MinimalAccount[]> {
   try {
-    const accounts = await (api as any).listAccountsForUser()
-    return Array.isArray(accounts) ? accounts : []
+    const accounts = (await api.listAccountsForUser(
+      // @ts-expect-error(ndhoule): This is an unpublished, internal querystring parameter
+      { minimal: 'true' },
+    )) as MinimalAccount[] | null
+    return Array.isArray(accounts) ? (accounts as MinimalAccount[]) : []
   } catch (error) {
-    throwUserError(`Failed retrieving user account: ${error.message}. ${ERROR_CALL_TO_ACTION}`)
+    return throwUserError(`Failed retrieving user account: ${error.message}. ${ERROR_CALL_TO_ACTION}`)
   }
 }
 

packages/config/src/main.ts

@@ -1,5 +1,5 @@
 import { getApiClient } from './api/client.js'
-import { getSiteInfo } from './api/site_info.js'
+import { getSiteInfo, type MinimalAccount } from './api/site_info.js'
 import { getInitialBase, getBase, addBase } from './base.js'
 import { getBuildDir } from './build_dir.js'
 import { getCachedConfig } from './cached_config.js'
@@ -24,12 +24,31 @@ import { parseConfig } from './parse.js'
 import { getConfigPath } from './path.js'
 import { getRedirectsPath, addRedirects } from './redirects.js'
 
+export type Config = {
+  accounts: MinimalAccount[] | undefined
+  addons: any
+  api: any
+  branch: any
+  buildDir: any
+  config: any
+  configPath: any
+  context: any
+  env: any
+  headersPath: any
+  integrations: any
+  logs: any
+  redirectsPath: any
+  repositoryRoot: any
+  siteInfo: any
+  token: any
+}
+
 /**
  * Load the configuration file.
  * Takes an optional configuration file path as input and return the resolved
  * `config` together with related properties such as the `configPath`.
  */
-export const resolveConfig = async function (opts) {
+export const resolveConfig = async function (opts): Promise<Config> {
   const {
     cachedConfig,
     cachedConfigPath,