feat: update edge functions bundling to Deno 2.x (#6716)

Author: eduardoboucas

.github/workflows/workflow.yml

@@ -54,14 +54,12 @@ jobs:
         os: [ubuntu-24.04, macos-14, windows-2025]
         node-version: ['22']
         # Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`.
-        # We're adding v2.4.2 here because it's needed for the upcoming nimble release, so we can test
-        # those workflows ahead of time before we can update the base version across the board.
-        deno-version: ['v1.39.0', 'v2.2.4', 'v2.4.2']
+        deno-version: ['v2.4.2']
         include:
           - os: ubuntu-24.04
             # Earliest supported version
             node-version: '18.14.0'
-            deno-version: 'v2.2.4'
+            deno-version: 'v2.4.2'
       fail-fast: false
     steps:
       # Sets an output parameter if this is a release PR
@@ -159,7 +157,7 @@ jobs:
       - name: Setup Deno
         uses: denoland/setup-deno@v1
         with:
-          deno-version: v2.2.4
+          deno-version: v2.4.2
         if: ${{ !steps.release-check.outputs.IS_RELEASE }}
       - name: Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v5

eslint.config.js

@@ -78,7 +78,7 @@ export default tseslint.config(
 
   // Project-specific rules
   {
-    ignores: ['packages/**/dist', 'packages/**/lib'],
+    ignores: ['packages/**/dist', 'packages/**/lib', 'packages/edge-bundler/deno/**'],
   },
   {
     files: ['**/*.?(c|m)ts?(x)'],

eslint_temporary_suppressions.js

@@ -1707,266 +1707,6 @@ export default [
       '@typescript-eslint/no-explicit-any': 'off',
     },
   },
-  {
-    files: ['packages/edge-bundler/deno/bundle.ts'],
-    rules: {
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-unsafe-argument': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/config.ts'],
-    rules: {
-      'n/no-missing-import': 'off',
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-unsafe-argument': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/[email protected]/_util/os.ts'],
-    rules: {
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-unsafe-return': 'off',
-      'n/no-unsupported-features/node-builtins': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/[email protected]/path/_util.ts'],
-    rules: {
-      '@typescript-eslint/no-non-null-assertion': 'off',
-      '@typescript-eslint/no-unnecessary-type-assertion': 'off',
-      '@typescript-eslint/prefer-nullish-coalescing': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/[email protected]/path/glob.ts'],
-    rules: {
-      '@typescript-eslint/no-unnecessary-condition': 'off',
-      '@typescript-eslint/no-non-null-assertion': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/[email protected]/path/posix.ts'],
-    rules: {
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-      '@typescript-eslint/no-unnecessary-condition': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/[email protected]/path/win32.ts'],
-    rules: {
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-      '@typescript-eslint/no-unnecessary-condition': 'off',
-      '@typescript-eslint/no-non-null-assertion': 'off',
-      '@typescript-eslint/prefer-regexp-exec': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/[email protected]/async/deferred.ts'],
-    rules: {
-      '@typescript-eslint/no-explicit-any': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/[email protected]/async/mux_async_iterator.ts'],
-    rules: {
-      '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-floating-promises': 'off',
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/prefer-for-of': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/[email protected]/async/pool.ts'],
-    rules: {
-      'n/no-unsupported-features/node-builtins': 'off',
-      '@typescript-eslint/no-floating-promises': 'off',
-      '@typescript-eslint/no-unsafe-argument': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/[email protected]/async/tee.ts'],
-    rules: {
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-unnecessary-condition': 'off',
-      '@typescript-eslint/use-unknown-in-catch-callback-variable': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/data_local_dir/mod.ts'],
-    rules: {
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-      '@typescript-eslint/no-unsafe-return': 'off',
-      '@typescript-eslint/restrict-template-expressions': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/eszip_wasm.generated.js'],
-    rules: {
-      '@typescript-eslint/no-unused-vars': 'off',
-      '@typescript-eslint/no-array-constructor': 'off',
-      'n/no-missing-import': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/loader.ts'],
-    rules: {
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/mod.ts'],
-    rules: {
-      'n/no-missing-import': 'off',
-      '@typescript-eslint/use-unknown-in-catch-callback-variable': 'off',
-      '@typescript-eslint/prefer-promise-reject-errors': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/deps.ts'],
-    rules: {
-      'n/no-missing-import': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/misc.ts'],
-    rules: {
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-unsafe-return': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/retry/decorator.ts'],
-    rules: {
-      '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-unsafe-return': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/retry/options.ts'],
-    rules: {
-      '@typescript-eslint/no-explicit-any': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/retry/retry.ts'],
-    rules: {
-      '@typescript-eslint/no-unused-vars': 'off',
-      '@typescript-eslint/no-non-null-assertion': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-      '@typescript-eslint/no-unsafe-argument': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/retry/tooManyTries.ts'],
-    rules: {
-      '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/retry/utils/untilDefined/decorators.ts'],
-    rules: {
-      '@typescript-eslint/no-explicit-any': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/retry/utils/untilDefined/retry.ts'],
-    rules: {
-      '@typescript-eslint/no-unnecessary-type-parameters': 'off',
-      '@typescript-eslint/no-non-null-assertion': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/retry/utils/untilResponse/decorators.ts'],
-    rules: {
-      '@typescript-eslint/no-explicit-any': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/retry/utils/untilResponse/retry.ts'],
-    rules: {
-      '@typescript-eslint/no-unnecessary-type-parameters': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/retry/utils/untilTruthy/decorators.ts'],
-    rules: {
-      '@typescript-eslint/no-explicit-any': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/retry/utils/untilTruthy/retry.ts'],
-    rules: {
-      '@typescript-eslint/no-unnecessary-type-parameters': 'off',
-      '@typescript-eslint/no-explicit-any': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/wait/decorators.ts'],
-    rules: {
-      '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-unsafe-return': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/wait/timeoutError.ts'],
-    rules: {
-      '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/wait/wait.ts'],
-    rules: {
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/cache.ts'],
-    rules: {
-      'n/no-missing-import': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/restrict-template-expressions': 'off',
-      'n/no-unsupported-features/node-builtins': 'off',
-      '@typescript-eslint/no-non-null-assertion': 'off',
-      '@typescript-eslint/prefer-regexp-exec': 'off',
-      '@typescript-eslint/no-unnecessary-condition': 'off',
-    },
-  },
-  {
-    files: ['packages/edge-bundler/deno/vendor/deno.land/x/[email protected]/loader.ts'],
-    rules: {
-      '@typescript-eslint/no-unnecessary-condition': 'off',
-      '@typescript-eslint/return-await': 'off',
-      '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-unsafe-member-access': 'off',
-      '@typescript-eslint/no-unsafe-assignment': 'off',
-      '@typescript-eslint/no-unsafe-call': 'off',
-      '@typescript-eslint/no-unsafe-argument': 'off',
-    },
-  },
   {
     files: ['packages/edge-bundler/node/bridge.test.ts'],
     rules: {

packages/edge-bundler/deno/extract.ts

@@ -0,0 +1,7 @@
+import { loadESZIP } from 'https://deno.land/x/[email protected]/eszip.ts'
+
+const [functionPath, destPath] = Deno.args
+
+const eszip = await loadESZIP(functionPath)
+
+await eszip.extract(destPath)

packages/edge-bundler/deno/lib/stage2.ts

@@ -105,7 +105,7 @@ const stage2Loader = (
   }
 }
 
-const writeStage2 = async ({
+export const writeStage2 = async ({
   basePath,
   destPath,
   externals,
@@ -122,5 +122,3 @@ const writeStage2 = async ({
 
   return await Deno.writeFile(destPath, bytes)
 }
-
-export { writeStage2 }