Skip to content

Commit 5bb784a

Browse files
authored
fix: update DENO_VERSION_RANGE (#5929)
* Update DENO_VERSION_RANGE * chore: update lower end of deno version range * test: match deno ranges in tests to DENO_VERSION_RANGE * fix: update comment with a link to buildbot
1 parent d56933d commit 5bb784a

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

.github/workflows/workflow.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ jobs:
5252
os: [ubuntu-latest, macOS-latest, windows-latest]
5353
node-version: ['*']
5454
# Must include the minimum deno version from the `DENO_VERSION_RANGE` constant in `node/bridge.ts`.
55-
deno-version: ['v1.37.0', 'v1.44.4']
55+
deno-version: ['v1.39.0', 'v1.46.3']
5656
include:
5757
- os: ubuntu-latest
5858
node-version: '14.16.0'
59-
deno-version: 'v1.44.4'
59+
deno-version: 'v1.46.3'
6060
fail-fast: false
6161
steps:
6262
# Increasing the maximum number of open files. See:
@@ -192,7 +192,7 @@ jobs:
192192
- name: Setup Deno
193193
uses: denoland/setup-deno@v1
194194
with:
195-
deno-version: v1.44.4
195+
deno-version: v1.46.3
196196
if: ${{ !steps.release-check.outputs.IS_RELEASE }}
197197
- name: Node.js ${{ matrix.node-version }}
198198
uses: actions/setup-node@v4

packages/edge-bundler/node/bridge.ts

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,10 @@ import { getBinaryExtension } from './platform.js'
1313

1414
const DENO_VERSION_FILE = 'version.txt'
1515

16-
// When updating DENO_VERSION_RANGE, ensure that the deno version installed in the
17-
// build-image/buildbot does satisfy this range!
18-
// We're pinning the range because of an issue with v1.45.0 of the Deno CLI:
19-
// https://linear.app/netlify/issue/FRP-775/deno-cli-v1450-causing-issues
20-
const DENO_VERSION_RANGE = '1.37.0 - 1.44.4'
16+
// When updating DENO_VERSION_RANGE, ensure that the deno version
17+
// on the netlify/buildbot build image satisfies this range!
18+
// https://github.com/netlify/buildbot/blob/f9c03c9dcb091d6570e9d0778381560d469e78ad/build-image/noble/Dockerfile#L410
19+
const DENO_VERSION_RANGE = '1.39.0 - 1.46.3'
2120

2221
type OnBeforeDownloadHook = () => void | Promise<void>
2322
type OnAfterDownloadHook = (error?: Error) => void | Promise<void>

0 commit comments

Comments
 (0)