fix: swap from read-package-up to read-pkg-up (#6189)

JakeChampion · web-flow · commit b6fa0125695c · 2025-04-09T21:56:10.000Z
read-package-up was a breaking change from read-pkg-up, the breaking change was requiring node 18 sindresorhus/read-package-up@v10.1.0...v11.0.0
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/build/package.json b/packages/build/package.json
@@ -110,7 +110,7 @@
     "pkg-dir": "^7.0.0",
     "pretty-ms": "^8.0.0",
     "ps-list": "^8.0.0",
-    "read-package-up": "^11.0.0",
+    "read-pkg-up": "^9.0.0",
     "readdirp": "^3.4.0",
     "resolve": "^2.0.0-next.5",
     "rfdc": "^1.3.0",
diff --git a/packages/build/src/plugins/compatibility.ts b/packages/build/src/plugins/compatibility.ts
@@ -1,6 +1,6 @@
 import _pEvery from 'p-every'
 import pLocate from 'p-locate'
-import { PackageJson } from 'read-package-up'
+import { PackageJson } from 'read-pkg-up'
 import semver from 'semver'
 
 import { FeatureFlags } from '../core/feature_flags.js'
diff --git a/packages/build/src/plugins/expected_version.ts b/packages/build/src/plugins/expected_version.ts
@@ -1,4 +1,4 @@
-import { PackageJson } from 'read-package-up'
+import { PackageJson } from 'read-pkg-up'
 import semver from 'semver'
 
 import { FeatureFlags } from '../core/feature_flags.js'
diff --git a/packages/build/src/plugins/manifest/main.ts b/packages/build/src/plugins/manifest/main.ts
@@ -1,4 +1,4 @@
-import { PackageJson } from 'read-package-up'
+import { PackageJson } from 'read-pkg-up'
 
 import { addPluginLoadErrorStatus } from '../../status/load_error.js'
 
diff --git a/packages/build/src/plugins/options.ts b/packages/build/src/plugins/options.ts
@@ -1,6 +1,6 @@
 import { dirname } from 'path'
 
-import { PackageJson } from 'read-package-up'
+import { PackageJson } from 'read-pkg-up'
 import semver from 'semver'
 
 import { addErrorInfo } from '../error/info.js'
diff --git a/packages/build/src/plugins/plugin_conditions.ts b/packages/build/src/plugins/plugin_conditions.ts
@@ -1,7 +1,7 @@
 import { join } from 'path'
 
 import _pEvery from 'p-every'
-import { PackageJson } from 'read-package-up'
+import { PackageJson } from 'read-pkg-up'
 import semver from 'semver'
 
 import { importJsonFile } from '../utils/json.js'
diff --git a/packages/build/src/utils/json.ts b/packages/build/src/utils/json.ts
@@ -1,7 +1,7 @@
 import { readFile } from 'fs/promises'
 import { fileURLToPath } from 'url'
 
-import type { PackageJson } from 'read-package-up'
+import type { PackageJson } from 'read-pkg-up'
 
 // We know how our package.json looks like, so we can be very specific with the type
 // and only add the properties we want to use
diff --git a/packages/build/src/utils/package.ts b/packages/build/src/utils/package.ts
@@ -1,6 +1,6 @@
 import { dirname } from 'path'
 
-import { Options, PackageJson, readPackageUp } from 'read-package-up'
+import { Options, PackageJson, readPackageUp } from 'read-pkg-up'
 
 type PackageResult = {
   packageJson: PackageJson
diff --git a/packages/edge-bundler/package.json b/packages/edge-bundler/package.json
@@ -63,7 +63,7 @@
     "better-ajv-errors": "^1.2.0",
     "common-path-prefix": "^3.0.0",
     "env-paths": "^3.0.0",
-    "esbuild": "0.21.2",
+    "esbuild": "0.25.2",
     "execa": "^7.0.0",
     "find-up": "^6.3.0",
     "get-package-name": "^2.2.0",
diff --git a/packages/framework-info/package.json b/packages/framework-info/package.json
@@ -66,7 +66,7 @@
     "locate-path": "^7.0.0",
     "p-filter": "^4.0.0",
     "p-locate": "^6.0.0",
-    "read-package-up": "^11.0.0",
+    "read-pkg-up": "^9.0.0",
     "semver": "^7.3.8"
   },
   "devDependencies": {
diff --git a/packages/framework-info/src/context.ts b/packages/framework-info/src/context.ts
@@ -1,7 +1,7 @@
 import { cwd, version as nodejsVersion } from 'process'
 
 import { locatePath } from 'locate-path'
-import { PackageJson, readPackageUp } from 'read-package-up'
+import { PackageJson, readPackageUp } from 'read-pkg-up'
 
 interface PackageJsonInfo {
   packageJson?: PackageJson
diff --git a/packages/framework-info/src/core.ts b/packages/framework-info/src/core.ts
@@ -1,5 +1,5 @@
 import pFilter from 'p-filter'
-import type { PackageJson } from 'read-package-up'
+import type { PackageJson } from 'read-pkg-up'
 
 import type { Context, PathExists } from './context.js'
 import { usesFramework } from './detect.js'
diff --git a/packages/framework-info/src/package.ts b/packages/framework-info/src/package.ts
@@ -1,6 +1,6 @@
 import { includeKeys } from 'filter-obj'
 import isPlainObj from 'is-plain-obj'
-import type { PackageJson } from 'read-package-up'
+import type { PackageJson } from 'read-pkg-up'
 
 export const getPackageJsonContent = function (packageJson: PackageJson | undefined) {
   if (packageJson === undefined) {
diff --git a/packages/opentelemetry-sdk-setup/package.json b/packages/opentelemetry-sdk-setup/package.json
@@ -38,6 +38,7 @@
     "@opentelemetry/core": "~1.24.0",
     "@opentelemetry/resources": "~1.24.0",
     "@opentelemetry/semantic-conventions": "~1.24.0",
+    "read-pkg-up": "^9",
     "yargs-parser": "^21.1.1"
   },
   "devDependencies": {
diff --git a/packages/opentelemetry-sdk-setup/src/sdk-setup.ts b/packages/opentelemetry-sdk-setup/src/sdk-setup.ts
@@ -3,7 +3,7 @@ import { setMultiSpanAttributes } from '@netlify/opentelemetry-utils'
 import { DiagLogLevel, TraceFlags, context, diag, trace } from '@opentelemetry/api'
 import { Resource } from '@opentelemetry/resources'
 import { SEMRESATTRS_SERVICE_NAME, SEMRESATTRS_SERVICE_VERSION } from '@opentelemetry/semantic-conventions'
-import type { PackageJson } from 'read-package-up'
+import type { PackageJson } from 'read-pkg-up'
 
 import { getDiagLogger, loadBaggageFromFile } from './util.js'
 
diff --git a/packages/opentelemetry-sdk-setup/src/util.ts b/packages/opentelemetry-sdk-setup/src/util.ts
@@ -3,7 +3,7 @@ import { readFile, realpath } from 'node:fs/promises'
 
 import { diag, DiagLogger } from '@opentelemetry/api'
 import { parseKeyPairsIntoRecord } from '@opentelemetry/core/build/src/baggage/utils.js'
-import { PackageJson, readPackageUp } from 'read-package-up'
+import { PackageJson, readPackageUp } from 'read-pkg-up'
 
 /**
  * Builds a function for logging data to a provided fileDescriptor (i.e. hidden from
diff --git a/packages/zip-it-and-ship-it/package.json b/packages/zip-it-and-ship-it/package.json
@@ -46,7 +46,7 @@
     "@netlify/binary-info": "^1.0.0",
     "@netlify/serverless-functions-api": "^1.36.0",
     "@vercel/nft": "0.27.7",
-    "archiver": "^7.0.0",
+    "archiver": "^5.3.1",
     "common-path-prefix": "^3.0.0",
     "cp-file": "^10.0.0",
     "es-module-lexer": "^1.0.0",
@@ -92,7 +92,7 @@
     "cpy": "9.0.1",
     "decompress": "4.2.1",
     "deepmerge": "^4.3.1",
-    "get-stream": "8.0.1",
+    "get-stream": "6.0.1",
     "is-ci": "4.1.0",
     "lambda-local": "2.2.0",
     "source-map-support": "0.5.21",
diff --git a/packages/zip-it-and-ship-it/src/runtimes/detect_runtime.ts b/packages/zip-it-and-ship-it/src/runtimes/detect_runtime.ts
@@ -22,7 +22,13 @@ The binary needs to be built for Linux/Amd64, but it was built for ${Platform[bi
 export const detectBinaryRuntime = async function ({ path }: { path: string }): Promise<RuntimeName | undefined> {
   try {
     const fileContents = await readFile(path)
-    const binaryInfo = detect(fileContents)
+    const binaryInfo = detect(
+      new Uint8Array(
+        fileContents.buffer,
+        fileContents.byteOffset,
+        fileContents.byteLength / Uint8Array.BYTES_PER_ELEMENT,
+      ),
+    )
 
     if (!isValidFunctionBinary(binaryInfo)) {
       return warnIncompatibleBinary(path, binaryInfo)
diff --git a/packages/zip-it-and-ship-it/src/zip.ts b/packages/zip-it-and-ship-it/src/zip.ts
@@ -169,7 +169,7 @@ export const zipFunction = async function (
     runtime,
     srcDir,
     stat: stats,
-  }: FunctionSource = functions.values().next().value
+  }: FunctionSource = functions.values().next().value!
 
   await fs.mkdir(destFolder, { recursive: true })
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { PackageJson } from 'read-package-up'`
	`1`	`+import { PackageJson } from 'read-pkg-up'`
`2`	`2`	`import semver from 'semver'`
`3`	`3`
`4`	`4`	`import { FeatureFlags } from '../core/feature_flags.js'`