test: remove references to fully rolled out netlify_build_reduced_output (#6055)

* test: remove references to fully rolled out netlify_build_reduced_output

* test: update snapshots

* test: remove expectation of hidden logs from test

Author: mrstork

packages/build/src/core/feature_flags.ts

@@ -17,7 +17,6 @@ const getFeatureFlag = function (name: string): FeatureFlags {
 export const DEFAULT_FEATURE_FLAGS: FeatureFlags = {
   buildbot_zisi_trace_nft: false,
   buildbot_zisi_esbuild_parser: false,
-  netlify_build_reduced_output: false,
   netlify_build_updated_plugin_compatibility: false,
   netlify_build_plugin_system_log: false,
 }

packages/build/src/steps/run_step.ts

@@ -124,13 +124,7 @@ export const runStep = async function ({
             // no-op
           }
 
-    let outputFlusher: OutputFlusher | undefined
-
-    if (featureFlags.netlify_build_reduced_output) {
-      outputFlusher = new OutputFlusher(logPluginStart)
-    } else {
-      logPluginStart()
-    }
+    const outputFlusher = new OutputFlusher(logPluginStart)
 
     const fireStep = getFireStep(packageName, coreStepId, event)
     const {

packages/build/tests/blobs_upload/tests.js

@@ -80,10 +80,7 @@ test.serial(
 test.serial('Blobs upload step uploads files to deploy store (legacy API)', async (t) => {
   const fixture = await new Fixture('./fixtures/src_with_blobs_legacy').withCopyRoot({ git: false })
 
-  const {
-    success,
-    logs: { stdout },
-  } = await fixture
+  const { success } = await fixture
     .withFlags({ deployId: 'abc123', siteId: 'test', token: TOKEN, offline: true, cwd: fixture.repositoryRoot })
     .runBuildProgrammatic()
 
@@ -117,17 +114,12 @@ test.serial('Blobs upload step uploads files to deploy store (legacy API)', asyn
   const blob3 = await store.getWithMetadata('nested/file.txt')
   t.is(blob3.data, 'file value')
   t.deepEqual(blob3.metadata, { some: 'metadata' })
-
-  t.true(stdout.join('\n').includes('Uploading blobs to deploy store'))
 })
 
 test.serial('Blobs upload step uploads files to deploy store (legacy deploy config API)', async (t) => {
   const fixture = await new Fixture('./fixtures/src_with_blobs_legacy_deploy_config').withCopyRoot({ git: false })
 
-  const {
-    success,
-    logs: { stdout },
-  } = await fixture
+  const { success } = await fixture
     .withFlags({ deployId: 'abc123', siteId: 'test', token: TOKEN, offline: true, cwd: fixture.repositoryRoot })
     .runBuildProgrammatic()
   t.true(success)
@@ -160,17 +152,12 @@ test.serial('Blobs upload step uploads files to deploy store (legacy deploy conf
   const blob3 = await store.getWithMetadata('nested/file.txt')
   t.is(blob3.data, 'file value')
   t.deepEqual(blob3.metadata, { some: 'metadata' })
-
-  t.true(stdout.join('\n').includes('Uploading blobs to deploy store'))
 })
 
 test.serial('Blobs upload step uploads files to deploy store', async (t) => {
   const fixture = await new Fixture('./fixtures/src_with_blobs').withCopyRoot({ git: false })
 
-  const {
-    success,
-    logs: { stdout },
-  } = await fixture
+  const { success } = await fixture
     .withFlags({ deployId: 'abc123', siteId: 'test', token: TOKEN, offline: true, cwd: fixture.repositoryRoot })
     .runBuildProgrammatic()
 
@@ -206,8 +193,6 @@ test.serial('Blobs upload step uploads files to deploy store', async (t) => {
   const blob3 = await store.getWithMetadata('nested/blob')
   t.is(blob3.data, 'file value')
   t.deepEqual(blob3.metadata, { some: 'metadata' })
-
-  t.true(stdout.join('\n').includes('Uploading blobs to deploy store'))
 })
 
 test.serial('Blobs upload step cancels deploy if blob metadata is malformed', async (t) => {
@@ -229,10 +214,7 @@ test.serial('Blobs upload step cancels deploy if blob metadata is malformed', as
 if (semver.gte(nodeVersion, '16.9.0')) {
   test.serial('monorepo > blobs upload, uploads files to deploy store', async (t) => {
     const fixture = await new Fixture('./fixtures/monorepo').withCopyRoot({ git: false })
-    const {
-      success,
-      logs: { stdout },
-    } = await fixture
+    const { success } = await fixture
       .withFlags({ deployId: 'abc123', siteId: 'test', token: TOKEN, offline: true, packagePath: 'apps/app-1' })
       .runBuildProgrammatic()
 
@@ -258,7 +240,5 @@ if (semver.gte(nodeVersion, '16.9.0')) {
     const blob3 = await store.getWithMetadata('nested/file.txt')
     t.is(blob3.data, 'file value')
     t.deepEqual(blob3.metadata, { some: 'metadata' })
-
-    t.true(stdout.join('\n').includes('Uploading blobs to deploy store'))
   })
 }

packages/build/tests/constants/snapshots/tests.js.md

@@ -1,4 +1,4 @@
-# Snapshot report for `packages/build/tests/constants/tests.js`
+# Snapshot report for `tests/constants/tests.js`
 
 The actual snapshot is saved in `tests.js.snap`.
 
@@ -670,12 +670,6 @@ Generated by [AVA](https://avajs.dev).
     ␊
     > Loading plugins␊
        - ./plugin from netlify.toml␊
-    ␊
-    ./plugin (onPreBuild event)                                   ␊
-    ────────────────────────────────────────────────────────────────␊
-    ␊
-    ␊
-    (./plugin onPreBuild completed in 1ms)␊
     Build step duration: ./plugin onPreBuild completed in 1ms␊
     ␊
     Functions bundling                                            ␊

packages/build/tests/constants/snapshots/tests.js.snap

@@ -1458,10 +1458,6 @@ Generated by [AVA](https://avajs.dev).
     > Loading plugins␊
        - ./[email protected] from netlify.toml␊
     ␊
-    ./plugin.js (onBuild event)                                   ␊
-    ────────────────────────────────────────────────────────────────␊
-    ␊
-    ␊
     Build canceled by ./plugin.js                                 ␊
     ────────────────────────────────────────────────────────────────␊
     ␊

packages/build/tests/core/snapshots/tests.js.md

@@ -165,12 +165,6 @@ Generated by [AVA](https://avajs.dev).
     ␊
     (./plugin onPreBuild completed in 1ms)␊
     ␊
-    Edge Functions bundling                                       ␊
-    ────────────────────────────────────────────────────────────────␊
-    ␊
-    ␊
-    (Edge Functions bundling completed in 1ms)␊
-    ␊
     Netlify Build Complete                                        ␊
     ────────────────────────────────────────────────────────────────␊
     ␊