chore: remove plugins_break_builds_with_unsupported_plugin_versions feature flag (#4776)

* chore: remove plugins_break_builds_with_unsupported_plugin_versions feature flag

* chore: more cleanup

* chore: forgot to add the removal of a fixture

* docs: update CONTRIBUTING.md to include info on how to run tests locally

Author: ericapisani

CONTRIBUTING.md

@@ -57,6 +57,29 @@ To speed up CI, we load balance the tests across multiple machines. The informat
 is stored in `tests-metadata.json`, and later used by our test [runner](ava.config.js#L10). To regenerate the data (e.g.
 when adding a new test file) run `npm test:measure` and commit the changes to GitHub.
 
+### Testing locally
+
+The `@netlify/testing` package will need to be built regardless of which package you are working on. In order to do this
+run the following from the root directory:
+
+```
+npm run build -- --scope=@netlify/testing
+```
+
+If you wish to build all of the projects for whatever reason, the command is `npm run build`.
+
+From there, you can run tests for a particular package by running:
+
+```
+npm run test -- --scope=<name of package as it appears in 'name' field in package.json>
+```
+
+For example, if you wished to run tests for the `build` package:
+
+```
+npm run test -- --scope=@netlify/build
+```
+
 ## Releasing
 
 For more details, please refer to the

packages/build/src/core/feature_flags.js

@@ -18,7 +18,4 @@ export const DEFAULT_FEATURE_FLAGS = {
   buildbot_zisi_esbuild_parser: false,
   edge_functions_cache_cli: false,
   edge_functions_system_logger: false,
-  // TODO: remove this flag once rolled out to everyone
-  // FF link: https://app.launchdarkly.com/default/production/features/plugins_break_builds_with_unsupported_plugin_versions/targeting
-  plugins_break_builds_with_unsupported_plugin_versions: false,
 }

packages/build/src/log/messages/compatibility.ts

@@ -1,6 +1,5 @@
 import semver from 'semver'
 
-import { addErrorInfo } from '../../error/info.js'
 import { isRuntime } from '../../utils/runtime.js'
 import { isPreviousMajor } from '../../utils/semver.js'
 import { getPluginOrigin } from '../description.js'
@@ -84,17 +83,13 @@ const getVersionField = function ([versionFieldName, version]) {
 
 // Print a warning message when old versions plugins are used.
 // This can only happen when they are installed to `package.json`.
-// Also throws an error if the Next runtime is >= 4.0.0 || < 4.26.0
-export const logOutdatedPlugins = function (logs: BufferedLogs, pluginsOptions, featureFlags) {
+export const logOutdatedPlugins = function (logs: BufferedLogs, pluginsOptions) {
   const outdatedPlugins = pluginsOptions.filter(hasOutdatedVersion).map(getOutdatedPlugin)
 
   if (outdatedPlugins.length === 0) {
     return
   }
 
-  // TODO: remove feature flag once fully rolled out
-  if (featureFlags.plugins_break_builds_with_unsupported_plugin_versions)
-    throwIfUnsupportedPluginVersion(pluginsOptions.filter(hasOutdatedVersion))
   logWarningSubHeader(logs, 'Outdated plugins')
   logWarningArray(logs, outdatedPlugins)
 }
@@ -151,34 +146,6 @@ export const logIncompatiblePlugins = function (logs, pluginsOptions) {
   logWarningArray(logs, incompatiblePlugins)
 }
 
-// Throws an error if the Next runtime is >= 4.0.0 || < 4.26.0, otherwise returns.
-const throwIfUnsupportedPluginVersion = function (outdatedPlugins: any[]) {
-  let packageName
-  let version
-  let latestVersion
-  const nextOutdatedV4Plugin = outdatedPlugins.find((plugin) => {
-    packageName = plugin.pluginPackageJson.name
-    version = plugin.pluginPackageJson.version
-    latestVersion = plugin.latestVersion
-    // https://github.com/npm/node-semver#hyphen-ranges-xyz---abc
-    // semver hyphen range is inclusive 4.0.0 - 4.25.0 is same as >= 4.0.0 || < 4.26.0;
-    return (
-      packageName === '@netlify/plugin-nextjs' &&
-      semver.satisfies(version, '4.0.0 - 4.25.0', { includePrerelease: true })
-    )
-  })
-
-  if (!nextOutdatedV4Plugin) {
-    return
-  }
-
-  const error = new Error(
-    `This site cannot be built because it is using an outdated version of the Next.js Runtime: ${packageName}@${version}. Versions greater than 4.26.0 are recommended. To upgrade this plugin, please update its version in "package.json" to the latest version: ${latestVersion}. If you cannot use a more recent version, please contact support at https://www.netlify.com/support for guidance.`,
-  )
-  addErrorInfo(error, { type: 'pluginUnsupportedVersion' })
-  throw error
-}
-
 const hasIncompatibleVersion = function ({ pluginPackageJson: { version }, compatibleVersion, compatWarning }) {
   return (
     compatWarning !== '' &&

packages/build/src/plugins/spawn.ts

@@ -25,7 +25,7 @@ const CHILD_MAIN_FILE = fileURLToPath(new URL('child/main.js', import.meta.url))
 const tStartPlugins = async function ({ pluginsOptions, buildDir, childEnv, logs, debug, featureFlags }) {
   logRuntime(logs, pluginsOptions)
   logLoadingPlugins(logs, pluginsOptions, debug)
-  logOutdatedPlugins(logs, pluginsOptions, featureFlags)
+  logOutdatedPlugins(logs, pluginsOptions)
   logIncompatiblePlugins(logs, pluginsOptions)
 
   const childProcesses = await Promise.all(