Skip to content

Commit d709702

Browse files
authored
chore(deps): avoid packages/testing local deps out of sync (#6190)
See #6188. The `packages/testing` package has dev dependencies on `packages/build` and `packages/config`, but these also have (undeclared) dev dependencies on `packages/testing`. Since our release-please configuration does not include `packages/testing` at all (there's nothing to release; it's a "local package" only), major bumps to either of its dependencies results in `packages/testing` no longer pulling in their local versions and instead pulls in a duplicated previous published version from the NPM registry. This in turn results in `@netlify/config` and/or `@netlify/build` not actually testing their own source, since they use `packages/testing` to test themselves... This is a confusing mess, and [declaring the missing dependencies does not work](#6133) because `nx` detects the circular dependency and aborts 😭. This prevents the problem from reoccuring.
1 parent 0262e3b commit d709702

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/testing/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
"build": "tsc"
1717
},
1818
"devDependencies": {
19-
"@netlify/build": "^31.0.0",
20-
"@netlify/config": "^21.0.7",
19+
"@netlify/build": "*",
20+
"@netlify/config": "*",
2121
"@types/lodash-es": "^4.17.6",
2222
"@types/node": "^14.18.53",
2323
"ava": "^4.0.0",

0 commit comments

Comments
 (0)