fix: use stable edge functions bootstrap package for globalThis.Netlify

Author: JakeChampion

deno.lock

@@ -1,14 +1,11 @@
-// this needs to be updated whenever there's a change to globalThis.Netlify in bootstrap
-import { Netlify } from "https://64e8753eae24930008fac6d9--edge.netlify.app/bootstrap/index-combined.ts"
-
-const [functionURL, collectorURL, rawExitCodes] = Deno.args
+const [functionURL, collectorURL, bootstrapURL, rawExitCodes] = Deno.args
 const exitCodes = JSON.parse(rawExitCodes)
 
-globalThis.Netlify = Netlify
-
 let func
 
 try {
+  const {Netlify} = await import(new URL("/bootstrap/globals/implementation.ts", bootstrapURL).toString())
+  globalThis.Netlify = Netlify
   func = await import(functionURL)
 } catch (error) {
   console.error(error)

package-lock.json

@@ -22,6 +22,11 @@ import { writeManifest } from './manifest.js'
 import { vendorNPMSpecifiers } from './npm_dependencies.js'
 import { ensureLatestTypes } from './types.js'
 import { nonNullable } from './utils/non_nullable.js'
+// @ts-expect-error TypeScript is complaining about the values for the `module`
+// and `moduleResolution` configuration properties, but changing those to more
+// modern values causes other packages to fail. Leaving this for now, but we
+// should have a proper fix for this.
+import { getURL as getBootstrapURL } from '@netlify/edge-functions-bootstrap/version'
 
 export interface BundleOptions {
   basePath?: string
@@ -60,8 +65,12 @@ export const bundle = async (
     userLogger,
     systemLogger,
     vendorDirectory,
+    bootstrapURL,
   }: BundleOptions = {},
 ) => {
+  if (!bootstrapURL) {
+    bootstrapURL = await getBootstrapURL()
+  }
   const logger = getLogger(systemLogger, userLogger, debug)
   const featureFlags = getFlags(inputFeatureFlags)
   const options: DenoOptions = {
@@ -161,10 +170,10 @@ export const bundle = async (
   // Retrieving a configuration object for each function.
   // Run `getFunctionConfig` in parallel as it is a non-trivial operation and spins up deno
   const internalConfigPromises = internalFunctions.map(
-    async (func) => [func.name, await getFunctionConfig({ func, importMap, deno, log: logger })] as const,
+    async (func) => [func.name, await getFunctionConfig({ func, importMap, deno, log: logger, bootstrapURL })] as const,
   )
   const userConfigPromises = userFunctions.map(
-    async (func) => [func.name, await getFunctionConfig({ func, importMap, deno, log: logger })] as const,
+    async (func) => [func.name, await getFunctionConfig({ func, importMap, deno, log: logger, bootstrapURL })] as const,
   )
 
   // Creating a hash of function names to configuration objects.

packages/edge-bundler/deno/config.ts

@@ -14,6 +14,11 @@ import { FunctionConfig, getFunctionConfig } from './config.js'
 import type { Declaration } from './declaration.js'
 import { ImportMap } from './import_map.js'
 import { RateLimitAction, RateLimitAggregator } from './rate_limit.js'
+// @ts-expect-error TypeScript is complaining about the values for the `module`
+// and `moduleResolution` configuration properties, but changing those to more
+// modern values causes other packages to fail. Leaving this for now, but we
+// should have a proper fix for this.
+import { getURL as getBootstrapURL } from '@netlify/edge-functions-bootstrap/version'
 
 const importMapFile = {
   baseURL: new URL('file:///some/path/import-map.json'),
@@ -193,6 +198,8 @@ describe('`getFunctionConfig` extracts configuration properties from function fi
 
     await fs.writeFile(path, func.source)
 
+    const bootstrapURL = await getBootstrapURL()
+
     const funcCall = () =>
       getFunctionConfig({
         func: {
@@ -202,6 +209,7 @@ describe('`getFunctionConfig` extracts configuration properties from function fi
         importMap: new ImportMap([importMapFile]),
         deno,
         log: logger,
+        bootstrapURL,
       })
 
     if (func.error) {
@@ -393,6 +401,7 @@ test('Passes validation if default export exists and is a function', async () =>
       importMap: new ImportMap([importMapFile]),
       deno,
       log: logger,
+      bootstrapURL: await getBootstrapURL(),
     }),
   ).resolves.not.toThrow()
 
@@ -429,6 +438,7 @@ test('Fails validation if default export is not function', async () => {
     importMap: new ImportMap([importMapFile]),
     deno,
     log: logger,
+    bootstrapURL: await getBootstrapURL(),
   })
 
   await expect(config).rejects.toThrowError(invalidDefaultExportErr(path))
@@ -465,6 +475,7 @@ test('Fails validation if default export is not present', async () => {
     importMap: new ImportMap([importMapFile]),
     deno,
     log: logger,
+    bootstrapURL: await getBootstrapURL(),
   })
 
   await expect(config).rejects.toThrowError(invalidDefaultExportErr(path))

packages/edge-bundler/node/bundler.ts

@@ -12,6 +12,11 @@ import { ImportMap } from './import_map.js'
 import { Logger } from './logger.js'
 import { getPackagePath } from './package_json.js'
 import { RateLimit } from './rate_limit.js'
+// @ts-expect-error TypeScript is complaining about the values for the `module`
+// and `moduleResolution` configuration properties, but changing those to more
+// modern values causes other packages to fail. Leaving this for now, but we
+// should have a proper fix for this.
+import { getURL as getBootstrapURL } from '@netlify/edge-functions-bootstrap/version'
 
 enum ConfigExitCode {
   Success = 0,
@@ -78,13 +83,17 @@ export const getFunctionConfig = async ({
   func,
   importMap,
   deno,
+  bootstrapURL,
   log,
 }: {
   func: EdgeFunction
   importMap: ImportMap
   deno: DenoBridge
+  bootstrapURL?: string
   log: Logger
 }) => {
+  const concreteBootstrapURL = bootstrapURL || (await getBootstrapURL())
+
   // The extractor is a Deno script that will import the function and run its
   // `config` export, if one exists.
   const extractorPath = getConfigExtractor()
@@ -117,6 +126,7 @@ export const getFunctionConfig = async ({
       extractorPath,
       pathToFileURL(func.path).href,
       pathToFileURL(collector.path).href,
+      concreteBootstrapURL,
       JSON.stringify(ConfigExitCode),
     ].filter(Boolean),
     { rejectOnExitCode: false },

packages/edge-bundler/node/config.test.ts

@@ -148,7 +148,7 @@ const prepareServer = ({
 
     if (options.getFunctionsConfig) {
       functionsConfig = await Promise.all(
-        functions.map((func) => getFunctionConfig({ func, importMap, deno, log: logger })),
+        functions.map((func) => getFunctionConfig({ func, importMap, deno, bootstrapURL, log: logger })),
       )
     }
 

packages/edge-bundler/node/config.ts

@@ -42,7 +42,6 @@
     "test": "test/node"
   },
   "devDependencies": {
-    "@netlify/edge-functions-bootstrap": "^2.14.0",
     "@types/node": "^18.19.111",
     "@types/semver": "^7.3.9",
     "@types/uuid": "^10.0.0",
@@ -59,6 +58,7 @@
     "node": ">=18.14.0"
   },
   "dependencies": {
+    "@netlify/edge-functions-bootstrap": "^2.14.0",
     "@import-maps/resolve": "^2.0.0",
     "ajv": "^8.11.2",
     "ajv-errors": "^3.0.0",