Skip to content

Commit 0e6291d

Browse files
committed
ci: run all workflows when PRing to non-main branches
Most of our GitHub Actions workflows are configured to only run on PRs to `main`. This sucks when you're basing changes on top of each other. Consider the following example: ``` main <-- feat/my-feature <- feat/my-sub-feature ``` As configured now, CI will never run on `feat/my-sub-feature`. It's useful to be able to break changes up into smaller PRs for review, or to be able to sub-branch to avoid merge conflicts while you're waiting for a review.
1 parent 1002f98 commit 0e6291d

File tree

6 files changed

+2
-12
lines changed

6 files changed

+2
-12
lines changed

.github/workflows/codeql.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,7 @@ on:
55
push:
66
branches:
77
- main
8-
paths-ignore:
9-
- '**/*.test.js'
108
pull_request:
11-
branches:
12-
- main
13-
paths-ignore:
14-
- '**/*.test.js'
159
schedule:
1610
- cron: '0 0 * * 0'
1711
workflow_dispatch:

.github/workflows/e2e-tests.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ on:
55
push:
66
branches: [main]
77
pull_request:
8-
branches: [main]
98
schedule:
109
# check daily to notice potential package manager issues
1110
- cron: '0 1 * * *' # At 01:00 daily

.github/workflows/integration-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ name: Integration Tests
33

44
on:
55
push:
6-
branches: [main]
6+
branches:
7+
- main
78
pull_request:
8-
branches: [main]
99

1010
jobs:
1111
integration:

.github/workflows/unit-tests.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ on:
55
push:
66
branches: [main]
77
pull_request:
8-
branches: [main]
98

109
jobs:
1110
unit:

.github/workflows/vale.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ on:
55
push:
66
branches: [main]
77
pull_request:
8-
branches: [main]
98

109
permissions:
1110
checks: write

.github/workflows/verify-docs.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ on:
55
push:
66
branches: [main]
77
pull_request:
8-
branches: [main]
98

109
jobs:
1110
verify-docs:

0 commit comments

Comments
 (0)