feat: throw error on deploy command if build fails and user has --json option (#7367)

* feat: throw error on deploy command if build fails and user has --json option

* test: Add test

* chore: format

Author: sarahetter

src/commands/deploy/deploy.ts

@@ -586,6 +586,10 @@ const handleBuild = async ({
     deployHandler,
   })
   const { configMutations, exitCode, newConfig } = await runBuild(resolvedOptions)
+  // Without this, the deploy command fails silently
+  if (options.json && exitCode !== 0) {
+    logAndThrowError('Error while running build')
+  }
   if (exitCode !== 0) {
     exit(exitCode)
   }

tests/integration/commands/deploy/deploy.test.ts

@@ -449,6 +449,33 @@ describe.skipIf(process.env.NETLIFY_TEST_DISABLE_LIVE === 'true').concurrent('co
     })
   })
 
+  test('should throw error when build fails with --json option', async (t) => {
+    await withSiteBuilder(t, async (builder) => {
+      builder
+        .withContentFile({
+          path: 'public/index.html',
+          content: '<h1>Test content</h1>',
+        })
+        .withNetlifyToml({
+          config: {
+            build: {
+              publish: 'public',
+              command: 'exit 1',
+            },
+          },
+        })
+
+      await builder.build()
+
+      await expect(
+        callCli(['deploy', '--json'], {
+          cwd: builder.directory,
+          env: { NETLIFY_SITE_ID: context.siteId },
+        }),
+      ).rejects.toThrow('Error while running build')
+    })
+  })
+
   test('should deploy hidden public folder but ignore hidden/__MACOSX files', { retry: 3 }, async (t) => {
     await withSiteBuilder(t, async (builder) => {
       builder