Add more rules

Author: ehmicky

.eslintrc.js

@@ -1,90 +1,132 @@
 /* eslint-disable max-lines */
 module.exports = {
-  plugins: ['prettier', 'fp', 'markdown', 'html'],
+  parser: 'babel-eslint',
+  plugins: ['prettier', 'markdown', 'html'],
   extends: [
     'eslint:recommended',
     'standard',
     'prettier',
     'prettier/standard',
-    'plugin:unicorn/recommended',
     'plugin:eslint-comments/recommended',
-    'plugin:node/recommended',
-    'plugin:fp/recommended',
+    'plugin:unicorn/recommended',
     'plugin:ava/recommended',
+    'plugin:react/recommended',
+    'prettier/react',
     'plugin:you-dont-need-lodash-underscore/all',
   ],
   reportUnusedDisableDirectives: true,
   rules: {
-    'no-console': 0,
-    'no-unused-vars': [2, {}],
-    'no-empty': [2, { allowEmptyCatch: true }],
-    'import/order': [
+    // Those ESLint rules are not enabled by Prettier, ESLint recommended rules
+    // nor standard JavaScript. However, they are still useful
+    'array-callback-return': [2, { allowImplicit: true, checkForEach: true }],
+    'block-scoped-var': 2,
+    'consistent-this': 2,
+    'default-case': 2,
+    'default-case-last': 2,
+    'default-param-last': 2,
+    'func-name-matching': [2, { considerPropertyDescriptor: true }],
+    'func-names': [2, 'as-needed'],
+    'func-style': 2,
+    'id-length': [2, { exceptions: ['t', '_'] }],
+    'line-comment-position': 2,
+    'max-classes-per-file': 2,
+    'max-params': [2, { max: 4 }],
+    'multiline-comment-style': [2, 'separate-lines'],
+    'no-await-in-loop': 2,
+    'no-bitwise': 2,
+    'no-constructor-return': 2,
+    'no-duplicate-imports': 2,
+    'no-else-return': [2, { allowElseIf: false }],
+    'no-extra-label': 2,
+    'no-implicit-coercion': 2,
+    'no-implicit-globals': [2, { lexicalBindings: true }],
+    'no-inline-comments': 2,
+    'no-invalid-this': 2,
+    'no-label-var': 2,
+    'no-lonely-if': 2,
+    'no-loop-func': 2,
+    'no-loss-of-precision': 2,
+    'no-magic-numbers': [
       2,
       {
-        'newlines-between': 'always',
-        alphabetize: {
-          order: 'asc',
-          caseInsensitive: true,
-        },
+        ignore: [
+          // Common small numbers
+          -2,
+          -1,
+          0,
+          1,
+          2,
+          3,
+          // HTTP statuses
+          200,
+          201,
+          204,
+          300,
+          301,
+          400,
+          401,
+          403,
+          404,
+          410,
+          422,
+          500,
+        ],
+        enforceConst: true,
+        detectObjects: true,
       },
     ],
-    'no-process-exit': 0,
-    'require-atomic-updates': 0,
+    'no-multi-assign': 2,
+    'no-negated-condition': 2,
+    'no-nested-ternary': 2,
+    'no-plusplus': [2, { allowForLoopAfterthoughts: true }],
+    'no-promise-executor-return': 2,
+    'no-return-await': 2,
+    'no-shadow': 2,
+    'no-underscore-dangle': [2, { enforceInMethodNames: true }],
+    'no-unreachable-loop': 2,
     'no-undef': [2, { typeof: true }],
-
-    'max-lines': [
-      2,
-      {
-        max: 150,
-        skipBlankLines: true,
-        skipComments: true,
-      },
-    ],
-    'max-lines-per-function': [
-      2,
-      {
-        max: 100,
-        skipBlankLines: true,
-        skipComments: true,
-        IIFEs: true,
-      },
-    ],
-    'max-statements': [2, 15],
-    'max-statements-per-line': [2, { max: 2 }],
-    'import/max-dependencies': [2, { max: 20 }],
-    complexity: [2, 5],
-    'max-depth': [2, 2],
-    'max-nested-callbacks': [2, 2],
+    'no-unused-vars': [2, {}],
+    'no-useless-backreference': 2,
+    'no-useless-computed-key': [2, { enforceForClassMembers: true }],
+    'no-useless-concat': 2,
+    'no-var': 2,
+    'object-shorthand': 2,
+    'operator-assignment': 2,
+    'padding-line-between-statements': 2,
+    'prefer-destructuring': 2,
+    'prefer-exponentiation-operator': 2,
+    'prefer-numeric-literals': 2,
+    'prefer-object-spread': 2,
+    'prefer-regex-literals': [2, { disallowRedundantWrapping: true }],
+    'prefer-rest-params': 2,
+    'prefer-spread': 2,
+    'prefer-template': 2,
+    radix: [2, 'as-needed'],
     'require-await': 2,
 
-    'node/no-sync': 2,
-    'node/handle-callback-err': 2,
-    'node/no-new-require': 2,
-    'node/callback-return': 2,
-    'node/exports-style': 2,
-    'node/file-extension-in-import': 2,
-    'node/global-require': 2,
-    'node/no-mixed-requires': 2,
-    // Browser globals should not use `require()`. Non-browser globals should
-    'node/prefer-global/console': 2,
-    'node/prefer-global/url-search-params': 2,
-    'node/prefer-global/text-decoder': 2,
-    'node/prefer-global/text-encoder': 2,
-    'node/prefer-global/url': 2,
-    'node/prefer-global/buffer': [2, 'never'],
-    'node/prefer-global/process': [2, 'never'],
-    // TODO: enable after dropping support for Node <11.4.0
-    'node/prefer-promises/fs': 2,
-    'node/prefer-promises/dns': 2,
-    // This does not work well in a monorepo
-    'node/shebang': 0,
+    // The autofix makes it impossible to use those in debugging
+    'ava/no-only-test': 0,
+    'ava/no-skip-test': 0,
 
     'eslint-comments/no-unused-disable': 0,
     'eslint-comments/no-use': [
       2,
       { allow: ['eslint-disable-next-line', 'eslint-disable', 'eslint-enable', 'eslint-env'] },
     ],
 
+    'import/order': [
+      2,
+      {
+        'newlines-between': 'always',
+        alphabetize: {
+          order: 'asc',
+          caseInsensitive: true,
+        },
+      },
+    ],
+
+    'react/prop-types': 0,
+
     // Not enabled by default in unicorn/recommended, but still pretty useful
     'unicorn/custom-error-definition': 2,
     'unicorn/no-unused-properties': 2,
@@ -112,34 +154,6 @@ module.exports = {
     // TODO: enable after dropping Node 8 support
     'unicorn/prefer-optional-catch-binding': 0,
     'unicorn/prefer-trim-start-end': 0,
-
-    'fp/no-rest-parameters': 0,
-    'fp/no-unused-expression': 0,
-    'fp/no-nil': 0,
-    'fp/no-throw': 0,
-    'fp/no-mutating-methods': [
-      2,
-      { allowedObjects: ['error', 'errorA', 'res', 'state', 'runState', 'logs', 'logsArray', 'currentEnv'] },
-    ],
-    'fp/no-mutation': [
-      2,
-      {
-        commonjs: true,
-        exceptions: [
-          { object: 'error' },
-          { object: 'errorA' },
-          { object: 'res' },
-          { object: 'state' },
-          { object: 'runState' },
-          { object: 'logs' },
-          { object: 'logsArray' },
-          { object: 'currentEnv' },
-          { object: 'process', property: 'exitCode' },
-        ],
-      },
-    ],
-
-    'ava/no-skip-test': 0,
   },
   overrides: [
     {
@@ -165,9 +179,17 @@ module.exports = {
       rules: {
         'no-undef': 0,
         'no-unused-vars': 0,
+        // Inline comments making code samples vertically shorter are useful
+        'line-comment-position': 0,
+        'no-inline-comments': 0,
         'node/no-missing-require': 0,
       },
     },
   ],
+  settings: {
+    react: {
+      version: '16.13.1',
+    },
+  },
 }
 /* eslint-enable max-lines */