This repository was archived by the owner on Jun 9, 2025. It is now read-only.
feat: add type for waitUntil #579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eduardo Bouças <[email protected]>
Comment on lines
+14
to
+18
| /** | ||
| * A Promise that allows the function to respond immediately while still waiting | ||
| * for the operation to complete asynchronously. | ||
| */ | ||
| waitUntil: Promise<any> |
Contributor
There was a problem hiding this comment.
I think this is currently an incorrect type definition, as waitUntil is a method and not itself a Promise
I've made a suggested change below:
Suggested change
| /** | |
| * A Promise that allows the function to respond immediately while still waiting | |
| * for the operation to complete asynchronously. | |
| */ | |
| waitUntil: Promise<any> | |
| /** | |
| * The waitUntil method enables the application to carry on executing after the response has been sent. | |
| * The method has to be called at-least once synchronously before the response has beent sent, but after that it can be called multiple times, and will hold the keep the application running until all the promises passed to it have settled. | |
| */ | |
| waitUntil(f: Promise<any>): void; |
Author
There was a problem hiding this comment.
Currently I have to pass a promise, rather than a function, to get this to work otherwise I get "i.catch is not a function"
JakeChampion
suggested changes
Mar 19, 2025
Contributor
JakeChampion
left a comment
JakeChampion
left a comment
There was a problem hiding this comment.
I believe the type definition is currently incorrect, I've left a comment with a suggested change 👍
Author
|
This is the wrong place to do this as this available to v2 only |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this pull request solving?
Adds a type definition for
waitUntilChecklist
Please add a
xinside each checkbox: