tests

Author: aitchiss

src/e2e/fail-threshold-onpostbuild.test.js

@@ -34,8 +34,8 @@ describe('lighthousePlugin with failed threshold run (onPostBuild)', () => {
 
   it('should output expected log content', async () => {
     const logs = [
-      'Persisting Lighthouse cache...',
-      'Lighthouse cache persisted',
+      'Restoring Lighthouse cache...',
+      'Lighthouse cache restored',
       'Generating Lighthouse report. This may take a minute…',
       'Running Lighthouse on example/',
       'Serving and scanning site from directory example',
@@ -45,6 +45,8 @@ describe('lighthousePlugin with failed threshold run (onPostBuild)', () => {
       '- Best Practices: 100',
       '- SEO: 91',
       '- PWA: 30',
+      'Persisting Lighthouse cache...',
+      'Lighthouse cache persisted',
     ];
 
     await lighthousePlugin({

src/e2e/settings-preset.test.js

@@ -29,6 +29,8 @@ describe('lighthousePlugin with custom device preset', () => {
 
   it('should output expected log content', async () => {
     const logs = [
+      'Restoring Lighthouse cache...',
+      'Lighthouse cache restored',
       'Generating Lighthouse report. This may take a minute…',
       'Running Lighthouse on / using the “desktop” preset',
       'Lighthouse scores for /',
@@ -37,6 +39,8 @@ describe('lighthousePlugin with custom device preset', () => {
       '- Best Practices: 100',
       '- SEO: 91',
       '- PWA: 30',
+      'Persisting Lighthouse cache...',
+      'Lighthouse cache persisted',
     ];
     await lighthousePlugin().onSuccess({ utils: mockUtils });
     expect(formatMockLog(console.log.mock.calls)).toEqual(logs);

src/index.js

@@ -33,7 +33,6 @@ export default function lighthousePlugin(inputs) {
   if (defaultEvent === 'onSuccess') {
     return {
       onSuccess: async ({ constants, utils, inputs } = {}) => {
-        console.log('🚨 LIGHTHOUSE PLUGIN onSuccess invoked');
         await restorePuppeteerCache({ utils });
         // Mock the required `utils` functions if running locally
         const { failPlugin, show } = getUtils({ utils });

src/index.test.js

@@ -2,23 +2,20 @@ import lighthousePlugin from './index.js';
 
 describe('lighthousePlugin plugin events', () => {
   describe('when fail_deploy_on_score_thresholds is true', () => {
-    it('should return onPreBuild and onPostBuild events', async () => {
+    it('should return onPostBuild events', async () => {
       const events = lighthousePlugin({
         fail_deploy_on_score_thresholds: 'true',
       });
       expect(events).toEqual({
-        onPreBuild: expect.any(Function),
         onPostBuild: expect.any(Function),
       });
     });
   });
 
   describe('default behavior', () => {
-    it('should return onPreBuild, onPostBuild and onSuccess events', async () => {
+    it('should return onSuccess event', async () => {
       const events = lighthousePlugin();
       expect(events).toEqual({
-        onPreBuild: expect.any(Function),
-        onPostBuild: expect.any(Function),
         onSuccess: expect.any(Function),
       });
     });