WIP: puppeteer upgraded, working locally onSuccess

Author: aitchiss

package.json

@@ -30,7 +30,7 @@
     "express": "^4.17.1",
     "html-minifier": "^4.0.0",
     "lighthouse": "^9.6.3",
-    "puppeteer": "^18.0.0"
+    "puppeteer": "^24.8.2"
   },
   "engines": {
     "node": ">=18.14.0"

src/lib/run-audit-with-server/index.js

@@ -1,7 +1,7 @@
 import { join } from 'path';
 
 import { formatResults } from '../../format.js';
-import { runLighthouse, getBrowserPath } from '../../run-lighthouse.js';
+import { runLighthouse } from '../../run-lighthouse.js';
 import persistResults from '../persist-results/index.js';
 import getServer from '../get-server/index.js';
 
@@ -16,13 +16,13 @@ const runAuditWithServer = async ({
   try {
     const { server } = getServer({ serveDir: serveDir, auditUrl: url });
 
-    const browserPath = await getBrowserPath();
+
 
     const { error, results } = await new Promise((resolve) => {
       const instance = server.listen(async () => {
         try {
           const fullPath = path ? `${server.url}/${path}` : server.url;
-          const results = await runLighthouse(browserPath, fullPath, settings);
+          const results = await runLighthouse("PLACEHOLDER", fullPath, settings);
           resolve({ error: false, results });
         } catch (error) {
           resolve({ error });

src/lib/run-audit-with-url/index.js

@@ -1,13 +1,11 @@
 import { formatResults } from '../../format.js';
-import { runLighthouse, getBrowserPath } from '../../run-lighthouse.js';
+import { runLighthouse } from '../../run-lighthouse.js';
 
 const runAuditWithUrl = async ({ path = '', url, thresholds, settings }) => {
   try {
-    const browserPath = await getBrowserPath();
-
     const getResults = async () => {
       const fullPath = path ? `${url}/${path}` : url;
-      const results = await runLighthouse(browserPath, fullPath, settings);
+      const results = await runLighthouse(fullPath, settings);
 
       try {
         return { results };
@@ -19,6 +17,7 @@ const runAuditWithUrl = async ({ path = '', url, thresholds, settings }) => {
     const { error, results } = await getResults();
 
     if (error) {
+      console.log("error line 22 run audit with url", error)
       return { error };
     } else {
       const { summary, shortSummary, details, report, errors, runtimeError } =
@@ -37,6 +36,7 @@ const runAuditWithUrl = async ({ path = '', url, thresholds, settings }) => {
       };
     }
   } catch (error) {
+    console.log("error line 41 run audit with url", error)
     return { error };
   }
 };

src/lib/run-event/index.js

@@ -17,7 +17,7 @@ const runEvent = async ({
 } = {}) => {
   const isOnSuccess = event === 'onSuccess';
 
-  const deployUrl = process.env.DEPLOY_URL;
+  const deployUrl = 'https://68244ec43a5a6b46e855abe0--testing-secret-scanning-ui.netlify.app/';
 
   // If we don't have the deploy URL to test against, we can't run Lighthouse onSuccess.
   // If running locally, ensure you have a DEPLOY_URL set in your .env file
@@ -67,6 +67,7 @@ const runEvent = async ({
       });
 
       console.log(startMessage);
+      console.log('*** url', url);
 
       const runner = isOnSuccess ? runAuditWithUrl : runAuditWithServer;
       const { errors, summary, shortSummary, details, report, runtimeError } =

src/run-lighthouse.js

@@ -1,37 +1,41 @@
-import puppeteer from 'puppeteer';
+import puppeteer  from 'puppeteer';
 import lighthouse from 'lighthouse';
 import log from 'lighthouse-logger';
-import chromeLauncher from 'chrome-launcher';
 
-export const getBrowserPath = async () => {
-  const browserFetcher = puppeteer.createBrowserFetcher();
-  const revisions = await browserFetcher.localRevisions();
-  if (revisions.length <= 0) {
-    throw new Error('Could not find local browser');
-  }
-  const info = await browserFetcher.revisionInfo(revisions[0]);
-  return info.executablePath;
-};
+// export const getBrowserPath = async () => {
+//   const browserFetcher = new BrowserFetcher();
+//   const revisions = await browserFetcher.localRevisions();
+//   if (revisions.length <= 0) {
+//     throw new Error('Could not find local browser');
+//   }
+//   const info = await browserFetcher.revisionInfo(revisions[0]);
+//   return info.executablePath;
+// };
 
-export const runLighthouse = async (browserPath, url, settings) => {
+export const runLighthouse = async (url, settings) => {
   let chrome;
   try {
     const logLevel = 'error';
     log.setLevel(logLevel);
-    chrome = await chromeLauncher.launch({
-      chromePath: browserPath,
-      chromeFlags: [
+    chrome = await puppeteer.launch({
+      args: [
         '--headless',
         '--no-sandbox',
         '--disable-gpu',
         '--disable-dev-shm-usage',
+        '--remote-debugging-port=0'
       ],
       logLevel,
     });
+
+    // Get the debugging port from the browser's websocket endpoint
+    const browserWSEndpoint = chrome.wsEndpoint();
+    const port = parseInt(browserWSEndpoint.split(':')[2].split('/')[0], 10);
+
     const results = await lighthouse(
       url,
       {
-        port: chrome.port,
+        port,
         output: 'html',
         logLevel,
       },
@@ -40,7 +44,7 @@ export const runLighthouse = async (browserPath, url, settings) => {
     return results;
   } finally {
     if (chrome) {
-      await chrome.kill();
+      await chrome.close();
     }
   }
 };