fix mocks and tests

Author: aitchiss

src/e2e/fail-threshold-onpostbuild.test.js

@@ -34,6 +34,8 @@ describe('lighthousePlugin with failed threshold run (onPostBuild)', () => {
 
   it('should output expected log content', async () => {
     const logs = [
+      "Persisting Lighthouse cache...",
+     "Lighthouse cache persisted",
       'Generating Lighthouse report. This may take a minute…',
       'Running Lighthouse on example/',
       'Serving and scanning site from directory example',

src/e2e/fixture/utils.js

@@ -6,6 +6,10 @@ const mockUtils = {
   status: {
     show: jest.fn(),
   },
+  cache: {
+    save: jest.fn(),
+    restore: jest.fn(),
+  }
 };
 
 export default mockUtils;

src/e2e/mocks/puppeteer.js

@@ -2,13 +2,10 @@ const puppeteer = () =>
   jest.unstable_mockModule('puppeteer', () => {
     return {
       default: {
-        launch: () => {
-         return { browserPath: 'path' }
-        },
-        createBrowserFetcher: () => ({
-          localRevisions: () => Promise.resolve(['123']),
-          revisionInfo: () => Promise.resolve({ executablePath: 'path' }),
-        }),
+        launch: () => ({
+          process: () => ({ spawnfile: 'path' }),
+          close: () => Promise.resolve()
+        })
       },
     };
   });

src/e2e/not-found-onpostbuild.test.js

@@ -25,6 +25,8 @@ describe('lighthousePlugin with single not-found run (onPostBuild)', () => {
 
   it('should output expected log content', async () => {
     const logs = [
+      "Persisting Lighthouse cache...",
+      "Lighthouse cache persisted",
       'Generating Lighthouse report. This may take a minute…',
       'Running Lighthouse on example/this-page-does-not-exist',
       'Serving and scanning site from directory example',

src/e2e/success-onpostbuild.test.js

@@ -24,6 +24,8 @@ describe('lighthousePlugin with single report per run (onPostBuild)', () => {
 
   it('should output expected log content', async () => {
     const logs = [
+      "Persisting Lighthouse cache...",
+      "Lighthouse cache persisted",
       'Generating Lighthouse report. This may take a minute…',
       'Running Lighthouse on example/',
       'Serving and scanning site from directory example',

src/index.test.js

@@ -1,22 +1,25 @@
 import lighthousePlugin from './index.js';
 
 describe('lighthousePlugin plugin events', () => {
-  describe('onPostBuild', () => {
-    it('should return only the expected event function', async () => {
+  describe('when fail_deploy_on_score_thresholds is true', () => {
+    it('should return onPreBuild and onPostBuild events', async () => {
       const events = lighthousePlugin({
         fail_deploy_on_score_thresholds: 'true',
       });
       expect(events).toEqual({
-        onPostBuild: expect.any(Function),
+        onPreBuild: expect.any(Function),
+        onPostBuild: expect.any(Function)
       });
     });
   });
 
-  describe('onSuccess', () => {
-    it('should return only the expected event function', async () => {
+  describe('default behavior', () => {
+    it('should return onPreBuild, onPostBuild and onSuccess events', async () => {
       const events = lighthousePlugin();
       expect(events).toEqual({
-        onSuccess: expect.any(Function),
+        onPreBuild: expect.any(Function),
+        onPostBuild: expect.any(Function),
+        onSuccess: expect.any(Function)
       });
     });
   });