fix test mocks

Author: aitchiss

src/e2e/mocks/puppeteer.js

@@ -2,9 +2,9 @@ const puppeteer = () =>
   jest.unstable_mockModule('puppeteer', () => {
     return {
       default: {
-        createBrowserFetcher: () => ({
-          localRevisions: () => Promise.resolve(['123']),
-          revisionInfo: () => Promise.resolve({ executablePath: 'path' }),
+        launch: () => Promise.resolve({
+          wsEndpoint: () => 'ws://127.0.0.1:9222/devtools/browser/xyz',
+          close: () => Promise.resolve(),
         }),
       },
     };

src/lib/run-audit-with-server/index.js

@@ -1,7 +1,7 @@
 import { join } from 'path';
 
 import { formatResults } from '../../format.js';
-import { runLighthouse, getBrowserPath } from '../../run-lighthouse.js';
+import { runLighthouse } from '../../run-lighthouse.js';
 import persistResults from '../persist-results/index.js';
 import getServer from '../get-server/index.js';
 
@@ -16,13 +16,11 @@ const runAuditWithServer = async ({
   try {
     const { server } = getServer({ serveDir: serveDir, auditUrl: url });
 
-    const browserPath = await getBrowserPath();
-
     const { error, results } = await new Promise((resolve) => {
       const instance = server.listen(async () => {
         try {
           const fullPath = path ? `${server.url}/${path}` : server.url;
-          const results = await runLighthouse(browserPath, fullPath, settings);
+          const results = await runLighthouse(fullPath, settings);
           resolve({ error: false, results });
         } catch (error) {
           resolve({ error });

src/lib/run-event/index.js

@@ -17,8 +17,7 @@ const runEvent = async ({
 } = {}) => {
   const isOnSuccess = event === 'onSuccess';
 
-  const deployUrl =
-    'https://68244ec43a5a6b46e855abe0--testing-secret-scanning-ui.netlify.app/';
+  const deployUrl = process.env.DEPLOY_URL;
 
   // If we don't have the deploy URL to test against, we can't run Lighthouse onSuccess.
   // If running locally, ensure you have a DEPLOY_URL set in your .env file
@@ -68,7 +67,6 @@ const runEvent = async ({
       });
 
       console.log(startMessage);
-      console.log('*** url', url);
 
       const runner = isOnSuccess ? runAuditWithUrl : runAuditWithServer;
       const { errors, summary, shortSummary, details, report, runtimeError } =

src/run-lighthouse.js

@@ -2,18 +2,13 @@ import puppeteer from 'puppeteer';
 import lighthouse from 'lighthouse';
 import log from 'lighthouse-logger';
 
-export const getBrowserPath = async () => {
-  // In newer Puppeteer versions, we can get the executable path directly
-  return puppeteer.executablePath();
-};
 
-export const runLighthouse = async (browserPath, url, settings) => {
+export const runLighthouse = async (url, settings) => {
   let chrome;
   try {
     const logLevel = 'error';
     log.setLevel(logLevel);
     chrome = await puppeteer.launch({
-      executablePath: browserPath,
       args: [
         '--headless',
         '--no-sandbox',