chore(tests): Add node 19.x to the test matrix to support the current node version (#551)

* Add node 19.x to the test matrix to support the current node version

* fix: test support for node 19

This commit fixes the test support specifically for get-configuration.test.js, because node 19 and up use different Error messages for JSON parsing errors.
This commit adds a special case for node 19 and up, changing the expected error message.

Signed-off-by: Raphael Höser <[email protected]>

* Chore: refactor tests for node 19 support
Instead of making an explicit version check, just test for the important part of the error message.

* Fix: prettier issues

Signed-off-by: Raphael Höser <[email protected]>

* Fix: unittest error string for failed audits inputs.

Signed-off-by: Raphael Höser <[email protected]>

---------

Signed-off-by: Raphael Höser <[email protected]>

Author: Snapstromegon

.github/workflows/test.yml

@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [14.x, 16.x, 18.x]
+        node-version: [14.x, 16.x, 18.x, 19.x]
 
     steps:
       - uses: actions/checkout@v3

package-lock.json

@@ -32,7 +32,7 @@
     "puppeteer": "^18.0.0"
   },
   "engines": {
-    "node": ">=14.15 <19"
+    "node": ">=14.15 <20"
   },
   "type": "module",
   "repository": {

package.json

@@ -168,9 +168,7 @@ describe('config', () => {
     };
 
     expect(() => getConfiguration({ constants, inputs })).toThrow(
-      new Error(
-        `Invalid JSON for 'thresholds' input: Unexpected token i in JSON at position 0`,
-      ),
+      /Invalid JSON for 'thresholds' input/,
     );
   });
 
@@ -182,9 +180,7 @@ describe('config', () => {
     };
 
     expect(() => getConfiguration({ constants, inputs })).toThrow(
-      new Error(
-        `Invalid JSON for 'audits' input: Unexpected token i in JSON at position 0`,
-      ),
+      /Invalid JSON for 'audits' input/,
     );
   });