Skip to content

Commit 21a7d9c

Browse files
authored
Merge pull request #109 from netlify/not-save-in-hashed
Save sha without original sha when to save in Hashed
2 parents bccec77 + 2af0664 commit 21a7d9c

File tree

2 files changed

+34
-2
lines changed

2 files changed

+34
-2
lines changed

go/porcelain/deploy.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,13 @@ func newDeployFiles() *deployFiles {
121121
func (d *deployFiles) Add(p string, f *FileBundle) {
122122
d.Files[p] = f
123123
d.Sums[p] = f.Sum
124-
list, _ := d.Hashed[f.Sum]
125-
d.Hashed[f.Sum] = append(list, f)
124+
// Remove ":original_sha" part when to save in Hashed (asset management)
125+
sum := f.Sum
126+
if strings.Contains(sum, ":") {
127+
sum = strings.Split(sum, ":")[0]
128+
}
129+
list, _ := d.Hashed[sum]
130+
d.Hashed[sum] = append(list, f)
126131
}
127132

128133
func (n *Netlify) overCommitted(d *deployFiles) bool {

go/porcelain/deploy_test.go

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,3 +24,30 @@ func TestGetAssetManagementSha(t *testing.T) {
2424
}
2525
}
2626
}
27+
28+
func TestAddWithAssetManagement(t *testing.T) {
29+
files := newDeployFiles()
30+
tests := []struct {
31+
rel string
32+
sum string
33+
}{
34+
{"foo.jpg", "sum1"},
35+
{"bar.jpg", "sum2"},
36+
{"baz.jpg", "sum3:originalsha"},
37+
}
38+
39+
for _, test := range tests {
40+
file := &FileBundle{}
41+
file.Sum = test.sum
42+
files.Add(test.rel, file)
43+
}
44+
45+
out := files.Hashed["sum3"]
46+
if len(out) != 1 {
47+
t.Fatalf("expected `%d`, got `%d`", 1, len(out))
48+
}
49+
out2 := files.Sums["baz.jpg"]
50+
if out2 != "sum3:originalsha" {
51+
t.Fatalf("expected `%v`, got `%v`", "sum3:originalsha", out2)
52+
}
53+
}

0 commit comments

Comments
 (0)