Skip to content

Commit 59cf06d

Browse files
authored
Merge pull request #522 from hereje/refactor/replace-mkdir-with-fs-mkdir
refactor: replace promisify with fs/promises version on convert.js
2 parents 54de2e6 + 551cbc0 commit 59cf06d

File tree

3 files changed

+33
-47
lines changed

3 files changed

+33
-47
lines changed

package-lock.json

Lines changed: 27 additions & 39 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,9 @@
1111
"bugs": {
1212
"url": "https://github.com/netlify/open-api/issues"
1313
},
14+
"engines": {
15+
"node": ">=14"
16+
},
1417
"devDependencies": {
1518
"@redocly/cli": "^1.0.0-beta.128",
1619
"analytics": "^0.2.0",
@@ -24,7 +27,6 @@
2427
"eslint-plugin-prettier": "^4.2.1",
2528
"execa": "^2.0.4",
2629
"is-plain-obj": "^2.1.0",
27-
"make-dir": "^3.0.0",
2830
"npm-run-all": "^4.1.5",
2931
"prettier": "^2.8.7",
3032
"swagger-parser": "^8.0.1",

src/convert.js

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
const { writeFile } = require('fs')
2-
const { promisify } = require('util')
1+
const { writeFile, mkdir } = require('fs/promises')
32

43
const SwaggerParser = require('swagger-parser')
5-
const makeDir = require('make-dir')
6-
7-
const pWriteFile = promisify(writeFile)
84

95
const YAML_INPUT = `${__dirname}/../swagger.yml`
106
const OUTPUT_DIR = `${__dirname}/../dist`
@@ -15,10 +11,10 @@ const JSON_OUTPUT = `${OUTPUT_DIR}/swagger.json`
1511
const convertOpenApi = async function () {
1612
const [openapiDef] = await Promise.all([
1713
SwaggerParser.validate(YAML_INPUT, { dereference: { circular: false } }),
18-
makeDir(OUTPUT_DIR),
14+
mkdir(OUTPUT_DIR, { recursive: true }),
1915
])
2016
const openapiJson = JSON.stringify(openapiDef, null, 2)
21-
await pWriteFile(JSON_OUTPUT, openapiJson)
17+
await writeFile(JSON_OUTPUT, openapiJson)
2218
}
2319

2420
convertOpenApi()

0 commit comments

Comments
 (0)