Add more assertions to ListFormsBySiteId test

Author: FawazFarid

go/porcelain/forms_test.go

@@ -11,13 +11,26 @@ import (
 	apiClient "github.com/go-openapi/runtime/client"
 	"github.com/go-openapi/strfmt"
 	apiContext "github.com/netlify/open-api/go/porcelain/context"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
 func TestListFormsBySiteId(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
 		rw.Header().Set("Content-Type", "application/json; charset=utf-8")
-		rw.Write([]byte(`[]`))
+		rw.Write([]byte(`
+			[
+				{
+					"id": "1",
+					"site_id": "123",
+					"name": "contact",
+					"paths": [],
+					"submission_count": 0,
+					"fields": [],
+					"created_at": ""
+				}
+			]`))
+		assert.Equal(t, "/api/v1/sites/123/forms", req.URL.String())
 	}))
 	defer server.Close()
 
@@ -33,6 +46,7 @@ func TestListFormsBySiteId(t *testing.T) {
 	require.NoError(t, err)
 	tr := apiClient.NewWithClient(parsedURL.Host, "/api/v1", []string{"http"}, httpClient)
 	client := NewRetryable(tr, strfmt.Default, 1)
-	_, err = client.ListFormsBySiteId(apiContext.WithAuthInfo(context.Background(), authInfo), "123")
+	forms, err := client.ListFormsBySiteId(apiContext.WithAuthInfo(context.Background(), authInfo), "123")
 	require.NoError(t, err)
+	assert.Equal(t, len(forms), 1)
 }