Use a local copy of client

vbrown608 · vbrown608 · commit c065ece90f03 · 2020-05-07T12:26:18.000-07:00
diff --git a/go/porcelain/http/http.go b/go/porcelain/http/http.go
@@ -31,11 +31,11 @@ func NewRetryableTransport(tr runtime.ClientTransport, attempts int) *RetryableT
 }
 
 func (t *RetryableTransport) Submit(op *runtime.ClientOperation) (interface{}, error) {
-	client := &http.Client{}
+	var client http.Client
 	if op.Client == nil {
-		*client = *http.DefaultClient
+		client = *http.DefaultClient
 	} else {
-		*client = *op.Client
+		client = *op.Client
 	}
 
 	transport := client.Transport
@@ -47,7 +47,7 @@ func (t *RetryableTransport) Submit(op *runtime.ClientOperation) (interface{}, e
 		attempts: t.attempts,
 	}
 
-	op.Client = client
+	op.Client = &client
 	res, err := t.tr.Submit(op)
 
 	return res, err

Original file line number	Diff line number	Diff line change
`@@ -31,11 +31,11 @@ func NewRetryableTransport(tr runtime.ClientTransport, attempts int) *RetryableT`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`func (t RetryableTransport) Submit(op runtime.ClientOperation) (interface{}, error) {`
`34`		`- client := &http.Client{}`
	`34`	`+ var client http.Client`
`35`	`35`	`if op.Client == nil {`
`36`		`- client = http.DefaultClient`
	`36`	`+ client = *http.DefaultClient`
`37`	`37`	`} else {`
`38`		`- client = op.Client`
	`38`	`+ client = *op.Client`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`transport := client.Transport`
`@@ -47,7 +47,7 @@ func (t RetryableTransport) Submit(op runtime.ClientOperation) (interface{}, e`
`47`	`47`	`attempts: t.attempts,`
`48`	`48`	`}`
`49`	`49`
`50`		`- op.Client = client`
	`50`	`+ op.Client = &client`
`51`	`51`	`res, err := t.tr.Submit(op)`
`52`	`52`
`53`	`53`	`return res, err`