improvements

Author: leandroberetta

docs/api.md

@@ -323,11 +323,8 @@ Following is the supported API format for writing to loki:
          timestampScale: timestamp units scale (e.g. for UNIX = 1s)
          format: the format of each line: printf (writes using golang's default map printing), fields (writes one key and value field per line) or json (default)
          reorder: reorder json map keys
-         clientType: type of client to use: 'http' or 'grpc' (default: 'http')
-         grpcConfig: gRPC client configuration (used only for gRPC client type)
-             serverAddress: gRPC server address (host:port)
-             maxRecvMsgSize: maximum message size the client can receive
-             maxSendMsgSize: maximum message size the client can send
+         clientProtocol: type of client protocol to use: 'http' or 'grpc' (default: 'http')
+         grpcConfig: gRPC client configuration (used only for gRPC client protocol)
              keepAlive: keep alive interval
              keepAliveTimeout: keep alive timeout
              tls: TLS configuration

go.mod

@@ -176,4 +176,4 @@ require (
 
 replace github.com/vmware/go-ipfix => github.com/jotak/go-ipfix v0.0.0-20250708115123-407c539ea101
 
-replace github.com/netobserv/loki-client-go => github.com/leandroberetta/loki-client-go v0.0.0-20250923004934-a3e68fd6a596
+replace github.com/netobserv/loki-client-go => github.com/leandroberetta/loki-client-go v0.0.0-20250924145641-591b5499691d

go.sum

@@ -206,8 +206,8 @@ github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
 github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
 github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0SNc=
 github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
-github.com/leandroberetta/loki-client-go v0.0.0-20250923004934-a3e68fd6a596 h1:FhZHtZsaCa4LMhgTrU+eM1iTnl2X1L1yrSRQjGHiJOo=
-github.com/leandroberetta/loki-client-go v0.0.0-20250923004934-a3e68fd6a596/go.mod h1:Zb/jtD3Lnu88Poo+jnhTASzxYnvncmHOoZaT93xQjJ8=
+github.com/leandroberetta/loki-client-go v0.0.0-20250924145641-591b5499691d h1:qXM2SFkp1qzHcvrfPMleIkmEF2lVyKr1PQcpyCMbDWE=
+github.com/leandroberetta/loki-client-go v0.0.0-20250924145641-591b5499691d/go.mod h1:Zb/jtD3Lnu88Poo+jnhTASzxYnvncmHOoZaT93xQjJ8=
 github.com/libp2p/go-reuseport v0.4.0 h1:nR5KU7hD0WxXCJbmw7r2rhRYruNRl2koHw8fQscQm2s=
 github.com/libp2p/go-reuseport v0.4.0/go.mod h1:ZtI03j/wO5hZVDFo2jKywN6bYKWLOy8Se6DrI2E1cLU=
 github.com/mailru/easyjson v0.9.0 h1:PrnmzHw7262yW8sTBwxi1PdJA3Iw/EKBa8psRf7d9a4=

pkg/api/write_loki.go

@@ -48,15 +48,12 @@ type WriteLoki struct {
 	Format         string `yaml:"format,omitempty" json:"format,omitempty" doc:"the format of each line: printf (writes using golang's default map printing), fields (writes one key and value field per line) or json (default)"`
 	Reorder        bool   `yaml:"reorder,omitempty" json:"reorder,omitempty" doc:"reorder json map keys"`
 
-	// Client type selection
-	ClientType string          `yaml:"clientType,omitempty" json:"clientType,omitempty" doc:"type of client to use: 'http' or 'grpc' (default: 'http')"`
+	// Client protocol selection
+	ClientProtocol string          `yaml:"clientProtocol,omitempty" json:"clientProtocol,omitempty" doc:"type of client protocol to use: 'http' or 'grpc' (default: 'http')"`
 	GRPCConfig *GRPCLokiConfig `yaml:"grpcConfig,omitempty" json:"grpcConfig,omitempty" doc:"gRPC client configuration (used only for gRPC client type)"`
 }
 
 type GRPCLokiConfig struct {
-	ServerAddress    string         `yaml:"serverAddress,omitempty" json:"serverAddress,omitempty" doc:"gRPC server address (host:port)"`
-	MaxRecvMsgSize   int            `yaml:"maxRecvMsgSize,omitempty" json:"maxRecvMsgSize,omitempty" doc:"maximum message size the client can receive"`
-	MaxSendMsgSize   int            `yaml:"maxSendMsgSize,omitempty" json:"maxSendMsgSize,omitempty" doc:"maximum message size the client can send"`
 	KeepAlive        string         `yaml:"keepAlive,omitempty" json:"keepAlive,omitempty" doc:"keep alive interval"`
 	KeepAliveTimeout string         `yaml:"keepAliveTimeout,omitempty" json:"keepAliveTimeout,omitempty" doc:"keep alive timeout"`
 	TLS              *GRPCTLSConfig `yaml:"tls,omitempty" json:"tls,omitempty" doc:"TLS configuration"`
@@ -99,23 +96,17 @@ func (w *WriteLoki) SetDefaults() {
 	if w.Format == "" {
 		w.Format = "json"
 	}
-	if w.ClientType == "" {
-		w.ClientType = "http"
+	if w.ClientProtocol == "" {
+		w.ClientProtocol = "http"
 	}
 
-	// Set defaults for gRPC config if gRPC client type is selected
-	if w.ClientType == "grpc" && w.GRPCConfig != nil {
+	// Set defaults for gRPC config if gRPC client protocol is selected
+	if w.ClientProtocol == "grpc" && w.GRPCConfig != nil {
 		w.GRPCConfig.SetDefaults()
 	}
 }
 
 func (g *GRPCLokiConfig) SetDefaults() {
-	if g.MaxRecvMsgSize == 0 {
-		g.MaxRecvMsgSize = 1024 * 1024 * 64 // 64MB
-	}
-	if g.MaxSendMsgSize == 0 {
-		g.MaxSendMsgSize = 1024 * 1024 * 16 // 16MB
-	}
 	if g.KeepAlive == "" {
 		g.KeepAlive = "30s"
 	}
@@ -135,20 +126,23 @@ func (w *WriteLoki) Validate() error {
 		return fmt.Errorf("invalid batchSize: %v. Required > 0", w.BatchSize)
 	}
 
-	// Validate client type
-	if w.ClientType != "" && w.ClientType != "http" && w.ClientType != "grpc" {
-		return fmt.Errorf("invalid clientType: %s. Must be 'http' or 'grpc'", w.ClientType)
+	// Validate client protocol
+	if w.ClientProtocol != "" && w.ClientProtocol != "http" && w.ClientProtocol != "grpc" {
+		return fmt.Errorf("invalid clientProtocol: %s. Must be 'http' or 'grpc'", w.ClientProtocol)
 	}
 
-	// Validate based on client type
-	switch w.ClientType {
+	// Validate based on client protocol
+	switch w.ClientProtocol {
 	case "http", "":
 		if w.URL == "" {
 			return errors.New("url can't be empty for HTTP client")
 		}
 	case "grpc":
+		if w.URL == "" {
+			return errors.New("url can't be empty for gRPC client")
+		}
 		if w.GRPCConfig == nil {
-			return errors.New("grpcConfig is required when using gRPC client type")
+			return errors.New("grpcConfig is required when using gRPC client protocol")
 		}
 		if err := w.GRPCConfig.Validate(); err != nil {
 			return fmt.Errorf("gRPC config validation failed: %w", err)
@@ -162,10 +156,6 @@ func (g *GRPCLokiConfig) Validate() error {
 	if g == nil {
 		return errors.New("gRPC config cannot be nil")
 	}
-	if g.ServerAddress == "" {
-		return errors.New("gRPC serverAddress cannot be empty")
-	}
-
 	// Validate duration fields
 	if g.KeepAlive != "" {
 		if _, err := time.ParseDuration(g.KeepAlive); err != nil {

pkg/pipeline/write/write_loki.go

@@ -62,13 +62,13 @@ type Loki struct {
 }
 
 func createLokiClient(c *api.WriteLoki) (emitter, error) {
-	switch c.ClientType {
+	switch c.ClientProtocol {
 	case "grpc":
 		return createGRPCClient(c)
 	case "http", "":
 		return createHTTPClient(c)
 	default:
-		return nil, fmt.Errorf("unsupported client type: %s", c.ClientType)
+		return nil, fmt.Errorf("unsupported client protocol: %s", c.ClientProtocol)
 	}
 }
 
@@ -146,7 +146,7 @@ func buildHTTPLokiConfig(c *api.WriteLoki) (loki.Config, error) {
 
 func buildGRPCLokiConfig(c *api.WriteLoki) (grpc.Config, error) {
 	if c.GRPCConfig == nil {
-		return grpc.Config{}, fmt.Errorf("gRPC config is required for gRPC client type")
+		return grpc.Config{}, fmt.Errorf("gRPC config is required for gRPC client protocol")
 	}
 
 	batchWait, err := time.ParseDuration(c.BatchWait)
@@ -180,13 +180,11 @@ func buildGRPCLokiConfig(c *api.WriteLoki) (grpc.Config, error) {
 	}
 
 	cfg := grpc.Config{
-		ServerAddress:    c.GRPCConfig.ServerAddress,
+		ServerAddress:    c.URL,
 		TenantID:         c.TenantID,
 		BatchWait:        batchWait,
 		BatchSize:        c.BatchSize,
 		Timeout:          timeout,
-		MaxRecvMsgSize:   c.GRPCConfig.MaxRecvMsgSize,
-		MaxSendMsgSize:   c.GRPCConfig.MaxSendMsgSize,
 		KeepAlive:        keepAlive,
 		KeepAliveTimeout: keepAliveTimeout,
 		BackoffConfig: backoff.BackoffConfig{
@@ -330,7 +328,7 @@ func NewWriteLoki(opMetrics *operational.Metrics, params config.StageParam) (*Lo
 		return nil, fmt.Errorf("the provided config is not valid: %w", err)
 	}
 
-	// Create the appropriate client based on clientType
+	// Create the appropriate client based on clientProtocol
 	client, err := createLokiClient(&lokiConfigIn)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create Loki client: %w", err)