verbose errors

Author: jotak

pkg/dsl/eval_test.go

@@ -8,7 +8,6 @@ import (
 )
 
 func TestAndOrEqual(t *testing.T) {
-	yyErrorVerbose = true
 	predicate, err := Parse(`(srcnamespace="netobserv" OR (srcnamespace="ingress" AND dstnamespace="netobserv")) AND srckind!="service"`)
 	assert.NoError(t, err)
 	assert.NotNil(t, predicate)
@@ -36,7 +35,6 @@ func TestAndOrEqual(t *testing.T) {
 }
 
 func TestRegexp(t *testing.T) {
-	yyErrorVerbose = true
 	predicate, err := Parse(`srcnamespace=~"openshift.*" and dstnamespace!~"openshift.*"`)
 	assert.NoError(t, err)
 	assert.NotNil(t, predicate)
@@ -71,7 +69,6 @@ func TestRegexp(t *testing.T) {
 }
 
 func TestWith(t *testing.T) {
-	yyErrorVerbose = true
 	predicate, err := Parse(`srcnamespace="foo" and with(rtt)`)
 	assert.NoError(t, err)
 	assert.NotNil(t, predicate)
@@ -89,7 +86,6 @@ func TestWith(t *testing.T) {
 }
 
 func TestWithout(t *testing.T) {
-	yyErrorVerbose = true
 	predicate, err := Parse(`srcnamespace="foo" or without(srcnamespace)`)
 	assert.NoError(t, err)
 	assert.NotNil(t, predicate)

pkg/dsl/lexer.go

@@ -173,6 +173,7 @@ func (l *Lexer) Error(msg string) {
 func Parse(s string) (filters.Predicate, error) {
 	l := new(Lexer)
 	l.Init(strings.NewReader(s))
+	yyErrorVerbose = true
 	yyParse(l)
 	if len(l.errs) > 0 {
 		return nil, errors.Join(l.errs...)