Skip to content

Commit hash is always added to reported version in log #539

@ronensc

Description

@ronensc

When FLP starts, it reports its build version, and the current format is always including the commit hash, even when it wasn't originally planned that way.

For example:

$ ./flowlogs-pipeline

Starting flowlogs-pipeline:
=====
Build Version: 0.1.10-7c78d63b-dirty
Build Date: 2023-11-20 12:09

It seems that the original plan was to have the following format:

<tag>[-<sha>][-dirty]

<tag>: The name of the most recent tag (stripping the prefix 'v')
<sha>: If HEAD is not pointed to a tag, then the hash of HEAD is added.
dirty: If the repository contains any changes, "-dirty" is added.

But since #426, this condition always evaluates as true, resuling in the addition of -<sha> in all cases. Do we want to keep it this way?

Same is true to the other components:
network-observability-operator

netobserv-ebpf-agent

network-observability-console-plugin

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions