-
Notifications
You must be signed in to change notification settings - Fork 34
Closed
Description
When FLP starts, it reports its build version, and the current format is always including the commit hash, even when it wasn't originally planned that way.
For example:
$ ./flowlogs-pipeline
Starting flowlogs-pipeline:
=====
Build Version: 0.1.10-7c78d63b-dirty
Build Date: 2023-11-20 12:09
It seems that the original plan was to have the following format:
<tag>[-<sha>][-dirty]
<tag>: The name of the most recent tag (stripping the prefix 'v')
<sha>: If HEAD is not pointed to a tag, then the hash of HEAD is added.
dirty: If the repository contains any changes, "-dirty" is added.
But since #426, this condition always evaluates as true, resuling in the addition of -<sha> in all cases. Do we want to keep it this way?
Same is true to the other components:
network-observability-operator
Metadata
Metadata
Assignees
Labels
No labels