Skip to content

Commit f7c7888

Browse files
jpinsonneaujotak
andauthored
fix args and version (#199)
* fix fix fix * Update Dockerfile.downstream Co-authored-by: Joel Takvorian <[email protected]> --------- Co-authored-by: Joel Takvorian <[email protected]>
1 parent 615f554 commit f7c7888

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

Dockerfile.downstream

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
# We do not use --platform feature to auto fill this ARG because of incompatibility between podman and docker
2-
ARG TARGETARCH=amd64
2+
ARG TARGETARCH
33
ARG COMMIT
4-
ARG IMAGE=registry.redhat.io/network-observability/network-observability-ebpf-agent-rhel9:1.8
5-
ARG AGENT_IMAGE=registry.redhat.io/network-observability/network-observability-ebpf-agent-rhel9:1.8
64

75
# Make kubectl & oc scripts available for copy
86
FROM registry.redhat.io/openshift4/ose-cli-rhel9:v4.18.0-202502040032.p0.ga50d4c0.assembly.stream.el9 as ose-cli
97

108
# Build the manager binary
119
FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.23 as builder
1210

13-
ARG TARGETARCH
11+
ARG TARGETARCH=amd64
12+
ARG COMMIT
1413
ARG BUILDVERSION="1.8.0"
14+
ARG IMAGE=registry.redhat.io/network-observability/network-observability-cli-rhel9:1.8
15+
ARG AGENT_IMAGE=registry.redhat.io/network-observability/network-observability-ebpf-agent-rhel9:1.8
1516

1617
WORKDIR /opt/app-root
1718

@@ -33,13 +34,17 @@ COPY Makefile Makefile
3334
COPY .mk/ .mk/
3435

3536
# Embed commands in case users want to pull it from collector image
36-
RUN USER=netobserv VERSION=main IMAGE="$IMAGE" AGENT_IMAGE="$AGENT_IMAGE" make oc-commands
37+
RUN USER=netobserv VERSION="$BUILDVERSION" IMAGE="$IMAGE" AGENT_IMAGE="$AGENT_IMAGE" make oc-commands
3738

3839
# Prepare output dir
3940
RUN mkdir -p output
4041

4142
# Create final image from ubi + built binary and command
4243
FROM --platform=linux/$TARGETARCH registry.access.redhat.com/ubi9/ubi:9.5-1739751568
44+
45+
ARG COMMIT
46+
ARG BUILDVERSION="1.8.0"
47+
4348
WORKDIR /
4449

4550
COPY --from=builder /opt/app-root/build .

0 commit comments

Comments
 (0)