Use go 1.24 and golangci-lint v2 (#927)

Author: jotak

.github/workflows/pull_request.yml

@@ -8,25 +8,21 @@ jobs:
   build-test-backend:
     name: Build, lint, test backend
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        go: ['1.23']
 
     steps:
     - name: install make
       run: sudo apt-get install make
     - name: set up go 1.x
       uses: actions/setup-go@v3
       with:
-        go-version: ${{ matrix.go }}
+        go-version: '1.24'
     - name: checkout
       uses: actions/checkout@v3
     - name: build, lint, test
       run: make backend && git diff --exit-code
     - name: check clean vendors
       run: go mod vendor
     - name: Report coverage
-      if: ${{ matrix.go == '1.23' }}
       uses: codecov/codecov-action@v4
       with:
         files: ./cover.out

.github/workflows/push_image.yml

@@ -13,16 +13,13 @@ jobs:
   push-image:
     name: push image
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        go: ['1.23']
     steps:
       - name: install make
         run: sudo apt-get install make
       - name: set up go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: ${{ matrix.go }}
+          go-version: '1.24'
       - name: checkout
         uses: actions/checkout@v3
       - name: docker login to quay.io
@@ -47,16 +44,13 @@ jobs:
   codecov-back:
     name: Codecov backend upload
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        go: ['1.23']
     steps:
     - name: install make
       run: sudo apt-get install make
     - name: set up go 1.x
       uses: actions/setup-go@v3
       with:
-        go-version: ${{ matrix.go }}
+        go-version: '1.24'
     - name: checkout
       uses: actions/checkout@v3
     - name: Test

.github/workflows/push_image_pr.yml

@@ -14,16 +14,13 @@ jobs:
     if: ${{ github.event.label.name == 'ok-to-test' }}
     name: push PR image
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        go: ['1.23']
     steps:
       - name: install make
         run: sudo apt-get install make
       - name: set up go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: ${{ matrix.go }}
+          go-version: '1.24'
       - name: checkout
         uses: actions/checkout@v3
         with:

.github/workflows/release.yml

@@ -12,9 +12,6 @@ jobs:
   push-image:
     name: push image
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        go: ['1.23']
     steps:
       - name: checkout
         uses: actions/checkout@v3
@@ -34,7 +31,7 @@ jobs:
       - name: set up go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: ${{ matrix.go }}
+          go-version: '1.24'
       - name: docker login to quay.io
         uses: docker/login-action@v2
         with:

.golangci.yml

@@ -1,32 +1,59 @@
+version: "2"
+run:
+  go: "1.23"
 linters:
   enable:
-    - errcheck
-    - errorlint
+    - copyloopvar
     - cyclop
+    - errcheck
     - errname
+    - errorlint
     - exhaustive
-    - copyloopvar
     - gocritic
-    - gofmt
-    - gosimple
     - govet
     - ineffassign
     - revive
     - staticcheck
-    - stylecheck
-    - typecheck
     - unused
-run:
-  go: "1.22"
-linters-settings:
-  gocritic:
-    enabled-checks:
-      - hugeParam
-      - rangeExprCopy
-      - rangeValCopy
-      - indexAlloc
-    settings:
-      ifElseChain:
-        minThreshold: 3
-  cyclop:
-    max-complexity: 20
+  settings:
+    cyclop:
+      max-complexity: 20
+    gocritic:
+      enabled-checks:
+        - hugeParam
+        - rangeExprCopy
+        - rangeValCopy
+        - indexAlloc
+      settings:
+        ifElseChain:
+          minThreshold: 3
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+    rules:
+      - linters:
+        - staticcheck
+        text: "QF1003:"
+      - linters:
+        - staticcheck
+        text: "QF1008:"
+      - linters:
+        - revive
+        text: "avoid meaningless package names"
+formatters:
+  enable:
+    - gofmt
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Dockerfile

@@ -1,25 +1,7 @@
-ARG TARGETARCH
-FROM docker.io/library/node:22-alpine as web-builder
-
-USER node
-
-ARG BUILDSCRIPT
-WORKDIR /opt/app-root
-
-COPY --chown=node web/package.json web/package.json
-COPY --chown=node web/package-lock.json web/package-lock.json
-WORKDIR /opt/app-root/web
-RUN CYPRESS_INSTALL_BINARY=0 npm --legacy-peer-deps ci
+FROM localhost/local-front-build:latest as web-builder
 
-WORKDIR /opt/app-root
-COPY --chown=node web web
-COPY mocks mocks
-
-WORKDIR /opt/app-root/web
-RUN npm run format-all
-RUN npm run build$BUILDSCRIPT
-
-FROM docker.io/library/golang:1.23 as go-builder
+ARG TARGETARCH
+FROM docker.io/library/golang:1.24 as go-builder
 
 ARG TARGETARCH=amd64
 ARG LDFLAGS

Dockerfile.ci

@@ -1,4 +1,4 @@
-FROM docker.io/library/golang:1.23
+FROM docker.io/library/golang:1.24
 
 RUN apt-get update && apt-get install -y \
     nodejs \

Dockerfile.cypress

@@ -20,7 +20,7 @@ WORKDIR /opt/app-root/web
 RUN npm run format-all
 RUN npm run build$BUILDSCRIPT
 
-FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.23 as go-builder
+FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.24 as go-builder
 
 ARG LDFLAGS
 WORKDIR /opt/app-root

Dockerfile.downstream

@@ -18,7 +18,7 @@ WORKDIR /opt/app-root/web
 RUN npm run format-all
 RUN npm run build
 
-FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.23 as go-builder
+FROM brew.registry.redhat.io/rh-osbs/openshift-golang-builder:v1.24 as go-builder
 
 ARG BUILDVERSION
 

Dockerfile.front

@@ -0,0 +1,23 @@
+FROM docker.io/library/node:22-alpine as web-builder
+
+USER node
+
+ARG BUILDSCRIPT
+WORKDIR /opt/app-root
+
+COPY --chown=node web/package-lock.json web/package-lock.json
+COPY --chown=node web/package.json web/package.json
+WORKDIR /opt/app-root/web
+RUN CYPRESS_INSTALL_BINARY=0 npm --legacy-peer-deps ci
+
+WORKDIR /opt/app-root
+COPY --chown=node web web
+COPY mocks mocks
+
+WORKDIR /opt/app-root/web
+RUN npm run format-all
+RUN npm run build$BUILDSCRIPT
+
+FROM scratch
+
+COPY --from=web-builder /opt/app-root/web/dist /opt/app-root/web/dist