add show empty checkbox

Author: jpinsonneau

web/locales/en/plugin__netobserv-plugin.json

@@ -151,6 +151,7 @@
   "Edges": "Edges",
   "Edges label": "Edges label",
   "Badges": "Badges",
+  "Empty": "Empty",
   "Collapse groups": "Collapse groups",
   "XL": "XL",
   "L": "L",

web/src/components/dropdowns/topology-display-options.tsx

@@ -191,6 +191,18 @@ export const TopologyDisplayOptions: React.FC<TopologyDisplayOptionsProps> = ({
             })
           }
         />
+        <Checkbox
+          id="empty-switch"
+          className="display-dropdown-padding"
+          label={t('Empty')}
+          isChecked={topologyOptions.showEmpty}
+          onChange={() =>
+            setTopologyOptions({
+              ...topologyOptions,
+              showEmpty: !topologyOptions.showEmpty
+            })
+          }
+        />
       </div>
       <div className="pf-c-select__menu-group">
         <Tooltip content={t('Long labels can reduce visibility.')}>

web/src/components/netflow-traffic.tsx

@@ -438,7 +438,7 @@ export const NetflowTraffic: React.FC<NetflowTrafficProps> = ({
             clearFlows
           );
 
-        if (model.metricScope === 'udn') {
+        if (model.topologyOptions.showEmpty && model.metricScope === 'udn') {
           drawerRef.current
             ?.getTopologyHandle()
             ?.fetchUDNs()
@@ -495,6 +495,7 @@ export const NetflowTraffic: React.FC<NetflowTrafficProps> = ({
     model.config.features,
     model.topologyMetricType,
     model.topologyMetricFunction,
+    model.topologyOptions.showEmpty,
     model.selectedViewId,
     buildFlowQuery,
     manageWarnings,

web/src/model/topology.ts

@@ -54,6 +54,7 @@ export interface TopologyOptions {
   medScale: number;
   metricFunction: StatFunction;
   metricType: MetricType;
+  showEmpty?: boolean;
 }
 
 export const DefaultOptions: TopologyOptions = {
@@ -68,7 +69,8 @@ export const DefaultOptions: TopologyOptions = {
   lowScale: 0.3,
   medScale: 0.5,
   metricFunction: defaultMetricFunction,
-  metricType: defaultMetricType
+  metricType: defaultMetricType,
+  showEmpty: true
 };
 
 export type GraphElementPeer = GraphElement<ElementModel, NodeData>;
@@ -605,14 +607,16 @@ export const generateDataModel = (
   //remove empty groups
   nodes = nodes.filter(n => n.type !== 'group' || (n.children && n.children.length));
 
-  // add missing nodes to the view
-  const currentNodes = nodes.map(n => n.label);
-  const missingNodes = expectedNodes.filter(n => !currentNodes.includes(n));
-  missingNodes.forEach(n => {
-    const fields: Partial<TopologyMetricPeer> = { id: n };
-    fields[metricScope] = n;
-    addNode({ peer: createPeer(fields), nodeType: metricScope, canStepInto: false, noMetrics: true });
-  });
+  // add missing nodes to the view if available
+  if (!_.isEmpty(expectedNodes)) {
+    const currentNodes = nodes.map(n => n.label);
+    const missingNodes = expectedNodes.filter(n => !currentNodes.includes(n));
+    missingNodes.forEach(n => {
+      const fields: Partial<TopologyMetricPeer> = { id: n };
+      fields[metricScope] = n;
+      addNode({ peer: createPeer(fields), nodeType: metricScope, canStepInto: false, noMetrics: true });
+    });
+  }
 
   return { nodes, edges };
 };