fix linter

Author: jotak

pkg/handler/alertingmock/alerting_mock.go

@@ -1,7 +1,6 @@
 package alertingmock
 
 import (
-	"context"
 	"encoding/json"
 	"fmt"
 	"math/rand/v2"
@@ -58,9 +57,8 @@ func randomState() int {
 		return silenced
 	} else if rndState < 3 {
 		return pending
-	} else {
-		return firing
 	}
+	return firing
 }
 
 func createAlert(probability float64, name, resourceName string, threshold int, targetLabels, resourceNames []string, annotations, labels model.LabelSet) (*Alert, int) {
@@ -158,8 +156,8 @@ func createRule(probability float64, name, severity string, threshold int, bynet
 	}
 }
 
-func GetRules(ctx context.Context) func(w http.ResponseWriter, r *http.Request) {
-	return func(w http.ResponseWriter, r *http.Request) {
+func GetRules() func(w http.ResponseWriter, r *http.Request) {
+	return func(w http.ResponseWriter, _ *http.Request) {
 		alertingRules := []AlertingRule{
 			createRule(0.4, "Packet delivery successfully failed", "info", 5, true, []string{"SrcK8S_Namespace", "DstK8S_Namespace"}, []string{}),
 			createRule(0.3, "You have reached your hourly rate limit", "info", 5, true, []string{"SrcK8S_Namespace", "DstK8S_Namespace"}, []string{}),

pkg/server/routes.go

@@ -75,7 +75,7 @@ func setupRoutes(ctx context.Context, cfg *config.Config, authChecker auth.Check
 
 	if cfg.Loki.UseMocks {
 		// Add route for alerts (otherwise, the route is provided by the Console itself)
-		api.HandleFunc("/prometheus/api/v1/rules", alertingmock.GetRules(ctx))
+		api.HandleFunc("/prometheus/api/v1/rules", alertingmock.GetRules())
 	}
 
 	return r

web/src/components/health/health-drawer-container.tsx

@@ -46,6 +46,8 @@ export const HealthDrawerContainer: React.FC<HealthDrawerContainerProps> = ({ ti
         setSelectedResource(fromStats);
       }
     }
+    // we want to update selectedResource when stats changes, no more
+    // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [stats]);
 
   return (

web/src/components/health/helper.ts

@@ -278,7 +278,7 @@ export const computeAlertScore = (a: AlertWithRuleName, ignoreSeverity?: boolean
 };
 
 export const isSilenced = (silence: SilenceMatcher[], labels: PrometheusLabels): boolean => {
-  for (let matcher of silence) {
+  for (const matcher of silence) {
     if (!(matcher.name in labels)) {
       return false;
     }