Commit 8fb9a44
authored
NETOBSERV-1959: Remove hardcoded columns rendering + other enhancements (#633)
* NETOBSERV-1959: Remove hardcoded columns rendering + other enhancements
- Remove hardcoded columns
- Change some of the rendering scripted functions:
- getConcatenatedValue -> concat now dedicated to just concatenate
values
- they can now accept litterals (e.g. concat(DstAddr,':',DstPort))
- remove getSrcOrDstValue since there was also "[...]" for the same
role
- add new kubeObject func to show kind-name-namespace sort of things
- Improve performance by avoiding re-parsing everything for every rendered
flow
- there's probably more that we could do on that side
- Add unit tests
* preprocess a bit more of parsed functions
* address feedback
* Fix issues about visible fields in side panel
Previously, visible fields were determined out of several criteria
including:
- fields with calculated values were filtered out
- record with null value was filtered out (as opposed to undefined)
Also, "Common" columns was determined by having a calculated value (ie.
non-common columns were prohibited to use calculated)
This must change since columns can now have calculated and still must be
visible (e.g. SrcK8S_Name is a kubeObject calculated value)
- So, Common now is when calculated in the form of "[a,b]"
- Visible columns for side panel is now based on being tied to fields
* Use fieldValue func for filters
* NETOBSERV-1969: Fix IcmpType & IcmpCode
Those fields should be correctly displayed when ICMP data is present,
and not displayed (in side panel) when ICMP data is absent.
* format1 parent 6bb4d91 commit 8fb9a44
File tree
13 files changed
+464
-386
lines changed- config
- web/src
- components
- __tests-data__
- drawer/record
- __tests__
- query-summary/__tests__
- tabs/netflow-table
- utils
- __tests__
13 files changed
+464
-386
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
192 | 192 | | |
193 | 193 | | |
194 | 194 | | |
| 195 | + | |
195 | 196 | | |
196 | 197 | | |
197 | 198 | | |
| |||
213 | 214 | | |
214 | 215 | | |
215 | 216 | | |
| 217 | + | |
216 | 218 | | |
217 | 219 | | |
218 | 220 | | |
| |||
236 | 238 | | |
237 | 239 | | |
238 | 240 | | |
| 241 | + | |
239 | 242 | | |
240 | 243 | | |
241 | 244 | | |
| |||
277 | 280 | | |
278 | 281 | | |
279 | 282 | | |
| 283 | + | |
280 | 284 | | |
281 | 285 | | |
282 | 286 | | |
283 | 287 | | |
284 | 288 | | |
285 | | - | |
| 289 | + | |
286 | 290 | | |
287 | 291 | | |
288 | 292 | | |
289 | 293 | | |
290 | 294 | | |
291 | | - | |
| 295 | + | |
292 | 296 | | |
293 | 297 | | |
294 | 298 | | |
295 | 299 | | |
296 | 300 | | |
297 | | - | |
| 301 | + | |
298 | 302 | | |
299 | 303 | | |
300 | 304 | | |
| |||
312 | 316 | | |
313 | 317 | | |
314 | 318 | | |
| 319 | + | |
315 | 320 | | |
316 | 321 | | |
317 | 322 | | |
| |||
333 | 338 | | |
334 | 339 | | |
335 | 340 | | |
| 341 | + | |
336 | 342 | | |
337 | 343 | | |
338 | 344 | | |
| |||
356 | 362 | | |
357 | 363 | | |
358 | 364 | | |
| 365 | + | |
359 | 366 | | |
360 | 367 | | |
361 | 368 | | |
| |||
397 | 404 | | |
398 | 405 | | |
399 | 406 | | |
| 407 | + | |
400 | 408 | | |
401 | 409 | | |
402 | 410 | | |
403 | 411 | | |
404 | 412 | | |
405 | | - | |
| 413 | + | |
406 | 414 | | |
407 | 415 | | |
408 | 416 | | |
409 | 417 | | |
410 | 418 | | |
411 | | - | |
| 419 | + | |
412 | 420 | | |
413 | 421 | | |
414 | 422 | | |
415 | 423 | | |
416 | 424 | | |
417 | | - | |
| 425 | + | |
418 | 426 | | |
419 | 427 | | |
420 | 428 | | |
| |||
427 | 435 | | |
428 | 436 | | |
429 | 437 | | |
430 | | - | |
| 438 | + | |
431 | 439 | | |
432 | 440 | | |
433 | 441 | | |
434 | 442 | | |
435 | | - | |
| 443 | + | |
436 | 444 | | |
437 | 445 | | |
438 | 446 | | |
439 | 447 | | |
440 | | - | |
| 448 | + | |
441 | 449 | | |
442 | 450 | | |
443 | 451 | | |
444 | 452 | | |
445 | | - | |
| 453 | + | |
446 | 454 | | |
447 | 455 | | |
448 | 456 | | |
449 | 457 | | |
450 | | - | |
| 458 | + | |
451 | 459 | | |
452 | 460 | | |
453 | 461 | | |
454 | 462 | | |
455 | | - | |
| 463 | + | |
456 | 464 | | |
457 | 465 | | |
458 | 466 | | |
459 | 467 | | |
460 | | - | |
| 468 | + | |
461 | 469 | | |
462 | 470 | | |
463 | 471 | | |
464 | 472 | | |
465 | | - | |
| 473 | + | |
466 | 474 | | |
467 | 475 | | |
468 | 476 | | |
469 | 477 | | |
470 | | - | |
| 478 | + | |
471 | 479 | | |
472 | 480 | | |
473 | 481 | | |
474 | 482 | | |
475 | | - | |
| 483 | + | |
476 | 484 | | |
477 | 485 | | |
478 | 486 | | |
| |||
581 | 589 | | |
582 | 590 | | |
583 | 591 | | |
584 | | - | |
| 592 | + | |
585 | 593 | | |
586 | 594 | | |
587 | 595 | | |
| |||
0 commit comments