skip namespace filtering for loki case

jpinsonneau · jpinsonneau · commit 8ff2a47f7362 · 2024-08-05T11:12:19.000+02:00
diff --git a/pkg/loki/flow_query.go b/pkg/loki/flow_query.go
@@ -108,7 +108,10 @@ func (q *FlowQueryBuilder) Filters(queryFilters filters.SingleQuery) error {
 }
 
 func (q *FlowQueryBuilder) addFilter(filter filters.Match) error {
-	if !filterRegexpValidation.MatchString(filter.Values) {
+	// namespace filtering is managed by loki gateway so we can simply skip it
+	if filter.Key == "namespace" {
+		return nil
+	} else if !filterRegexpValidation.MatchString(filter.Values) {
 		return fmt.Errorf("unauthorized sign in flows request: %s", filter.Values)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,10 @@ func (q *FlowQueryBuilder) Filters(queryFilters filters.SingleQuery) error {`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`func (q *FlowQueryBuilder) addFilter(filter filters.Match) error {`
`111`		`- if !filterRegexpValidation.MatchString(filter.Values) {`
	`111`	`+ // namespace filtering is managed by loki gateway so we can simply skip it`
	`112`	`+ if filter.Key == "namespace" {`
	`113`	`+ return nil`
	`114`	`+ } else if !filterRegexpValidation.MatchString(filter.Values) {`
`112`	`115`	`return fmt.Errorf("unauthorized sign in flows request: %s", filter.Values)`
`113`	`116`	`}`
`114`	`117`