fix tests

Author: jpinsonneau

web/setup-tests.tsx

@@ -106,6 +106,7 @@ jest.mock('./src/api/routes', () => ({
   getPods: jest.fn(async () => ['ABCD']),
   getNamespaces: jest.fn(async () => ['EFGH']),
   getConfig: jest.fn(async () => ({ portNaming: { enable: true, portNames: new Map() } })),
+  getRole: jest.fn(async () => ('admin')),
   getLokiReady: jest.fn(async () => 'ready'),
 }));
 

web/src/components/__tests__/netflow-tab.spec.tsx

@@ -17,6 +17,7 @@ const useResolvedExtensionsMock = useResolvedExtensions as jest.Mock;
 
 jest.mock('../../api/routes', () => ({
   getConfig: jest.fn(() => Promise.resolve(FullConfigResultSample)),
+  getRole: jest.fn(() => Promise.resolve('admin')),
   getFlowRecords: jest.fn(() => Promise.resolve([])),
   getFlowMetrics: jest.fn(() =>
     Promise.resolve({

web/src/components/__tests__/netflow-traffic.spec.tsx

@@ -5,7 +5,7 @@ import * as React from 'react';
 import { act } from 'react-dom/test-utils';
 import { AlertsResult, SilencedAlert } from '../../api/alert';
 import { FlowMetricsResult, GenericMetricsResult } from '../../api/loki';
-import { getConfig, getFlowGenericMetrics, getFlowMetrics, getFlowRecords } from '../../api/routes';
+import { getConfig, getFlowGenericMetrics, getFlowMetrics, getFlowRecords, getRole } from '../../api/routes';
 import { FlowQuery } from '../../model/flow-query';
 import NetflowTraffic from '../netflow-traffic';
 import NetflowTrafficParent from '../netflow-traffic-parent';
@@ -19,6 +19,7 @@ const useResolvedExtensionsMock = useResolvedExtensions as jest.Mock;
 jest.mock('../../api/routes', () => ({
   // mock the most complete configuration to test all queries
   getConfig: jest.fn(() => Promise.resolve(FullConfigResultSample)),
+  getRole: jest.fn(() => Promise.resolve('admin')),
   getFlowRecords: jest.fn(() => Promise.resolve(FlowsResultSample)),
   getFlowMetrics: jest.fn(() =>
     Promise.resolve({
@@ -37,6 +38,7 @@ jest.mock('../../api/routes', () => ({
 }));
 
 const getConfigMock = getConfig as jest.Mock;
+const getRoleMock = getRole as jest.Mock;
 const getFlowsMock = getFlowRecords as jest.Mock;
 const getMetricsMock = getFlowMetrics as jest.Mock;
 const getGenericMetricsMock = getFlowGenericMetrics as jest.Mock;
@@ -72,7 +74,7 @@ describe('<NetflowTraffic />', () => {
 
   it('should render refresh components', async () => {
     act(() => {
-      const cheerio = render(<NetflowTrafficParent />);
+      const cheerio = render(<NetflowTraffic />);
       expect(cheerio.find('#refresh-dropdown-container').length).toEqual(1);
       expect(cheerio.find('#refresh-button').length).toEqual(1);
     });
@@ -115,6 +117,7 @@ describe('<NetflowTraffic />', () => {
     await waitFor(() => {
       //config is get only once
       expect(getConfigMock).toHaveBeenCalledTimes(1);
+      expect(getRoleMock).toHaveBeenCalledTimes(1);
       expect(getFlowsMock).toHaveBeenCalledTimes(0);
       expect(getMetricsMock).toHaveBeenCalledTimes(expectedMetricsQueries.length);
       expectedMetricsQueries.forEach((q, i) =>
@@ -126,6 +129,7 @@ describe('<NetflowTraffic />', () => {
     await waitFor(() => {
       //config is get only once
       expect(getConfigMock).toHaveBeenCalledTimes(1);
+      expect(getRoleMock).toHaveBeenCalledTimes(1);
       expect(getFlowsMock).toHaveBeenCalledTimes(0);
       //should have called getMetricsMock & getGenericMetricsMock original count twice
       expect(getMetricsMock).toHaveBeenCalledTimes(expectedMetricsQueries.length * 2);
@@ -137,6 +141,7 @@ describe('<NetflowTraffic />', () => {
     const wrapper = mount(<NetflowTrafficParent />);
     await waitFor(() => {
       expect(getConfigMock).toHaveBeenCalled();
+      expect(getRoleMock).toHaveBeenCalled();
     });
     await act(async () => {
       expect(wrapper.find('#filter-toolbar').last()).toBeTruthy();
@@ -152,6 +157,7 @@ describe('<NetflowTraffic />', () => {
     await waitFor(() => {
       //config is get only once
       expect(getConfigMock).toHaveBeenCalledTimes(1);
+      expect(getRoleMock).toHaveBeenCalledTimes(1);
       expect(getFlowsMock).toHaveBeenCalledTimes(0);
       /** should have called getMetricsMock 2 times on render:
        * 2 queries for metrics on current scope & app scope
@@ -161,11 +167,13 @@ describe('<NetflowTraffic />', () => {
       expect(getGenericMetricsMock).toHaveBeenCalledTimes(0);
     });
     await act(async () => {
-      wrapper.find('#refresh-button').at(0).simulate('click');
+      await wrapper.update(); // force component did mount to occurs
+      wrapper.find('#refresh-button').last().simulate('click');
     });
     await waitFor(() => {
       //config is get only once
       expect(getConfigMock).toHaveBeenCalledTimes(1);
+      expect(getRoleMock).toHaveBeenCalledTimes(1);
       expect(getFlowsMock).toHaveBeenCalledTimes(0);
       //should have called getMetricsMock 4 times after click (2 * 2)
       expect(getMetricsMock).toHaveBeenCalledTimes(4);