fix lint

Author: jpinsonneau

web/eslint.config.js

@@ -6,7 +6,11 @@ export default [
   {
     ignores: [
       "**/node_modules/*",
-      "**/dist/*"
+      "**/dist/*",
+      "**/cypress/*",
+      "**/i18next-parser.config.js",
+      "**/setup-tests.tsx",
+      "**/webpack.*.ts"
     ]
   },
   eslint.configs.recommended,
@@ -33,9 +37,11 @@ export default [
       "max-len": ["warn", {
         code: 170,
       }],
+      "no-case-declarations": "off",
       "react-hooks/rules-of-hooks": "error",
       "react-hooks/exhaustive-deps": "warn",
       "react/prop-types": "off",
+      "@typescript-eslint/no-require-imports": "off",
       "@typescript-eslint/no-empty-interface": "off",
       "@typescript-eslint/no-non-null-assertion": "off",
     },

web/moduleMapper/dummy.tsx

@@ -13,10 +13,12 @@ export class Dummy extends Error {
   }
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export function isModelFeatureFlag(e: never) {
   return null;
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export function useResolvedExtensions(isModelFeatureFlag: boolean) {
   return [
     [{

web/package.json

@@ -23,7 +23,7 @@
     "lint": "./node_modules/.bin/eslint \"./src/**/*.{ts,tsx}\"",
     "format": "pretty-quick --branch main",
     "format-all": "prettier --write \"./src/**/*.{ts,tsx}\" && npm run fix-imports",
-    "fix-imports": "eslint --no-inline-config --parser '@typescript-eslint/parser' --plugin 'unused-imports' --plugin 'react-hooks' --rule 'unused-imports/no-unused-imports:error' --fix",
+    "fix-imports": "eslint --parser '@typescript-eslint/parser' --plugin 'unused-imports' --plugin 'react-hooks' --rule 'unused-imports/no-unused-imports:error' --fix",
     "generate-doc": "typedoc --sort source-order --categorizeByGroup false --githubPages false --readme none --disableSources --out docs src/api/ipfix.ts --hideBreadcrumbs true --hideInPageTOC true"
   },
   "devDependencies": {

web/src/app.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable max-len */
 import {
   Brand,
   Button,

web/src/components/__tests__/common.spec.tsx

@@ -25,7 +25,6 @@ describe('common test functions', () => {
   const wrapper = mount(<></>);
 
   it('should run without error', async () => {
-    // eslint-disable-next-line @typescript-eslint/no-empty-function
     await actOn(() => {}, wrapper);
     await waitForRender(wrapper);
   });

web/src/components/alerts/fetcher.tsx

@@ -5,6 +5,7 @@ import AlertBanner from './banner';
 
 import { murmur3 } from 'murmurhash-js';
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export interface AlertFetcherProps {}
 
 export const AlertFetcher: React.FC<AlertFetcherProps> = ({ children }) => {

web/src/components/drawer/netflow-traffic-drawer.tsx

@@ -101,7 +101,6 @@ export interface NetflowTrafficDrawerProps {
   setSelectedElement: (v: GraphElementPeer | undefined) => void;
 }
 
-// eslint-disable-next-line react/display-name
 export const NetflowTrafficDrawer: React.FC<NetflowTrafficDrawerProps> = React.forwardRef(
   (props, ref: React.Ref<NetflowTrafficDrawerHandle>) => {
     const overviewRef = React.useRef<NetflowOverviewHandle>(null);
@@ -218,7 +217,6 @@ export const NetflowTrafficDrawer: React.FC<NetflowTrafficDrawerProps> = React.f
             );
           } else if (match === 'all' && !hasIndexFields(filters.list)) {
             reason = t(
-              // eslint-disable-next-line max-len
               'Add Namespace, Owner or Resource filters (which use indexed fields), or decrease limit / range, to improve the query performance'
             );
           } else {

web/src/components/dropdowns/query-options-panel.tsx

@@ -102,7 +102,6 @@ export const QueryOptionsPanel: React.FC<QueryOptionsProps> = ({
       <div className="pf-v6-c-menu__group">
         <Tooltip
           content={t(
-            // eslint-disable-next-line max-len
             'Log type to query. A conversation is an aggregation of flows between same peers. Only ended conversations will appear in Overview and Topology tabs.'
           )}
         >
@@ -124,13 +123,9 @@ export const QueryOptionsPanel: React.FC<QueryOptionsProps> = ({
                     disabled
                       ? opt.value === 'allConnections'
                         ? t(
-                            // eslint-disable-next-line max-len
                             'Only available when FlowCollector.processor.logTypes option equals "CONNECTIONS", "ENDED_CONNECTIONS" or "ALL"'
                           )
-                        : t(
-                            // eslint-disable-next-line max-len
-                            'Only available when FlowCollector.processor.logTypes option equals "FLOWS" or "ALL"'
-                          )
+                        : t('Only available when FlowCollector.processor.logTypes option equals "FLOWS" or "ALL"')
                       : undefined
                   }
                 >
@@ -174,14 +169,10 @@ export const QueryOptionsPanel: React.FC<QueryOptionsProps> = ({
                     disabled
                       ? opt.value === 'prom'
                         ? t(
-                            // eslint-disable-next-line max-len
                             'Only available when FlowCollector.prometheus.enable is true for Overview and Topology tabs'
                           )
                         : opt.value === 'loki'
-                        ? t(
-                            // eslint-disable-next-line max-len
-                            'Only available when FlowCollector.loki.enable is true'
-                          )
+                        ? t('Only available when FlowCollector.loki.enable is true')
                         : undefined
                       : undefined
                   }
@@ -230,12 +221,7 @@ export const QueryOptionsPanel: React.FC<QueryOptionsProps> = ({
         </div>
       )}
       <div className="pf-v6-c-menu__group">
-        <Tooltip
-          content={t(
-            // eslint-disable-next-line max-len
-            'Whether each query result has to match all the filters or just any of them'
-          )}
-        >
+        <Tooltip content={t('Whether each query result has to match all the filters or just any of them')}>
           <div className="pf-v6-c-menu__group-title">
             <Content component={ContentVariants.p}>
               {t('Match filters')} <InfoAltIcon />
@@ -295,10 +281,7 @@ export const QueryOptionsPanel: React.FC<QueryOptionsProps> = ({
                   trigger={disabled ? 'mouseenter focus' : ''}
                   content={
                     disabled
-                      ? t(
-                          // eslint-disable-next-line max-len
-                          'Only available using eBPF with FlowCollector.agent.ebpf.features containing "PacketDrop"'
-                        )
+                      ? t('Only available using eBPF with FlowCollector.agent.ebpf.features containing "PacketDrop"')
                       : undefined
                   }
                 >

web/src/components/dynamic-loader/dynamic-loader.tsx

@@ -39,6 +39,7 @@ export const navigate = (to: string, opts?: any) => {
   }
 };
 
+// eslint-disable-next-line @typescript-eslint/no-empty-object-type
 export const DynamicLoader: React.FC<{}> = ({ children }) => {
   loadNavFunction();
   return <>{children ? children : ''}</>;

web/src/components/guided-tour/guided-tour.tsx

@@ -31,7 +31,7 @@ export interface GuidedTourPopoverProps {
 }
 
 const onIndexChangeFunctions: IndexChangeFunction[] = [];
-// eslint-disable-next-line react/display-name
+
 export const GuidedTourPopover: React.FC<GuidedTourPopoverProps> = React.forwardRef(
   (props, ref: React.Ref<GuidedTourHandle>) => {
     const { t } = useTranslation('plugin__netobserv-plugin');