Skip to content

Commit f28bffc

Browse files
authored
Improve build time (#1049)
* Improve build time * Use fork-ts-checker-webpack-plugin to dissociate type-checking; run it only on-demand and on PR checks * dummy for testing PR * Revert "dummy for testing PR" This reverts commit 25c379e.
1 parent d6fa86b commit f28bffc

File tree

8 files changed

+372
-5
lines changed

8 files changed

+372
-5
lines changed

.github/workflows/pull_request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
- name: checkout
4444
uses: actions/checkout@v3
4545
- name: build and test
46-
run: make frontend && git diff --exit-code
46+
run: TYPECHECK=true make frontend && git diff --exit-code
4747
- name: Report coverage
4848
uses: codecov/codecov-action@v4
4949
with:

.mk/standalone.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ start-standalone-mock: YQ build-backend install-frontend ## Run backend using mo
2020
.PHONY: just-build-frontend
2121
just-build-frontend: ## Build frontend
2222
@echo "### Building frontend"
23-
cd web && npm run build${BUILDSCRIPT}
23+
cd web && TYPECHECK=${TYPECHECK} npm run build${BUILDSCRIPT}
2424

2525
.PHONY: build-frontend-standalone
2626
build-frontend-standalone: install-frontend fmt-frontend ## Run npm install, format and build frontend as standalone

Dockerfile.cypress

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ COPY --chown=node web web
1717
COPY mocks mocks
1818

1919
WORKDIR /opt/app-root/web
20-
RUN npm run format-all
2120
RUN npm run build$BUILDSCRIPT
2221
RUN npm run build:static
2322

Dockerfile.downstream

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ COPY --chown=default web web
1616
COPY --chown=default mocks mocks
1717

1818
WORKDIR /opt/app-root/web
19-
RUN npm run format-all
2019
RUN npm run build
2120
RUN npm run build:static
2221

Dockerfile.front

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ COPY --chown=node web web
1515
COPY mocks mocks
1616

1717
WORKDIR /opt/app-root/web
18-
RUN npm run format-all
1918
RUN npm run build$BUILDSCRIPT
2019
RUN npm run build:static
2120

0 commit comments

Comments
 (0)