Skip to content

Update pf4 base image #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2025
Merged

Update pf4 base image #1082

merged 1 commit into from
Oct 27, 2025

Conversation

@jotak
Copy link
Member

@jotak jotak commented Oct 27, 2025

Description

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign oliviercazade for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.43%. Comparing base (ee94b86) to head (9bb51a8).
⚠️ Report is 1 commits behind head on release-1.10-pf4.

Additional details and impacted files 
@@                 Coverage Diff                  @@
##           release-1.10-pf4    #1082      +/-   ##
====================================================
+ Coverage             56.79%   57.43%   +0.64%     
====================================================
  Files                   196      196              
  Lines                 10209     9576     -633     
  Branches               1187     1187              
====================================================
- Hits                   5798     5500     -298     
+ Misses                 4047     3712     -335     
  Partials                364      364
Flag Coverage Δ
uitests 59.77% <ø> (ø)
unittests 51.27% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jotak
Copy link
Member Author

jotak commented Oct 27, 2025

/cherry-pick main

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 27, 2025

@jotak: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jotak jotak merged commit d1b423e into netobserv:release-1.10-pf4 Oct 27, 2025
6 of 7 checks passed
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 27, 2025

@jotak: #1082 failed to apply on top of branch "main":

Applying: Update pf4 base image
Using index info to reconstruct a base tree...
M	Dockerfile.downstream
Falling back to patching base and 3-way merge...
Auto-merging Dockerfile.downstream
CONFLICT (content): Merge conflict in Dockerfile.downstream
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Update pf4 base image

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jotak
Copy link
Member Author

jotak commented Oct 27, 2025

/cherry-pick main-pf4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Oct 27, 2025

@jotak: new pull request created: #1083

In response to this:

/cherry-pick main-pf4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jotak @openshift-cherrypick-robot