NETOBSERV-2174: check if LokiStack exists (#1257)

* NETOBSERV-2174: check if LokiStack exists

tmp

* fix golint

Author: jotak

bundle/manifests/netobserv-operator.clusterserviceversion.yaml

@@ -1080,6 +1080,14 @@ spec:
           - get
           - patch
           - update
+        - apiGroups:
+          - loki.grafana.com
+          resources:
+          - lokistacks
+          verbs:
+          - get
+          - list
+          - watch
         - apiGroups:
           - loki.grafana.com
           resourceNames:

config/rbac/role.yaml

@@ -147,6 +147,14 @@ rules:
   - get
   - patch
   - update
+- apiGroups:
+  - loki.grafana.com
+  resources:
+  - lokistacks
+  verbs:
+  - get
+  - list
+  - watch
 - apiGroups:
   - loki.grafana.com
   resourceNames:

go.mod

@@ -9,6 +9,7 @@ require (
 	github.com/coreos/go-semver v0.3.1
 	github.com/go-logr/logr v1.4.2
 	github.com/google/go-cmp v0.6.0
+	github.com/grafana/loki/operator/apis/loki v0.0.0-20241021105923-5e970e50b166
 	github.com/netobserv/flowlogs-pipeline v1.7.0-community.0.20250303144123-5f6d6dcd0bdf
 	github.com/netobserv/netobserv-ebpf-agent v1.8.0-crc0
 	github.com/onsi/ginkgo/v2 v2.23.0

go.sum

@@ -456,6 +456,8 @@ github.com/gorilla/context v1.1.1/go.mod h1:kBGZzfjB9CEq2AlWe17Uuf7NDRt0dE0s8S51
 github.com/gorilla/mux v1.6.2/go.mod h1:1lud6UwP+6orDFRuTfBEV8e9/aOM/c4fVVCaMa2zaAs=
 github.com/gorilla/mux v1.7.3/go.mod h1:1lud6UwP+6orDFRuTfBEV8e9/aOM/c4fVVCaMa2zaAs=
 github.com/gorilla/websocket v0.0.0-20170926233335-4201258b820c/go.mod h1:E7qHFY5m1UJ88s3WnNqhKjPHQ0heANvMoAMk2YaljkQ=
+github.com/grafana/loki/operator/apis/loki v0.0.0-20241021105923-5e970e50b166 h1:cmG5fwmF+0PsyerLecb7CU4bzNRg5+tDgO3PiNxskKo=
+github.com/grafana/loki/operator/apis/loki v0.0.0-20241021105923-5e970e50b166/go.mod h1:QggEReYyQzjnwTlj9hMeRaI2M/w3UPAwrMOXYzIyonc=
 github.com/gregjones/httpcache v0.0.0-20180305231024-9cad4c3443a7/go.mod h1:FecbI9+v66THATjSRHfNgh1IVFe/9kFxbXtjV0ctIMA=
 github.com/grpc-ecosystem/go-grpc-middleware v1.0.1-0.20190118093823-f849b5445de4/go.mod h1:FiyG127CGDf3tlThmgyCl78X/SZQqEOJBCDaAfeWzPs=
 github.com/grpc-ecosystem/go-grpc-prometheus v1.2.0/go.mod h1:8NvIoxWQoOIhqOTXgfV/d3M/q6VIi02HzZEHgUlZvzk=

helm/templates/clusterrole.yaml

@@ -146,6 +146,14 @@ rules:
       - get
       - patch
       - update
+  - apiGroups:
+      - loki.grafana.com
+    resources:
+      - lokistacks
+    verbs:
+      - get
+      - list
+      - watch
   - apiGroups:
       - loki.grafana.com
     resourceNames:

main.go

@@ -26,6 +26,7 @@ import (
 	"os"
 
 	bpfmaniov1alpha1 "github.com/bpfman/bpfman-operator/apis/v1alpha1"
+	lokiv1 "github.com/grafana/loki/operator/apis/loki/v1"
 	osv1 "github.com/openshift/api/console/v1"
 	operatorsv1 "github.com/openshift/api/operator/v1"
 	securityv1 "github.com/openshift/api/security/v1"
@@ -84,6 +85,7 @@ func init() {
 	utilruntime.Must(monitoringv1.AddToScheme(scheme))
 	utilruntime.Must(apiextensionsv1.AddToScheme(scheme))
 	utilruntime.Must(bpfmaniov1alpha1.Install(scheme))
+	utilruntime.Must(lokiv1.AddToScheme(scheme))
 	//+kubebuilder:scaffold:scheme
 }
 

pkg/manager/manager.go

@@ -33,6 +33,7 @@ import (
 //+kubebuilder:rbac:groups=monitoring.coreos.com,resources=servicemonitors;prometheusrules,verbs=get;create;delete;update;patch;list;watch
 //+kubebuilder:rbac:groups=config.openshift.io,resources=clusterversions;networks,verbs=get;list;watch
 //+kubebuilder:rbac:groups=loki.grafana.com,resources=network,resourceNames=logs,verbs=create
+//+kubebuilder:rbac:groups=loki.grafana.com,resources=lokistacks,verbs=get;list;watch
 //+kubebuilder:rbac:groups=metrics.k8s.io,resources=pods,verbs=create
 //+kubebuilder:rbac:groups=networking.k8s.io,resources=networkpolicies,verbs=get;list;watch;create;update;patch;delete
 //+kubebuilder:rbac:groups=bpfman.io,resources=bpfapplications,verbs=get;list;watch;create;update;patch;delete

pkg/manager/status/status_manager.go

@@ -6,13 +6,16 @@ import (
 	"strings"
 	"sync"
 
+	lokiv1 "github.com/grafana/loki/operator/apis/loki/v1"
 	flowslatest "github.com/netobserv/network-observability-operator/apis/flowcollector/v1beta2"
 	"github.com/netobserv/network-observability-operator/controllers/constants"
+	"github.com/netobserv/network-observability-operator/pkg/helper"
 	appsv1 "k8s.io/api/apps/v1"
 	v1 "k8s.io/api/core/v1"
 	kerr "k8s.io/apimachinery/pkg/api/errors"
 	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/types"
 	"k8s.io/client-go/util/retry"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/log"
@@ -28,6 +31,7 @@ const (
 	Monitoring                  ComponentName = "Monitoring"
 	NetworkPolicy               ComponentName = "NetworkPolicy"
 	ConditionConfigurationIssue               = "ConfigurationIssue"
+	LokiIssue                                 = "LokiIssue"
 )
 
 var allNames = []ComponentName{FlowCollectorLegacy, Monitoring}
@@ -136,6 +140,7 @@ func updateStatus(ctx context.Context, c client.Client, conditions ...metav1.Con
 			return err
 		}
 		conditions = append(conditions, checkValidation(ctx, &fc))
+		conditions = append(conditions, checkLoki(ctx, c, &fc))
 		for _, c := range conditions {
 			meta.SetStatusCondition(&fc.Status.Conditions, c)
 		}
@@ -173,6 +178,52 @@ func checkValidation(ctx context.Context, fc *flowslatest.FlowCollector) metav1.
 	}
 }
 
+func checkLoki(ctx context.Context, c client.Client, fc *flowslatest.FlowCollector) metav1.Condition {
+	if !helper.UseLoki(&fc.Spec) {
+		return metav1.Condition{
+			Type:    LokiIssue,
+			Reason:  "Unused",
+			Status:  metav1.ConditionUnknown,
+			Message: "Loki is disabled",
+		}
+	}
+	if fc.Spec.Loki.Mode != flowslatest.LokiModeLokiStack {
+		return metav1.Condition{
+			Type:    LokiIssue,
+			Reason:  "Unused",
+			Status:  metav1.ConditionUnknown,
+			Message: "Loki is not configured in LokiStack mode",
+		}
+	}
+	lokiStack := &lokiv1.LokiStack{}
+	nsname := types.NamespacedName{Name: fc.Spec.Loki.LokiStack.Name, Namespace: fc.Spec.Namespace}
+	if len(fc.Spec.Loki.LokiStack.Namespace) > 0 {
+		nsname.Namespace = fc.Spec.Loki.LokiStack.Namespace
+	}
+	err := c.Get(ctx, nsname, lokiStack)
+	if err != nil {
+		if kerr.IsNotFound(err) {
+			return metav1.Condition{
+				Type:    LokiIssue,
+				Reason:  "LokiStackNotFound",
+				Status:  metav1.ConditionTrue,
+				Message: fmt.Sprintf("The configured LokiStack reference could not be found [name: %s, namespace: %s]", nsname.Name, nsname.Namespace),
+			}
+		}
+		return metav1.Condition{
+			Type:    LokiIssue,
+			Reason:  "Error",
+			Status:  metav1.ConditionTrue,
+			Message: fmt.Sprintf("Error while fetching configured LokiStack: %s", err.Error()),
+		}
+	}
+	return metav1.Condition{
+		Type:   LokiIssue,
+		Reason: "NoIssue",
+		Status: metav1.ConditionFalse,
+	}
+}
+
 func (s *Manager) ForComponent(cpnt ComponentName) Instance {
 	return Instance{cpnt: cpnt, s: s}
 }

pkg/test/envtest.go

@@ -10,6 +10,8 @@ import (
 	. "github.com/onsi/ginkgo/v2"
 	//nolint:revive,stylecheck
 	. "github.com/onsi/gomega"
+
+	lokiv1 "github.com/grafana/loki/operator/apis/loki/v1"
 	configv1 "github.com/openshift/api/config/v1"
 	osv1 "github.com/openshift/api/console/v1"
 	operatorsv1 "github.com/openshift/api/operator/v1"
@@ -115,6 +117,9 @@ func PrepareEnvTest(controllers []manager.Registerer, namespaces []string, baseP
 	err = securityv1.AddToScheme(scheme.Scheme)
 	Expect(err).NotTo(HaveOccurred())
 
+	err = lokiv1.AddToScheme(scheme.Scheme)
+	Expect(err).NotTo(HaveOccurred())
+
 	k8sClient, err := client.New(cfg, client.Options{Scheme: scheme.Scheme})
 	Expect(err).NotTo(HaveOccurred())
 	Expect(k8sClient).NotTo(BeNil())