feat: address review feedback for detail views

- Make parent groups clickable links (same as members)
- Change member count to heading "N Direct Members:"
- Add groups list to home screen with "N Direct Groups:" heading
- Add LastLogon display to user detail view
- Update simple-ldap-go to v1.8.0 for User.LastLogon field
- Add ParentGroups field to FullLDAPGroup for resolved group objects
- Update Index template to use FullLDAPUser with resolved groups

Author: CybotTM

go.mod

@@ -8,7 +8,7 @@ require (
 	github.com/gofiber/storage/bbolt/v2 v2.1.2
 	github.com/gofiber/storage/memory/v2 v2.1.1
 	github.com/joho/godotenv v1.5.1
-	github.com/netresearch/simple-ldap-go v1.7.0
+	github.com/netresearch/simple-ldap-go v1.8.0
 	github.com/playwright-community/playwright-go v0.5200.1
 	github.com/rs/zerolog v1.34.0
 	github.com/stretchr/testify v1.11.1

go.sum

@@ -135,8 +135,8 @@ github.com/moby/term v0.5.2 h1:6qk3FJAFDs6i/q3W/pQ97SX192qKfZgGjCQqfCJkgzQ=
 github.com/moby/term v0.5.2/go.mod h1:d3djjFCrjnB+fl8NJux+EJzu0msscUP+f8it8hPkFLc=
 github.com/morikuni/aec v1.0.0 h1:nP9CBfwrvYnBRgY6qfDQkygYDmYwOilePFkwzv4dU8A=
 github.com/morikuni/aec v1.0.0/go.mod h1:BbKIizmSmc5MMPqRYbxO4ZU0S0+P200+tUnFx7PXmsc=
-github.com/netresearch/simple-ldap-go v1.7.0 h1:eFCqDP38B750VP9VROS0SiTSQBLdlE37tTFAq0hAJaA=
-github.com/netresearch/simple-ldap-go v1.7.0/go.mod h1:Qx2OKwlIfykMU9JNDwjVLMcWHzOQbeqRrNF6oGTDB0A=
+github.com/netresearch/simple-ldap-go v1.8.0 h1:eQG0y2/eHPYjOxAyh5//DDN9SCkUO0lf7GqL/oT631E=
+github.com/netresearch/simple-ldap-go v1.8.0/go.mod h1:Qx2OKwlIfykMU9JNDwjVLMcWHzOQbeqRrNF6oGTDB0A=
 github.com/opencontainers/go-digest v1.0.0 h1:apOUWs51W5PlhuyGyz9FCeeBIOUDA/6nW8Oi/yOhh5U=
 github.com/opencontainers/go-digest v1.0.0/go.mod h1:0JzlMkj0TRzQZfJkVvzbP0HBR3IKzErnv2BNG4W4MAM=
 github.com/opencontainers/image-spec v1.1.1 h1:y0fUlFfIZhPF1W537XOLg0/fcx6zcHCJwooC2xJA040=

internal/ldap_cache/manager.go

@@ -59,7 +59,8 @@ type FullLDAPUser struct {
 // This provides a complete view of group data including all member users.
 type FullLDAPGroup struct {
 	ldap.Group
-	Members []ldap.User // All users that belong to this group
+	Members      []ldap.User  // All users that belong to this group
+	ParentGroups []ldap.Group // All groups this group belongs to (from MemberOf)
 }
 
 // FullLDAPComputer represents a computer with populated group memberships.
@@ -436,12 +437,14 @@ func (m *Manager) PopulateGroupsForUser(user *ldap.User) *FullLDAPUser {
 
 // PopulateUsersForGroup creates a FullLDAPGroup with populated member list.
 // Takes a group and resolves all member DNs to full user objects from the cache.
+// Also resolves parent groups from the MemberOf field.
 // When showDisabled is false, filters out disabled users from membership.
-// Returns a complete group object with expanded member information.
+// Returns a complete group object with expanded member and parent group information.
 func (m *Manager) PopulateUsersForGroup(group *ldap.Group, showDisabled bool) *FullLDAPGroup {
 	full := &FullLDAPGroup{
-		Group:   *group,
-		Members: make([]ldap.User, 0),
+		Group:        *group,
+		Members:      make([]ldap.User, 0),
+		ParentGroups: make([]ldap.Group, 0),
 	}
 
 	for _, userDN := range group.Members {
@@ -455,6 +458,14 @@ func (m *Manager) PopulateUsersForGroup(group *ldap.Group, showDisabled bool) *F
 		}
 	}
 
+	// Resolve parent groups from MemberOf
+	for _, parentDN := range group.MemberOf {
+		parentGroup, err := m.FindGroupByDN(parentDN)
+		if err == nil {
+			full.ParentGroups = append(full.ParentGroups, *parentGroup)
+		}
+	}
+
 	return full
 }
 

internal/web/server.go

@@ -368,8 +368,11 @@ func (a *App) indexHandler(c *fiber.Ctx) error {
 		return handle500(c, err)
 	}
 
+	// Populate groups for the home screen
+	fullUser := a.ldapCache.PopulateGroupsForUser(user)
+
 	// Use template caching
-	return a.templateCache.RenderWithCache(c, templates.Index(user))
+	return a.templateCache.RenderWithCache(c, templates.Index(fullUser))
 }
 
 func (a *App) fourOhFourHandler(c *fiber.Ctx) error {

internal/web/templates/groups.templ

@@ -32,29 +32,30 @@ templ Group(group *ldap_cache.FullLDAPGroup, unassignedUsers []ldap.User, flashe
 	@loggedIn(string(groupUrl(group.Group)), group.CN(), flashes) {
 		<h1 class="text-3xl">{ group.CN() }</h1>
 		<p class="text-sm text-text-secondary">@Copyable(group.DN())</p>
-		<div class="mt-4 grid gap-2 sm:grid-cols-2">
-			if group.Description != "" {
-				<div class="rounded-md border border-border bg-surface-elevated px-3 py-2">
-					<span class="text-sm text-text-secondary">Description</span>
-					<p class="font-medium">{ group.Description }</p>
-				</div>
-			}
-			<div class="rounded-md border border-border bg-surface-elevated px-3 py-2">
-				<span class="text-sm text-text-secondary">Member count</span>
-				<p class="font-medium">{ fmt.Sprintf("%d", len(group.Members)) }</p>
+		if group.Description != "" {
+			<div class="mt-4 rounded-md border border-border bg-surface-elevated px-3 py-2">
+				<span class="text-sm text-text-secondary">Description</span>
+				<p class="font-medium">{ group.Description }</p>
 			</div>
-		</div>
+		}
 		if len(group.MemberOf) > 0 {
-			<h2 class="mt-4 text-xl">Parent groups:</h2>
+			<h2 class="mt-4 text-xl">{ fmt.Sprintf("%d Parent Groups:", len(group.MemberOf)) }</h2>
 			<div class="list-container">
-				for _, parentDN := range group.MemberOf {
+				for _, parentGroup := range group.ParentGroups {
 					<div class="list-row">
-						<span class="px-3 py-2 text-sm text-text-secondary">{ parentDN }</span>
+						<a
+							href={ groupUrl(parentGroup) }
+							class="list-link"
+							title={ "View group details: " + parentGroup.CN() }
+						>
+							<span>{ parentGroup.CN() }</span>
+							@rightArrowIcon()
+						</a>
 					</div>
 				}
 			</div>
 		}
-		<h2 class="mt-4 text-xl">Members:</h2>
+		<h2 class="mt-4 text-xl">{ fmt.Sprintf("%d Direct Members:", len(group.Members)) }</h2>
 		<div class="list-container">
 			for _, user := range group.Members {
 				<div class="list-row">

internal/web/templates/index.templ

@@ -1,9 +1,9 @@
 package templates
 
-import "github.com/netresearch/simple-ldap-go"
+import "github.com/netresearch/ldap-manager/internal/ldap_cache"
 import "fmt"
 
-templ Index(user *ldap.User) {
+templ Index(user *ldap_cache.FullLDAPUser) {
 	@loggedIn("/", "Home", []Flash{}) {
 		<h1 class="mb-4 text-3xl">Hi { user.CN() }!</h1>
 		if user.Description != "" {
@@ -28,11 +28,25 @@ templ Index(user *ldap.User) {
 					</a>
 				</p>
 			}
-			<p>
-				<span class="text-text-secondary">Groups: </span>
-				<span>{ fmt.Sprintf("%d", len(user.Groups)) } memberships</span>
-			</p>
 		</div>
+		<h2 class="mt-4 text-xl">{ fmt.Sprintf("%d Direct Groups:", len(user.Groups)) }</h2>
+		<div class="list-container">
+			for _, group := range user.Groups {
+				<div class="list-row">
+					<a
+						href={ groupUrl(group) }
+						class="list-link"
+						title={ "View group details: " + group.CN() }
+					>
+						<span>{ group.CN() }</span>
+						@rightArrowIcon()
+					</a>
+				</div>
+			}
+		</div>
+		if len(user.Groups) == 0 {
+			<p class="text-text-secondary">No group memberships</p>
+		}
 	}
 }
 

internal/web/templates/users.templ

@@ -54,6 +54,12 @@ templ User(user *ldap_cache.FullLDAPUser, unassignedGroups []ldap.Group, flashes
 					<p class="font-medium">{ user.Description }</p>
 				</div>
 			}
+			if user.LastLogon > 0 {
+				<div class="rounded-md border border-border bg-surface-elevated px-3 py-2">
+					<span class="text-sm text-text-secondary">Last Logon</span>
+					<p class="font-medium">{ formatLastLogon(user.LastLogon) }</p>
+				</div>
+			}
 		</div>
 		<h2 class="mt-4 text-xl">Groups:</h2>
 		<div class="list-container">